Skip to content

fix allow single partition optimization #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gridnevvvit merged 1 commit into from
Jan 23, 2024
Merged

fix allow single partition optimization #1212

gridnevvvit merged 1 commit into from
Jan 23, 2024

Conversation

@gridnevvvit
Copy link
Member

@gridnevvvit gridnevvvit commented Jan 22, 2024

Changelog entry

fix single optimization in kqp planner

Changelog category

  • Bugfix

Additional information

...

@github-actions
Copy link

github-actions bot commented Jan 22, 2024 •
edited
Loading

⚪ 2024-01-22 18:43:47 UTC Pre-commit check for 7e49643 has started.
⚪ 2024-01-22 18:43:49 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-01-22 18:46:33 UTC Build failed. see the build logs.
⚪ 2024-01-22 18:46:46 UTC Tests are running...
🔴 2024-01-22 19:56:08 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60012 50763 0 4 9228 17

@github-actions
Copy link

github-actions bot commented Jan 22, 2024 •
edited
Loading

⚪ 2024-01-22 18:44:00 UTC Pre-commit check for 7e49643 has started.
⚪ 2024-01-22 18:44:03 UTC Build linux-x86_64-release-asan is running...
🔴 2024-01-22 18:46:50 UTC Build failed. see the build logs.
⚪ 2024-01-22 18:46:59 UTC Tests are running...
🔴 2024-01-22 20:25:48 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15914 15792 0 36 66 20

spuchin
spuchin reviewed Jan 23, 2024
View reviewed changes
ydb/core/kqp/executer_actor/kqp_data_executer.cpp
const bool enableOptForTasks = !UnknownAffectedShardCount && !HasExternalSources;
const bool singlePartitionOptAllowed = !UnknownAffectedShardCount && !HasExternalSources && (DatashardTxs.size() == 0);
const bool useDataQueryPool = !(HasExternalSources && DatashardTxs.size() == 0);
const bool localComputeTasks = !((HasExternalSources || HasOlapTable || HasDatashardSourceScan) && DatashardTxs.size() == 0);
Copy link
Collaborator

@spuchin spuchin Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вот это условие для меня не очень понятно.

spuchin
spuchin reviewed Jan 23, 2024
View reviewed changes
ydb/core/kqp/executer_actor/kqp_data_executer.cpp
}

const bool enableOptForTasks = !UnknownAffectedShardCount && !HasExternalSources;
const bool singlePartitionOptAllowed = !UnknownAffectedShardCount && !HasExternalSources && (DatashardTxs.size() == 0);
Copy link
Collaborator

@spuchin spuchin Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не совсем ясно чем тут релевантен HasExternalSources.

@gridnevvvit gridnevvvit merged commit d84a0c9 into ydb-platform:main Jan 23, 2024
@gridnevvvit gridnevvvit deleted the singlePartitionOpt branch January 23, 2024 08:59
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 24, 2024
Merged
@FloatingCrowbar FloatingCrowbar mentioned this pull request Jan 24, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 25, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 25, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Jan 25, 2024
Merged
This was referenced Jan 25, 2024
Merged
Merged
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 29, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 29, 2024
Merged
@shnikd shnikd mentioned this pull request Jan 29, 2024
Merged
This was referenced Jan 29, 2024
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Jan 30, 2024
Merged
This was referenced Jan 30, 2024
Merged
Merged
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 5, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 5, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 6, 2024
Closed
Merged
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
This was referenced Feb 12, 2024
Merged
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spuchin spuchin spuchin approved these changes

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gridnevvvit @spuchin