Skip to content

Use fallthrough and fix holder initialization #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nshestakov merged 1 commit into from
Jan 23, 2024
Merged

Use fallthrough and fix holder initialization #1221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ydb/core/kafka_proxy/kafka_connection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,6 +606,8 @@ class TKafkaConnection: public TActorBootstrapped<TKafkaConnection>, public TNet

Step = INFLIGTH_CHECK;

[[fallthrough]];

case INFLIGTH_CHECK:
if (!Context->Authenticated() && !PendingRequestsQueue.empty()) {
// Allow only one message to be processed at a time for non-authenticated users
Expand All @@ -618,6 +620,8 @@ class TKafkaConnection: public TActorBootstrapped<TKafkaConnection>, public TNet
InflightSize += Request->ExpectedSize;
Step = MESSAGE_READ;

[[fallthrough]];

case HEADER_READ:
KAFKA_LOG_T("start read header. ExpectedSize=" << Request->ExpectedSize);

Expand Down Expand Up @@ -649,6 +653,8 @@ class TKafkaConnection: public TActorBootstrapped<TKafkaConnection>, public TNet

Step = MESSAGE_READ;

[[fallthrough]];

case MESSAGE_READ:
KAFKA_LOG_T("start read new message. ExpectedSize=" << Request->ExpectedSize);

Expand Down
2 changes: 1 addition & 1 deletion ydb/core/persqueue/pq_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3890,7 +3890,7 @@ void TPersQueue::Handle(TEvPQ::TEvSourceIdRequest::TPtr& ev, const TActorContext
if (it == Partitions.end()) {
LOG_INFO_S(ctx, NKikimrServices::PERSQUEUE, "Unknown partition " << record.GetPartition());

auto response = THolder<TEvPQ::TEvSourceIdResponse>();
auto response = MakeHolder<TEvPQ::TEvSourceIdResponse>();
response->Record.SetError("Partition was not found");
Send(ev->Sender, response.Release());

Expand Down