Skip to content

use YDB_KAFKA_PROXY_PORT for enable kafka #12242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rekby merged 11 commits into from
Dec 3, 2024
Merged

use YDB_KAFKA_PROXY_PORT for enable kafka #12242

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a1aca00
init kafka support
rekby Nov 7, 2024
aac6025
add kafka port without tls
rekby Nov 22, 2024
b6dedaa
Merge branch 'main' into 11005-local-kafka-api
rekby Nov 22, 2024
c9399b1
remove debug print
rekby Nov 22, 2024
9d76906
doc
rekby Nov 25, 2024
318522e
revert doc change in functional pr
rekby Nov 25, 2024
d498002
fix linter and enexisted var
rekby Nov 25, 2024
c2cc2c6
universal parse true string
rekby Nov 29, 2024
7efd791
style refactor
rekby Dec 2, 2024
410f2db
fix typo
rekby Dec 2, 2024
63f9488
use YDB_KAFKA_PROXY_PORT for enable kafka port
rekby Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions ydb/public/tools/lib/cmds/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,8 +359,8 @@ def deploy(arguments):
if 'YDB_EXPERIMENTAL_PG' in os.environ:
optionals['pg_compatible_expirement'] = True

if _is_env_option_enabled('YDB_KAFKA_API_ENABLED'):
kafka_api_port = int(os.environ.get("YDB_KAFKA_PROXY_PORT", "9092"))
kafka_api_port = int(os.environ.get("YDB_KAFKA_PROXY_PORT", "0"))
if kafka_api_port != 0:
Copy link
Collaborator

@maximyurchuk maximyurchuk Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

У тебя ошибка фактическая: по дефолту возвращается "0", а сравниваешь с 0

Copy link
Collaborator

@maximyurchuk maximyurchuk Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Предлагаю

    kafka_api_port = int(os.environ.get("YDB_KAFKA_PROXY_PORT"))
    if kafka_api_port is not None:
        ...

Copy link
Member Author

@rekby rekby Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

у меня там ещё приведение к int-у есть:

int(os.environ.get("YDB_KAFKA_PROXY_PORT", "0"))

optionals['kafka_api_port'] = kafka_api_port

configuration = KikimrConfigGenerator(
Expand Down Expand Up @@ -551,12 +551,3 @@ def start_recipe(args):
def stop_recipe(args):
arguments = produce_arguments(args)
cleanup(arguments)


def _is_true_string(s):
s = s.upper()
return s in ['1', 'TRUE', 'YES', 'ON']


def _is_env_option_enabled(name):
return _is_true_string(os.environ.get(name, "FALSE"))
Loading