Skip to content

Conversation

@snaury
Copy link
Member

@snaury snaury commented Dec 20, 2024

Changelog entry

Abort volatile transactions during graceful restarts.

Changelog category

  • Improvement

Additional information

Volatile transactions don't migrate across restarting datashards (yet), and effectively abort when any shard restarts. However, since KQP doesn't receive any reply it cannot be sure of the outcome, and replied with an UNDETERMINED error since transaction could have committed, restarting just before it would have tried sending the reply. This change short circuits volatile transaction causing a deterministic abort, instead of a likely futile attempt at execution.

Fixes #12303.

@snaury snaury self-assigned this Dec 20, 2024
@github-actions
Copy link

github-actions bot commented Dec 20, 2024

2024-12-20 08:00:06 UTC Pre-commit check for e2f95f4 has started.
2024-12-20 08:02:45 UTC Build linux-x86_64-release-asan is running...
🟢 2024-12-20 08:28:59 UTC Build successful.
2024-12-20 08:29:16 UTC Tests are running...
🔴 2024-12-20 10:40:32 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10373 10273 0 25 28 47

🟢 2024-12-20 10:41:19 UTC ydbd size 5.6 GiB changed* by +49.4 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 11eb58f merge: e2f95f4 diff diff %
ydbd size 6 002 539 248 Bytes 6 002 589 840 Bytes +49.4 KiB +0.001%
ydbd stripped size 1 504 193 600 Bytes 1 504 202 880 Bytes +9.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 20, 2024

2024-12-20 08:00:16 UTC Pre-commit check for e2f95f4 has started.
2024-12-20 08:03:03 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-12-20 08:46:18 UTC Build successful.
2024-12-20 08:46:35 UTC Tests are running...
🔴 2024-12-20 10:16:39 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14698 13348 0 10 1300 40

🟢 2024-12-20 10:17:38 UTC ydbd size 8.3 GiB changed* by +31.2 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 11eb58f merge: e2f95f4 diff diff %
ydbd size 8 873 502 784 Bytes 8 873 534 752 Bytes +31.2 KiB +0.000%
ydbd stripped size 484 350 248 Bytes 484 352 296 Bytes +2.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury marked this pull request as ready for review December 20, 2024 09:05
@snaury snaury requested a review from a team as a code owner December 20, 2024 09:05
@snaury snaury merged commit ef48b00 into ydb-platform:stable-24-3 Dec 23, 2024
6 of 10 checks passed
@snaury snaury deleted the feature-12303-volatile-abort-on-restart-24-3 branch December 23, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants