Skip to content

ci: don't override old PR build status comment on every build #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikitka merged 1 commit into from
Jan 25, 2024
Merged

ci: don't override old PR build status comment on every build #1284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/scripts/tests/comment-pr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,18 @@ def main():
elif args.fail:
color = 'red'

run_number = int(os.environ.get("GITHUB_RUN_NUMBER"))
build_preset = os.environ["BUILD_PRESET"]

gh = Github(auth=GithubAuth.Token(os.environ["GITHUB_TOKEN"]))

with open(os.environ["GITHUB_EVENT_PATH"]) as fp:
event = json.load(fp)

prnum = event.get("pull_request")
if not prnum is None:
pr = gh.create_from_raw_data(PullRequest, prnum)
update_pr_comment_text(pr, build_preset, color, args.text.read().rstrip(), args.rewrite)
pr = gh.create_from_raw_data(PullRequest, event["pull_request"])
update_pr_comment_text(pr, build_preset, run_number, color, args.text.read().rstrip(), args.rewrite)


if __name__ == "__main__":
main()
if os.environ.get('GITHUB_EVENT_NAME', '').startswith('pull_request'):
main()
4 changes: 3 additions & 1 deletion .github/scripts/tests/generate-summary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,9 @@ def main():
else:
color = 'green'

update_pr_comment_text(pr, args.build_preset, color, text='\n'.join(text), rewrite=False)
run_number = int(os.environ.get("GITHUB_RUN_NUMBER"))

update_pr_comment_text(pr, args.build_preset, run_number, color, text='\n'.join(text), rewrite=False)


if __name__ == "__main__":
Expand Down
4 changes: 2 additions & 2 deletions .github/scripts/tests/gh_status.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ def get_platform_name():
return f'{platform.system().lower()}-{platform.machine()}'


def update_pr_comment_text(pr: PullRequest, build_preset: str, color: str, text: str, rewrite: bool):
def update_pr_comment_text(pr: PullRequest, build_preset: str, run_number: int, color: str, text: str, rewrite: bool):
platform_name = get_platform_name()
header = f"<!-- status pr={pr.number}, preset={platform_name}-{build_preset} -->"
header = f"<!-- status pr={pr.number}, preset={platform_name}-{build_preset}, run={run_number} -->"

body = comment = None
for c in pr.get_issue_comments():
Expand Down