Skip to content

Enable real arithmetic. #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tony-Romanov merged 1 commit into from
Jan 29, 2024
Merged

Enable real arithmetic. #1352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ydb/core/kqp/opt/physical/kqp_opt_phy_olap_filter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@ void SplitForPartialPushdown(const NPushdown::TPredicateNode& predicateTree, NPu
}

bool IsGoodTypeForPushdown(const TTypeAnnotationNode& type) {
return NUdf::EDataTypeFeatures::IntegralType & NUdf::GetDataTypeInfo(RemoveOptionality(type).Cast<TDataExprType>()->GetSlot()).Features;
return NUdf::EDataTypeFeatures::NumericType & NUdf::GetDataTypeInfo(RemoveOptionality(type).Cast<TDataExprType>()->GetSlot()).Features;
}

bool IsGoodTypesForPushdownCompare(const TTypeAnnotationNode& typeOne, const TTypeAnnotationNode& typeTwo) {
Expand Down
7 changes: 6 additions & 1 deletion ydb/core/kqp/ut/olap/kqp_olap_ut.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1689,6 +1689,11 @@ Y_UNIT_TEST_SUITE(KqpOlap) {
R"(`level` IS NOT NULL AND `message` IS NOT NULL)",
R"(`level` IS NULL XOR `message` IS NOT NULL)",
R"(`level` IS NULL XOR `message` IS NULL)",
R"(`level` + 2. < 5.f)",
R"(`level` - 2.f >= 1.)",
R"(`level` * 3. > 4.f)",
R"(`level` / 2.f <= 1.)",
R"(`level` % 3. != 1.f)",
#endif
};

Expand Down Expand Up @@ -1749,14 +1754,14 @@ Y_UNIT_TEST_SUITE(KqpOlap) {
R"(`level` >= CAST("2" As Uint32))",
R"(`level` = NULL)",
R"(`level` > NULL)",
R"(`level` * 3.14 > 4)",
#if SSA_RUNTIME_VERSION < 2U
R"(`uid` LIKE "%30000%")",
R"(`uid` LIKE "uid%")",
R"(`uid` LIKE "%001")",
R"(`uid` LIKE "uid%001")",
#endif
#if SSA_RUNTIME_VERSION < 4U
R"(`level` * 3.14 > 4)",
R"(LENGTH(`uid`) > 0 OR `resource_id` = "10001")",
R"((LENGTH(`uid`) > 0 AND `resource_id` = "10001") OR `resource_id` = "10002")",
R"((LENGTH(`uid`) > 0 OR `resource_id` = "10002") AND (LENGTH(`uid`) < 15 OR `resource_id` = "10001"))",
Expand Down