minor improvements to cs scan #14376
Conversation
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| return true; | ||
| } | ||
| } | ||
| return SortedRanges.empty(); |
There was a problem hiding this comment.
Вот тут было неконсистентно с IsPortionInPartialUsage. IsPortionInUsage было не то же самое, как EUsageClass::DontUsage. Можно, конечно, придумать, зачем это могло понадобиться, но выглядит, как баг
| "from", toContainerConclusion.GetErrorMessage()); | ||
| return toContainerConclusion; | ||
| } | ||
| if (SortedRanges.size() && !FakeRanges) { |
There was a problem hiding this comment.
Непонятно, зачем нуже FakeRanges. Кажется, должно хватить проверки на непустоту SortedRanges
| insertedPortionsBytes += i->GetTotalBlobBytes(); | ||
| } | ||
|
|
||
| std::make_shared<TPortionDataSource>(sourceIdx++, i, SpecialReadContext); |
There was a problem hiding this comment.
накручивали счётчик sourceIdx впустую? Не исследовал, но, если он потом использовался, то могли читать чужую память
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
zverevgeny
force-pushed
the
scan_cosmitic_changes
branch
from
75a9b37 to
ef04cc5
Compare
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
zverevgeny
requested review from
avevad and
ivanmorozov333
and removed request for
avevad
2 participants
Changelog category