Skip to content

Conversation

@snaury
Copy link
Member

@snaury snaury commented Feb 14, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Fixes EvWrite with TxId=0 when combined with volatile transactions. EvWrite is currently experimental and not used in production.

Fixes #14553

@snaury snaury self-assigned this Feb 14, 2025
@github-actions
Copy link

github-actions bot commented Feb 14, 2025

2025-02-14 10:44:11 UTC Pre-commit check linux-x86_64-release-asan for deec724 has started.
2025-02-14 10:45:43 UTC Artifacts will be uploaded here
2025-02-14 10:48:33 UTC ya make is running...
🟡 2025-02-14 11:51:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11777 11647 0 79 16 35

2025-02-14 11:52:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-14 12:06:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
178 (only retried tests) 139 0 1 3 35

2025-02-14 12:06:12 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-14 12:23:31 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67 (only retried tests) 33 0 0 2 32

🟢 2025-02-14 12:23:40 UTC Build successful.
🟢 2025-02-14 12:24:07 UTC ydbd size 3.6 GiB changed* by +944 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: f97d523 merge: deec724 diff diff %
ydbd size 3 884 094 912 Bytes 3 884 095 856 Bytes +944 Bytes +0.000%
ydbd stripped size 1 360 024 400 Bytes 1 360 024 720 Bytes +320 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 14, 2025

2025-02-14 10:44:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for deec724 has started.
2025-02-14 10:44:24 UTC Artifacts will be uploaded here
2025-02-14 10:47:27 UTC ya make is running...
🟡 2025-02-14 11:40:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19063 17705 0 3 1220 135

2025-02-14 11:42:40 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-14 12:02:55 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
213 (only retried tests) 85 0 0 2 126

🟢 2025-02-14 12:03:02 UTC Build successful.
🟢 2025-02-14 12:03:25 UTC ydbd size 2.1 GiB changed* by +816 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: f97d523 merge: deec724 diff diff %
ydbd size 2 233 392 384 Bytes 2 233 393 200 Bytes +816 Bytes +0.000%
ydbd stripped size 473 981 560 Bytes 473 981 816 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury marked this pull request as ready for review February 14, 2025 10:44
@snaury snaury requested a review from azevaykin February 14, 2025 10:44
@snaury snaury merged commit 7a0b0c7 into ydb-platform:main Feb 14, 2025
13 checks passed
@snaury snaury deleted the bugfix-14553-evwrite-volatile branch February 14, 2025 12:27
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
blinkov pushed a commit that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DataShard: EvWrite doesn't handle immediate writes with TxId=0 correctly

2 participants