Skip to content

Conversation

@MBkkt
Copy link
Contributor

@MBkkt MBkkt commented Feb 14, 2025

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

We decided to change cluster id type: uint64 instead of uint32

  1. We will need at least single bit for flag (skip levels)
  2. If index will be mutable, creating new cluster/removing old, will be more difficult with cluster id -- uint32

@MBkkt MBkkt self-assigned this Feb 14, 2025
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@MBkkt MBkkt marked this pull request as ready for review February 15, 2025 15:19
@MBkkt MBkkt requested review from a team as code owners February 15, 2025 15:19
@MBkkt MBkkt force-pushed the mbkkt/uint64_id_vector_index branch from 49952fb to dad2b34 Compare February 17, 2025 12:05
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@MBkkt MBkkt requested a review from snaury February 17, 2025 14:02
azevaykin
azevaykin previously approved these changes Feb 17, 2025
@github-actions
Copy link

github-actions bot commented Feb 17, 2025

2025-02-17 14:53:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for b00972a has started.
2025-02-17 14:53:08 UTC Artifacts will be uploaded here
2025-02-17 14:56:24 UTC ya make is running...
🟢 2025-02-17 16:08:22 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27990 25394 0 0 2458 138

🟢 2025-02-17 16:10:50 UTC Build successful.
🟢 2025-02-17 16:11:09 UTC ydbd size 2.1 GiB changed* by +2.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 609889d merge: b00972a diff diff %
ydbd size 2 236 263 928 Bytes 2 236 266 280 Bytes +2.3 KiB +0.000%
ydbd stripped size 473 848 280 Bytes 473 849 144 Bytes +864 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 17, 2025

2025-02-17 14:53:47 UTC Pre-commit check linux-x86_64-release-asan for b00972a has started.
2025-02-17 14:53:51 UTC Artifacts will be uploaded here
2025-02-17 14:57:02 UTC ya make is running...
🟡 2025-02-17 16:11:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13771 13660 0 56 20 35

2025-02-17 16:13:25 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-17 16:26:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
160 (only retried tests) 117 0 4 5 34

2025-02-17 16:26:40 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-17 16:44:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75 (only retried tests) 34 0 4 6 31

🟢 2025-02-17 16:44:16 UTC Build successful.
🟢 2025-02-17 16:44:46 UTC ydbd size 3.6 GiB changed* by -3.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 609889d merge: b00972a diff diff %
ydbd size 3 890 045 208 Bytes 3 890 041 424 Bytes -3.7 KiB -0.000%
ydbd stripped size 1 361 717 056 Bytes 1 361 712 704 Bytes -4.2 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants