Skip to content

YQ remove anonymous namespace from CA #14636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GrigoriyPA merged 3 commits into from
Feb 17, 2025
Merged

YQ remove anonymous namespace from CA #14636

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3003be6
Removed anonymous namespace
GrigoriyPA Feb 17, 2025
394d5be
Moved into private space
GrigoriyPA Feb 17, 2025
38dce73
Fixed event name
GrigoriyPA Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 20 additions & 23 deletions ydb/library/yql/dq/actors/compute/dq_compute_actor_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,29 +42,6 @@
namespace NYql {
namespace NDq {

namespace {

struct TEvPrivate {
enum EEv : ui32 {
EvRuntimeError = EventSpaceBegin(NActors::TEvents::ES_PRIVATE),
EvEnd
};

static_assert(EvEnd < EventSpaceEnd(NActors::TEvents::ES_PRIVATE), "expect EvEnd < EventSpaceEnd(TEvents::ES_PRIVATE)");

struct TEvAsyncOutputError : public NActors::TEventLocal<TEvAsyncOutputError, EvRuntimeError> {
TEvAsyncOutputError(NYql::NDqProto::StatusIds::StatusCode statusCode, const TIssues& issues)
: StatusCode(statusCode)
, Issues(issues)
{}

NYql::NDqProto::StatusIds::StatusCode StatusCode;
NYql::TIssues Issues;
};
};

} // anonymous namespace

struct TSinkCallbacks : public IDqComputeActorAsyncOutput::ICallbacks {
void OnAsyncOutputError(ui64 outputIndex, const TIssues& issues, NYql::NDqProto::StatusIds::StatusCode fatalCode) override final {
OnSinkError(outputIndex, issues, fatalCode);
Expand Down Expand Up @@ -121,6 +98,26 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived>
, public TSinkCallbacks
, public TOutputTransformCallbacks
{
private:
struct TEvPrivate {
enum EEv : ui32 {
EvAsyncOutputError = EventSpaceBegin(NActors::TEvents::ES_PRIVATE),
EvEnd
};

static_assert(EvEnd < EventSpaceEnd(NActors::TEvents::ES_PRIVATE), "expect EvEnd < EventSpaceEnd(TEvents::ES_PRIVATE)");

struct TEvAsyncOutputError : public NActors::TEventLocal<TEvAsyncOutputError, EvAsyncOutputError> {
TEvAsyncOutputError(NYql::NDqProto::StatusIds::StatusCode statusCode, const TIssues& issues)
: StatusCode(statusCode)
, Issues(issues)
{}

NYql::NDqProto::StatusIds::StatusCode StatusCode;
NYql::TIssues Issues;
};
};

protected:
enum EEvWakeupTag : ui64 {
TimeoutTag = 1,
Expand Down
Loading