Skip to content

Conversation

@UgnineSirdis
Copy link
Collaborator

@UgnineSirdis UgnineSirdis commented Feb 17, 2025

Changelog entry

There is no WorkingDirectory parameter in "move" scheme shard operations. Audit logs use this parameter to define database label in log. So I took directory for defining database from source path of move operations in order to fix lack of database in audit logs.

Changelog category

  • Bugfix

Description for reviewers

...

@UgnineSirdis UgnineSirdis requested a review from a team as a code owner February 17, 2025 12:03
@github-actions
Copy link

github-actions bot commented Feb 17, 2025

2025-02-17 12:12:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for baa91b1 has started.
2025-02-17 12:12:14 UTC Artifacts will be uploaded here
2025-02-17 12:15:10 UTC ya make is running...
🟡 2025-02-17 13:03:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19079 17726 0 2 1217 134

2025-02-17 13:05:07 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-17 13:27:34 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
208 (only retried tests) 80 0 1 1 126

2025-02-17 13:27:45 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-17 13:48:08 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
188 (only retried tests) 61 0 0 1 126

🟢 2025-02-17 13:48:17 UTC Build successful.
🟢 2025-02-17 13:48:41 UTC ydbd size 2.1 GiB changed* by +1.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7352479 merge: baa91b1 diff diff %
ydbd size 2 236 015 496 Bytes 2 236 017 424 Bytes +1.9 KiB +0.000%
ydbd stripped size 473 777 432 Bytes 473 778 072 Bytes +640 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 17, 2025

2025-02-17 12:12:02 UTC Pre-commit check linux-x86_64-release-asan for baa91b1 has started.
2025-02-17 12:14:25 UTC Artifacts will be uploaded here
2025-02-17 12:17:15 UTC ya make is running...
🟡 2025-02-17 13:30:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11783 11664 0 70 12 37

2025-02-17 13:31:10 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-17 13:43:14 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
169 (only retried tests) 132 0 0 5 32

🟢 2025-02-17 13:43:21 UTC Build successful.
🟢 2025-02-17 13:43:48 UTC ydbd size 3.6 GiB changed* by +2.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7352479 merge: baa91b1 diff diff %
ydbd size 3 889 575 976 Bytes 3 889 578 560 Bytes +2.5 KiB +0.000%
ydbd stripped size 1 361 477 520 Bytes 1 361 478 096 Bytes +576 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions github-actions bot added bugfix and removed bugfix labels Feb 17, 2025
@UgnineSirdis UgnineSirdis enabled auto-merge (squash) February 17, 2025 13:08
@UgnineSirdis UgnineSirdis merged commit 0921658 into ydb-platform:main Feb 17, 2025
14 checks passed
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Feb 17, 2025
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
@UgnineSirdis UgnineSirdis deleted the fix-audit-log-database-in-move-operations branch March 16, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants