Skip to content

Fix TEvPatch behaviour #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexvru merged 1 commit into from
Jan 31, 2024
Merged

Fix TEvPatch behaviour #1469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/config/muted_ya.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ ydb/core/blobstorage/dsproxy/ut TBlobStorageProxySequenceTest.TestBlock42PutWith
ydb/core/blobstorage/dsproxy/ut_fat TBlobStorageProxyTest.TestBatchedPutRequestDoesNotContainAHugeBlob
ydb/core/blobstorage/pdisk/ut TSectorMap.*
ydb/core/blobstorage/ut_blobstorage/ut_read_only_vdisk ReadOnlyVDisk.TestStorageLoad
ydb/core/blobstorage/ut_blobstorage BlobPatching.PatchBlock42
ydb/core/blobstorage/ut_blobstorage CostMetricsGetBlock4Plus2.TestGet4Plus2BlockRequests10000Inflight1BlobSize1000
ydb/core/blobstorage/ut_blobstorage Defragmentation.DoesItWork
ydb/core/blobstorage/ut_blobstorage SpaceCheckForDiskReassign.*
Expand Down
4 changes: 2 additions & 2 deletions ydb/core/blobstorage/vdisk/skeleton/skeleton_vpatch_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ namespace NKikimr::NPrivate {
(ResultSize, record.ResultSize()),
(ParityPart, (blobId.PartId() <= GType.DataParts() ? "no" : "yes")));

ui8 *buffer = reinterpret_cast<ui8*>(Buffer.UnsafeGetContiguousSpanMut().data());
ui8 *buffer = reinterpret_cast<ui8*>(Buffer.GetContiguousSpanMut().data());
if (PatchedPartId <= GType.DataParts()) {
AddMark("Data part");
if (GType.ErasureFamily() != TErasureType::ErasureMirror) {
Expand Down Expand Up @@ -675,7 +675,7 @@ namespace NKikimr::NPrivate {
}

if (Buffer) {
ui8 *buffer = reinterpret_cast<ui8*>(Buffer.UnsafeGetContiguousSpanMut().data());
ui8 *buffer = reinterpret_cast<ui8*>(Buffer.GetContiguousSpanMut().data());
ui32 dataSize = OriginalBlobId.BlobSize();

AddMark("Apply xor diff");
Expand Down