Skip to content

Conversation

@CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Feb 18, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@CyberROFL CyberROFL requested a review from Enjection February 18, 2025 20:56
@CyberROFL CyberROFL marked this pull request as ready for review February 18, 2025 20:56
@CyberROFL CyberROFL requested a review from a team as a code owner February 18, 2025 20:56
@github-actions
Copy link

github-actions bot commented Feb 18, 2025

🟢 2025-02-18 20:59:12 UTC The validation of the Pull Request description is successful.

@CyberROFL CyberROFL force-pushed the database-config-allowed-opts branch from 342c1cf to bfd0ff1 Compare February 18, 2025 20:57
@CyberROFL CyberROFL changed the title Mark options allowed for use in the database configuration Mark options that are allowed to be used in the database configuration Feb 18, 2025
@github-actions
Copy link

github-actions bot commented Feb 18, 2025

2025-02-18 21:00:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 177a793 has started.
2025-02-18 21:06:52 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Feb 18, 2025

2025-02-18 21:01:52 UTC Pre-commit check linux-x86_64-release-asan for 177a793 has started.
2025-02-18 21:02:40 UTC Artifacts will be uploaded here
2025-02-18 21:06:08 UTC ya make is running...
2025-02-18 21:06:56 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Feb 18, 2025

2025-02-18 21:09:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for cadb6f5 has started.
2025-02-18 21:09:34 UTC Artifacts will be uploaded here
2025-02-18 21:13:02 UTC ya make is running...
🟡 2025-02-18 22:41:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28027 25427 0 1 2462 137

2025-02-18 22:43:57 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-18 23:09:11 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
212 (only retried tests) 79 0 0 2 131

🟢 2025-02-18 23:09:19 UTC Build successful.
🟢 2025-02-18 23:09:40 UTC ydbd size 2.1 GiB changed* by +10.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a48e948 merge: cadb6f5 diff diff %
ydbd size 2 237 664 768 Bytes 2 237 675 296 Bytes +10.3 KiB +0.000%
ydbd stripped size 474 182 680 Bytes 474 183 896 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 18, 2025

2025-02-18 21:11:14 UTC Pre-commit check linux-x86_64-release-asan for cadb6f5 has started.
2025-02-18 21:16:57 UTC Artifacts will be uploaded here
2025-02-18 21:20:16 UTC ya make is running...
🟡 2025-02-18 22:58:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13795 13658 0 84 14 39

2025-02-18 22:59:33 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-18 23:24:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
191 (only retried tests) 151 0 3 3 34

2025-02-18 23:24:28 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-18 23:37:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71 (only retried tests) 33 0 1 3 34

🟢 2025-02-18 23:37:46 UTC Build successful.
🟢 2025-02-18 23:38:21 UTC ydbd size 3.6 GiB changed* by +20.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a48e948 merge: cadb6f5 diff diff %
ydbd size 3 892 971 712 Bytes 3 892 993 088 Bytes +20.9 KiB +0.001%
ydbd stripped size 1 362 937 728 Bytes 1 362 945 312 Bytes +7.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL enabled auto-merge (squash) February 18, 2025 21:23
@CyberROFL CyberROFL merged commit 0402fc0 into ydb-platform:main Feb 18, 2025
12 checks passed
@CyberROFL CyberROFL deleted the database-config-allowed-opts branch February 19, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Per-database configs must forbid to use any fields except allowlisted ones

2 participants