-
Notifications
You must be signed in to change notification settings - Fork 743
Avoid relying on refcount for mediator bucket cleanup #14806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid relying on refcount for mediator bucket cleanup #14806
Conversation
|
🟢 |
|
⚪ |
|
⚪ |
de44ec0 to
b543ca2
Compare
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Description for reviewers
I noticed that timecast service used bucket entry refcount to make some decisions, which are leftovers of the old behavior before the rewrite (e.g. the case for
RefCount() == 0cannot even happen anymore). Check forTablets.empty()explicitly instead, and clear waiters consistently on either update or reconnect.Related to #14029.