Skip to content

EvWrite: Fix status (UNAVAILABLE -> UNDETERMINED) #14839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikvas0 merged 2 commits into from
Feb 20, 2025
Merged

EvWrite: Fix status (UNAVAILABLE -> UNDETERMINED) #14839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c917f25
fix
nikvas0 Feb 20, 2025
e2aed4e
fix
nikvas0 Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ydb/core/kqp/executer_actor/kqp_data_executer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,8 +365,13 @@ class TKqpDataExecuter : public TKqpExecuterBase<TKqpDataExecuter, EExecType::Da
}

void HandleFinalize(TEvents::TEvUndelivered::TPtr&) {
auto issue = YqlIssue({}, TIssuesIds::KIKIMR_OPERATION_STATE_UNKNOWN, "Buffer actor isn't available. Operation state unknown.");
ReplyErrorAndDie(Ydb::StatusIds::UNDETERMINED, issue);
if (Request.LocksOp == ELocksOp::Commit && !ReadOnlyTx) {
auto issue = YqlIssue({}, TIssuesIds::KIKIMR_OPERATION_STATE_UNKNOWN, "Buffer actor isn't available. Operation state unknown.");
ReplyErrorAndDie(Ydb::StatusIds::UNDETERMINED, issue);
} else {
auto issue = YqlIssue({}, TIssuesIds::KIKIMR_TEMPORARILY_UNAVAILABLE, "Buffer actor isn't available.");
ReplyErrorAndDie(Ydb::StatusIds::UNAVAILABLE, issue);
}
}

void MakeResponseAndPassAway() {
Expand Down
5 changes: 2 additions & 3 deletions ydb/core/kqp/runtime/kqp_write_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,7 +979,7 @@ class TKqpTableWriteActor : public TActorBootstrapped<TKqpTableWriteActor> {
TxManager->SetError(ev->Get()->TabletId);
if (Mode == EMode::IMMEDIATE_COMMIT) {
RuntimeError(
NYql::NDqProto::StatusIds::UNAVAILABLE,
NYql::NDqProto::StatusIds::UNDETERMINED,
NYql::TIssuesIds::KIKIMR_OPERATION_STATE_UNKNOWN,
TStringBuilder()
<< "Error writing to table `" << TableId.PathId.ToString() << "`"
Expand Down Expand Up @@ -2117,14 +2117,13 @@ class TKqpBufferWriteActor :public TActorBootstrapped<TKqpBufferWriteActor>, pub
}

ReplyErrorAndDie(
NYql::NDqProto::StatusIds::UNAVAILABLE,
NYql::NDqProto::StatusIds::UNDETERMINED,
NYql::TIssuesIds::KIKIMR_OPERATION_STATE_UNKNOWN,
TStringBuilder() << "Failed to deviler message to coordinator.",
{});
return;
}


ReplyErrorAndDie(
NYql::NDqProto::StatusIds::UNAVAILABLE,
NYql::TIssuesIds::KIKIMR_TEMPORARILY_UNAVAILABLE,
Expand Down
1 change: 1 addition & 0 deletions ydb/library/yql/dq/actors/protos/dq_status_codes.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,6 @@ message StatusIds {
CLUSTER_OVERLOADED = 13;
SCHEME_ERROR = 14;
GENERIC_ERROR = 15;
UNDETERMINED = 16;
}
}
Loading