Skip to content

Conversation

@alexvru
Copy link
Collaborator

@alexvru alexvru commented Feb 20, 2025

Changelog entry

Relax some DS proxy response integrity checks

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

In order to reduce amount of false positives some checks have been relaxed.

@github-actions
Copy link

🟢 2025-02-20 15:53:15 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Feb 20, 2025

2025-02-20 15:56:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for b487f5c has started.
2025-02-20 15:57:02 UTC Artifacts will be uploaded here
2025-02-20 15:59:52 UTC ya make is running...
🟡 2025-02-20 16:48:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19381 18033 0 2 1215 131

2025-02-20 16:50:32 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-20 17:12:21 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
199 (only retried tests) 72 0 0 2 125

🟢 2025-02-20 17:12:30 UTC Build successful.
🟢 2025-02-20 17:12:48 UTC ydbd size 2.1 GiB changed* by +80 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8f7f05b merge: b487f5c diff diff %
ydbd size 2 239 506 072 Bytes 2 239 506 152 Bytes +80 Bytes +0.000%
ydbd stripped size 474 551 000 Bytes 474 551 064 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 20, 2025

2025-02-20 16:02:01 UTC Pre-commit check linux-x86_64-release-asan for b487f5c has started.
2025-02-20 16:02:24 UTC Artifacts will be uploaded here
2025-02-20 16:05:22 UTC ya make is running...
🟡 2025-02-20 17:08:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12069 11934 0 82 19 34

2025-02-20 17:10:20 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-20 17:26:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
189 (only retried tests) 149 0 1 7 32

2025-02-20 17:27:06 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-20 17:45:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68 (only retried tests) 30 0 1 4 33

🟢 2025-02-20 17:45:55 UTC Build successful.
🟢 2025-02-20 17:46:23 UTC ydbd size 3.6 GiB changed* by -384 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 8f7f05b merge: b487f5c diff diff %
ydbd size 3 895 663 616 Bytes 3 895 663 232 Bytes -384 Bytes -0.000%
ydbd stripped size 1 364 066 784 Bytes 1 364 066 784 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru enabled auto-merge (squash) February 20, 2025 16:41
@alexvru alexvru merged commit 1ab62a5 into ydb-platform:main Feb 20, 2025
14 checks passed
@alexvru alexvru deleted the dsproxy/relax-some-checks branch February 20, 2025 17:47
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
SammyVimes pushed a commit to SammyVimes/ydb that referenced this pull request Apr 23, 2025
SammyVimes pushed a commit to SammyVimes/ydb that referenced this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants