Skip to content

Conversation

@kruall
Copy link
Collaborator

@kruall kruall commented Feb 26, 2025

Changelog entry

The describe request previously failed to return channels, and the alter_volume function incorrectly modified channels based on channel_profile_id when storage_config was not set. These issues have now been resolved.

(#14978)

Changelog category

  • Bugfix

Description for reviewers

...

@kruall kruall added the area/blobstorage BlobStorage issues label Feb 26, 2025
@kruall kruall self-assigned this Feb 26, 2025
@kruall kruall requested a review from a team as a code owner February 26, 2025 10:40
@kruall kruall changed the title merge to 25-1: Fix describe_volume and alter_volume (#14978) merge to 25-1: Fix describe_volume and alter_volume Feb 26, 2025
@github-actions
Copy link

github-actions bot commented Feb 26, 2025

2025-02-26 10:42:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2508556 has started.
2025-02-26 10:42:15 UTC Artifacts will be uploaded here
2025-02-26 10:45:37 UTC ya make is running...
🟡 2025-02-26 12:31:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28068 25462 0 10 2458 138

2025-02-26 12:34:03 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-26 12:54:58 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
215 (only retried tests) 81 0 0 0 134

🟢 2025-02-26 12:55:06 UTC Build successful.
🟢 2025-02-26 12:55:24 UTC ydbd size 2.1 GiB changed* by +29.3 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: d408be7 merge: 2508556 diff diff %
ydbd size 2 241 483 840 Bytes 2 241 513 800 Bytes +29.3 KiB +0.001%
ydbd stripped size 474 776 536 Bytes 474 785 208 Bytes +8.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 26, 2025

2025-02-26 10:44:41 UTC Pre-commit check linux-x86_64-release-asan for 2508556 has started.
2025-02-26 10:45:12 UTC Artifacts will be uploaded here
2025-02-26 10:49:03 UTC ya make is running...
🟡 2025-02-26 12:38:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13831 13739 0 31 23 38

2025-02-26 12:39:49 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-26 13:00:35 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
136 (only retried tests) 93 0 0 8 35

🟢 2025-02-26 13:00:43 UTC Build successful.
🟢 2025-02-26 13:01:09 UTC ydbd size 3.6 GiB changed* by +56.4 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: d408be7 merge: 2508556 diff diff %
ydbd size 3 899 117 872 Bytes 3 899 175 600 Bytes +56.4 KiB +0.001%
ydbd stripped size 1 364 752 048 Bytes 1 364 773 104 Bytes +20.6 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kruall kruall merged commit 79eee97 into ydb-platform:stable-25-1 Feb 26, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/blobstorage BlobStorage issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants