Skip to content

Conversation

@kruall
Copy link
Collaborator

@kruall kruall commented Feb 28, 2025

Changelog entry

Describe volume required storage pool kinds of channels instead of their names. Now we set pool kind in TChannelBind and use it in grpc request

(#15135)

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@kruall kruall added the area/blobstorage BlobStorage issues label Feb 28, 2025
@kruall kruall self-assigned this Feb 28, 2025
@kruall kruall requested a review from a team as a code owner February 28, 2025 14:11
@kruall kruall changed the title Return storage pool kind in TChannelBind (#15135) merge to 25.1: Return storage pool kind in TChannelBind Feb 28, 2025
@github-actions
Copy link

github-actions bot commented Feb 28, 2025

2025-02-28 14:12:38 UTC Pre-commit check linux-x86_64-release-asan for 6fe6ed2 has started.
2025-02-28 14:12:42 UTC Artifacts will be uploaded here
2025-02-28 14:16:01 UTC ya make is running...
🟡 2025-02-28 16:07:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13835 13703 0 82 14 36

2025-02-28 16:08:48 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-28 16:34:48 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
185 (only retried tests) 148 0 0 1 36

🟢 2025-02-28 16:34:55 UTC Build successful.
🟢 2025-02-28 16:35:21 UTC ydbd size 3.6 GiB changed* by +3.5 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: d0aa06b merge: 6fe6ed2 diff diff %
ydbd size 3 899 168 880 Bytes 3 899 172 480 Bytes +3.5 KiB +0.000%
ydbd stripped size 1 364 771 248 Bytes 1 364 766 512 Bytes -4.6 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 28, 2025

2025-02-28 14:13:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6fe6ed2 has started.
2025-02-28 14:13:54 UTC Artifacts will be uploaded here
2025-02-28 14:17:19 UTC ya make is running...
🟢 2025-02-28 16:07:29 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28072 25473 0 0 2460 139

🟢 2025-02-28 16:10:09 UTC Build successful.
🟢 2025-02-28 16:10:25 UTC ydbd size 2.1 GiB changed* by +4.6 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: d0aa06b merge: 6fe6ed2 diff diff %
ydbd size 2 241 509 384 Bytes 2 241 514 072 Bytes +4.6 KiB +0.000%
ydbd stripped size 474 783 992 Bytes 474 783 928 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kruall kruall merged commit 1d0ddf7 into ydb-platform:stable-25-1 Feb 28, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/blobstorage BlobStorage issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants