Skip to content

do not filter out dead tablets, set proper hive for dead tablets #15231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adameat merged 1 commit into from
Mar 3, 2025
Merged

do not filter out dead tablets, set proper hive for dead tablets #15231

adameat merged 1 commit into from
Mar 3, 2025

Conversation

@adameat
Copy link
Member

@adameat adameat commented Mar 3, 2025 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

closes #15230

@adameat adameat requested a review from a team as a code owner March 3, 2025 06:29
@adameat adameat self-assigned this Mar 3, 2025
@adameat adameat changed the title do not filter outt dead tablets do not filter out dead tablets Mar 3, 2025
@github-actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

🟢 2025-03-03 07:28:07 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 06:32:55 UTC Pre-commit check linux-x86_64-release-asan for 2a8ae33 has started.
⚪ 2025-03-03 06:33:10 UTC Artifacts will be uploaded here
⚪ 2025-03-03 06:35:55 UTC ya make is running...
⚫ 2025-03-03 06:36:32 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 06:32:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2a8ae33 has started.
⚪ 2025-03-03 06:33:14 UTC Artifacts will be uploaded here
⚪ 2025-03-03 06:36:06 UTC ya make is running...
⚫ 2025-03-03 06:36:31 UTC Check cancelled

@adameat adameat changed the title do not filter out dead tablets do not filter out dead tablets, set proper hive for dead tablets Mar 3, 2025
@github-actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 06:40:29 UTC Pre-commit check linux-x86_64-release-asan for c9c5f77 has started.
⚪ 2025-03-03 06:40:44 UTC Artifacts will be uploaded here
⚪ 2025-03-03 06:43:36 UTC ya make is running...
🟡 2025-03-03 07:50:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11378 11232 0 89 21 36

⚪ 2025-03-03 07:51:21 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-03 08:04:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
187 (only retried tests) 141 0 10 3 33

⚪ 2025-03-03 08:04:35 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-03 08:16:38 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76 (only retried tests) 43 0 0 3 30

🟢 2025-03-03 08:16:45 UTC Build successful.
🟢 2025-03-03 08:17:15 UTC ydbd size 3.7 GiB changed* by +5.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b0bd8f9 merge: c9c5f77 diff diff %
ydbd size 3 988 298 944 Bytes 3 988 304 168 Bytes +5.1 KiB +0.000%
ydbd stripped size 1 388 482 184 Bytes 1 388 486 664 Bytes +4.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 06:40:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for c9c5f77 has started.
⚪ 2025-03-03 06:41:07 UTC Artifacts will be uploaded here
⚪ 2025-03-03 06:44:05 UTC ya make is running...
🟡 2025-03-03 07:34:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18645 17288 0 1 1217 139

⚪ 2025-03-03 07:36:19 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-03 07:49:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
207 (only retried tests) 77 0 1 0 129

⚪ 2025-03-03 07:49:25 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-03 08:02:02 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
194 (only retried tests) 64 0 1 0 129

🟢 2025-03-03 08:02:11 UTC Build successful.
🟢 2025-03-03 08:02:33 UTC ydbd size 2.1 GiB changed* by +720 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: b0bd8f9 merge: c9c5f77 diff diff %
ydbd size 2 288 336 672 Bytes 2 288 337 392 Bytes +720 Bytes +0.000%
ydbd stripped size 479 642 688 Bytes 479 642 816 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat added the rebase-and-check Rebase PR with the current base branch and check label Mar 3, 2025
@adameat adameat enabled auto-merge (squash) March 3, 2025 10:57
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Mar 3, 2025
@github-actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 11:00:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for e817e5e has started.
⚪ 2025-03-03 11:00:41 UTC Artifacts will be uploaded here
⚪ 2025-03-03 11:03:24 UTC ya make is running...
🟡 2025-03-03 11:49:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18648 17292 0 3 1217 136

⚪ 2025-03-03 11:51:11 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-03 12:02:01 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
207 (only retried tests) 82 0 0 0 125

🟢 2025-03-03 12:02:12 UTC Build successful.
🟢 2025-03-03 12:02:29 UTC ydbd size 2.1 GiB changed* by +704 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6afe3c8 merge: e817e5e diff diff %
ydbd size 2 288 459 080 Bytes 2 288 459 784 Bytes +704 Bytes +0.000%
ydbd stripped size 479 648 832 Bytes 479 648 960 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 11:01:01 UTC Pre-commit check linux-x86_64-release-asan for e817e5e has started.
⚪ 2025-03-03 11:01:16 UTC Artifacts will be uploaded here
⚪ 2025-03-03 11:04:15 UTC ya make is running...
🟡 2025-03-03 12:08:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11380 11147 0 121 76 36

⚪ 2025-03-03 12:09:16 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-03 12:29:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
308 (only retried tests) 252 0 22 1 33

⚪ 2025-03-03 12:29:58 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-03 12:42:01 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
90 (only retried tests) 59 0 0 1 30

🟢 2025-03-03 12:42:09 UTC Build successful.
🟢 2025-03-03 12:42:40 UTC ydbd size 3.7 GiB changed* by +1.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6afe3c8 merge: e817e5e diff diff %
ydbd size 3 988 492 304 Bytes 3 988 493 424 Bytes +1.1 KiB +0.000%
ydbd stripped size 1 388 505 480 Bytes 1 388 505 864 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat merged commit 5a90372 into ydb-platform:main Mar 3, 2025
21 of 22 checks passed
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 4, 2025
Closed
This was referenced Mar 10, 2025
Merged
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@adameat @blinkov
do not filter out dead tablets, set proper hive for dead tablets (#15231
e9eee10 
)
adameat added a commit to adameat/ydb that referenced this pull request Apr 29, 2025
@adameat
do not filter out dead tablets, set proper hive for dead tablets (ydb…
52013b9 
…-platform#15231)
adameat added a commit to adameat/ydb that referenced this pull request May 13, 2025
@adameat
do not filter out dead tablets, set proper hive for dead tablets (ydb…
8674834 
…-platform#15231)
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexvru alexvru alexvru approved these changes

@alexnick88 alexnick88 alexnick88 approved these changes

Assignees

@adameat adameat

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

not all tablets are shown for pers queue group on the tablets tab in diagnostics

3 participants

@adameat @alexvru @alexnick88