Skip to content

The counter value for UserInfo is leaking #15233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Alek5andr-Kotov merged 4 commits into from
Mar 3, 2025
Merged

The counter value for UserInfo is leaking #15233

Alek5andr-Kotov merged 4 commits into from
Mar 3, 2025

Conversation

@Alek5andr-Kotov
Copy link
Collaborator

@Alek5andr-Kotov Alek5andr-Kotov commented Mar 3, 2025 •
edited
Loading

Changelog entry

The counter does not decrease in case of errors. As a result, the reading session returns the error too big in flight after a while.

#15234

Changelog category

  • Bugfix

Description for reviewers

If the program has reached the processing stage of TEvPQ::TEvSetClientInfo, then you can call `RemoveUseAct'.

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner March 3, 2025 08:02
@Alek5andr-Kotov Alek5andr-Kotov requested a review from qyryq March 3, 2025 08:02
@github-actions github-actions bot added the bugfix label Mar 3, 2025
@github-actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

🔴 2025-03-03 08:13:28 UTC The validation of the Pull Request description has failed. Please update the description.

The changelog entry is less than 20 characters or missing.

@github-actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 08:05:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 45f2e87 has started.
⚪ 2025-03-03 08:05:37 UTC Artifacts will be uploaded here
⚪ 2025-03-03 08:08:33 UTC ya make is running...
🟡 2025-03-03 08:56:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19165 17807 0 1 1217 140

⚪ 2025-03-03 08:57:54 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-03 08:59:53 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: b0bd8f9 merge: 45f2e87 diff diff %
ydbd size 2 288 336 672 Bytes 2 288 336 672 Bytes 0 Bytes 0.000%
ydbd stripped size 479 642 688 Bytes 479 642 688 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-03-03 08:59:54 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 08:07:17 UTC Pre-commit check linux-x86_64-release-asan for 45f2e87 has started.
⚪ 2025-03-03 08:07:32 UTC Artifacts will be uploaded here
⚪ 2025-03-03 08:10:26 UTC ya make is running...
⚫ 2025-03-03 08:59:43 UTC Check cancelled

@Alek5andr-Kotov Alek5andr-Kotov changed the title [-] RemoveUserAct is always called The counter value for UserInfo is leaking Mar 3, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels Mar 3, 2025
@Alek5andr-Kotov Alek5andr-Kotov changed the title The counter value for UserInfo is leaking WIP: The counter value for UserInfo is leaking Mar 3, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels Mar 3, 2025
@github-actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 09:02:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for da0d4cf has started.
⚪ 2025-03-03 09:02:39 UTC Artifacts will be uploaded here
⚪ 2025-03-03 09:05:34 UTC ya make is running...
🟡 2025-03-03 09:54:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19165 17793 0 1 1231 140

⚪ 2025-03-03 09:56:36 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-03 10:09:28 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
223 (only retried tests) 95 0 0 0 128

🟢 2025-03-03 10:09:35 UTC Build successful.
🟢 2025-03-03 10:09:53 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: b0bd8f9 merge: da0d4cf diff diff %
ydbd size 2 288 336 672 Bytes 2 288 336 672 Bytes 0 Bytes 0.000%
ydbd stripped size 479 642 688 Bytes 479 642 688 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 09:02:40 UTC Pre-commit check linux-x86_64-release-asan for da0d4cf has started.
⚪ 2025-03-03 09:02:55 UTC Artifacts will be uploaded here
⚪ 2025-03-03 09:05:53 UTC ya make is running...
🟡 2025-03-03 10:16:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11686 11448 0 148 53 37

⚪ 2025-03-03 10:17:38 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-03 10:34:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
327 (only retried tests) 292 0 2 0 33

⚪ 2025-03-03 10:34:47 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-03 10:49:25 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
62 (only retried tests) 32 0 0 2 28

🟢 2025-03-03 10:49:33 UTC Build successful.
🟢 2025-03-03 10:50:02 UTC ydbd size 3.7 GiB changed* by -64 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: b0bd8f9 merge: da0d4cf diff diff %
ydbd size 3 988 298 944 Bytes 3 988 298 880 Bytes -64 Bytes -0.000%
ydbd stripped size 1 388 482 184 Bytes 1 388 482 120 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 11:54:38 UTC Pre-commit check linux-x86_64-release-asan for 0eed856 has started.
⚪ 2025-03-03 11:54:42 UTC Artifacts will be uploaded here
⚪ 2025-03-03 11:57:26 UTC ya make is running...
⚫ 2025-03-03 12:16:42 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 11:56:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0eed856 has started.
⚪ 2025-03-03 11:56:59 UTC Artifacts will be uploaded here
⚪ 2025-03-03 11:59:50 UTC ya make is running...
⚫ 2025-03-03 12:16:39 UTC Check cancelled

@Alek5andr-Kotov Alek5andr-Kotov changed the title WIP: The counter value for UserInfo is leaking The counter value for UserInfo is leaking Mar 3, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels Mar 3, 2025
@github-actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 12:18:05 UTC Pre-commit check linux-x86_64-release-asan for f26c50b has started.
⚪ 2025-03-03 12:18:10 UTC Artifacts will be uploaded here
⚪ 2025-03-03 12:21:31 UTC ya make is running...
🟡 2025-03-03 13:27:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11691 11375 0 256 22 38

⚪ 2025-03-03 13:28:04 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-03 13:42:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
376 (only retried tests) 302 0 41 1 32

⚪ 2025-03-03 13:42:53 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-03 13:55:17 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
110 (only retried tests) 78 0 0 0 32

🟢 2025-03-03 13:55:26 UTC Build successful.
🟢 2025-03-03 13:55:54 UTC ydbd size 3.7 GiB changed* by -64 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 1f60fc8 merge: f26c50b diff diff %
ydbd size 3 988 495 648 Bytes 3 988 495 584 Bytes -64 Bytes -0.000%
ydbd stripped size 1 388 506 888 Bytes 1 388 506 824 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 12:18:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for f26c50b has started.
⚪ 2025-03-03 12:18:27 UTC Artifacts will be uploaded here
⚪ 2025-03-03 12:21:14 UTC ya make is running...
🟡 2025-03-03 13:12:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19170 17814 0 3 1217 136

⚪ 2025-03-03 13:13:52 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-03 13:26:21 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
204 (only retried tests) 78 0 0 0 126

🟢 2025-03-03 13:26:27 UTC Build successful.
🟢 2025-03-03 13:26:45 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 1f60fc8 merge: f26c50b diff diff %
ydbd size 2 288 460 760 Bytes 2 288 460 760 Bytes 0 Bytes 0.000%
ydbd stripped size 479 649 216 Bytes 479 649 216 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov Alek5andr-Kotov enabled auto-merge (squash) March 3, 2025 14:13
@Alek5andr-Kotov Alek5andr-Kotov merged commit 7fe0768 into ydb-platform:main Mar 3, 2025
13 of 14 checks passed
@naspirato naspirato mentioned this pull request Mar 4, 2025
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 4, 2025
Closed
FloatingCrowbar pushed a commit to FloatingCrowbar/ydb that referenced this pull request Mar 7, 2025
@Alek5andr-Kotov @FloatingCrowbar
The counter value for UserInfo is leaking (ydb-platform#15233)
bff7702
FloatingCrowbar pushed a commit to FloatingCrowbar/ydb that referenced this pull request Mar 7, 2025
@Alek5andr-Kotov @FloatingCrowbar
The counter value for UserInfo is leaking (ydb-platform#15233)
cf359ac
@FloatingCrowbar FloatingCrowbar mentioned this pull request Mar 7, 2025
Merged
FloatingCrowbar pushed a commit to FloatingCrowbar/ydb that referenced this pull request Mar 7, 2025
@Alek5andr-Kotov @FloatingCrowbar
The counter value for UserInfo is leaking (ydb-platform#15233)
cdf2f80
This was referenced Mar 7, 2025
Merged
Merged
FloatingCrowbar pushed a commit to FloatingCrowbar/ydb that referenced this pull request Mar 10, 2025
@Alek5andr-Kotov @FloatingCrowbar
The counter value for UserInfo is leaking (ydb-platform#15233)
067c5a2
@FloatingCrowbar FloatingCrowbar mentioned this pull request Mar 10, 2025
Merged
This was referenced Mar 10, 2025
Merged
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@Alek5andr-Kotov @blinkov
The counter value for UserInfo is leaking (#15233)
513893e
@liruoko liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexnick88 alexnick88 alexnick88 approved these changes

@qyryq qyryq Awaiting requested review from qyryq qyryq is a code owner automatically assigned from ydb-platform/topics

Assignees

No one assigned

Labels

bugfix changelog/f25-3 PR участвует в списке изменений

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Alek5andr-Kotov @alexnick88 @liruoko