Skip to content

Move TTargetTransfer to target_transfer.h #15269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nshestakov merged 5 commits into from
Mar 4, 2025
Merged

Move TTargetTransfer to target_transfer.h #15269

nshestakov merged 5 commits into from
Mar 4, 2025

Conversation

@nshestakov
Copy link
Collaborator

@nshestakov nshestakov commented Mar 3, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@nshestakov nshestakov requested a review from a team as a code owner March 3, 2025 17:29
@nshestakov nshestakov requested a review from pixcc March 3, 2025 17:29
@github-actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

🟢 2025-03-03 17:36:53 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 17:30:57 UTC Pre-commit check linux-x86_64-release-asan for 1ac5367 has started.
⚪ 2025-03-03 17:31:13 UTC Artifacts will be uploaded here
⚫ 2025-03-03 17:32:10 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 17:31:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1ac5367 has started.
⚪ 2025-03-03 17:31:17 UTC Artifacts will be uploaded here
⚫ 2025-03-03 17:32:10 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 17:33:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for 321d206 has started.
⚪ 2025-03-03 17:33:34 UTC Artifacts will be uploaded here
⚪ 2025-03-03 17:36:26 UTC ya make is running...
🟡 2025-03-03 18:28:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19168 17809 0 1 1220 138

⚪ 2025-03-03 18:31:04 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-03 18:46:09 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
210 (only retried tests) 81 0 0 0 129

🟢 2025-03-03 18:46:19 UTC Build successful.
🟢 2025-03-03 18:46:39 UTC ydbd size 2.1 GiB changed* by +26.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 55bb8ab merge: 321d206 diff diff %
ydbd size 2 288 962 280 Bytes 2 288 989 552 Bytes +26.6 KiB +0.001%
ydbd stripped size 479 716 288 Bytes 479 715 840 Bytes -448 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov requested review from CyberROFL and removed request for pixcc March 3, 2025 17:35
@nshestakov nshestakov changed the title Extract TTargetTransfer to target_transfer.h Move TTargetTransfer to target_transfer.h Mar 3, 2025
@github-actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 17:36:11 UTC Pre-commit check linux-x86_64-release-asan for 321d206 has started.
⚪ 2025-03-03 17:36:26 UTC Artifacts will be uploaded here
⚪ 2025-03-03 17:39:19 UTC ya make is running...
🟡 2025-03-03 18:50:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11689 11447 0 175 29 38

⚪ 2025-03-03 18:52:14 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-03 19:09:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
307 (only retried tests) 262 0 6 7 32

⚪ 2025-03-03 19:09:25 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-03 19:21:18 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74 (only retried tests) 43 0 0 0 31

🟢 2025-03-03 19:21:24 UTC Build successful.
🟢 2025-03-03 19:21:53 UTC ydbd size 3.7 GiB changed* by +35.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d35b323 merge: 321d206 diff diff %
ydbd size 3 989 364 912 Bytes 3 989 401 592 Bytes +35.8 KiB +0.001%
ydbd stripped size 1 388 709 288 Bytes 1 388 709 000 Bytes -288 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited
Loading

⚪ 2025-03-04 06:32:19 UTC Pre-commit check linux-x86_64-release-asan for 354d7dd has started.
⚪ 2025-03-04 06:32:34 UTC Artifacts will be uploaded here
⚪ 2025-03-04 06:35:26 UTC ya make is running...
🟡 2025-03-04 07:47:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11689 11415 0 204 33 37

⚪ 2025-03-04 07:48:37 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-04 08:04:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
341 (only retried tests) 294 0 13 3 31

⚪ 2025-03-04 08:04:38 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-04 08:16:51 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
81 (only retried tests) 52 0 0 0 29

🟢 2025-03-04 08:17:00 UTC Build successful.
🟢 2025-03-04 08:17:35 UTC ydbd size 3.7 GiB changed* by +31.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3a5cfed merge: 354d7dd diff diff %
ydbd size 3 989 522 472 Bytes 3 989 554 984 Bytes +31.8 KiB +0.001%
ydbd stripped size 1 388 750 408 Bytes 1 388 745 960 Bytes -4.3 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited
Loading

⚪ 2025-03-04 06:32:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for 354d7dd has started.
⚪ 2025-03-04 06:32:58 UTC Artifacts will be uploaded here
⚪ 2025-03-04 06:36:02 UTC ya make is running...
🟡 2025-03-04 07:28:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19169 17804 0 7 1218 140

⚪ 2025-03-04 07:30:42 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-04 07:44:14 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
220 (only retried tests) 95 0 0 0 125

🟢 2025-03-04 07:44:23 UTC Build successful.
🟢 2025-03-04 07:44:47 UTC ydbd size 2.1 GiB changed* by +26.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3a5cfed merge: 354d7dd diff diff %
ydbd size 2 289 031 112 Bytes 2 289 058 480 Bytes +26.7 KiB +0.001%
ydbd stripped size 479 730 560 Bytes 479 730 112 Bytes -448 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

CyberROFL
CyberROFL reviewed Mar 4, 2025
View reviewed changes
@nshestakov @CyberROFL
Apply suggestions from code review
9f681db 
Co-authored-by: Ilnaz Nizametdinov <i.nizametdinov@gmail.com>
@github-actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited
Loading

⚪ 2025-03-04 11:37:25 UTC Pre-commit check linux-x86_64-release-asan for 52f49fe has started.
⚪ 2025-03-04 11:38:02 UTC Artifacts will be uploaded here
⚪ 2025-03-04 11:41:27 UTC ya make is running...
🟡 2025-03-04 12:46:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11694 11518 0 109 30 37

⚪ 2025-03-04 12:47:50 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-04 13:04:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
236 (only retried tests) 195 0 4 4 33

⚪ 2025-03-04 13:04:49 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-04 13:16:55 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74 (only retried tests) 39 0 0 4 31

🟢 2025-03-04 13:17:04 UTC Build successful.
🟡 2025-03-04 13:17:37 UTC ydbd size 3.7 GiB changed* by +230.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 18f45b9 merge: 52f49fe diff diff %
ydbd size 3 989 555 664 Bytes 3 989 791 232 Bytes +230.0 KiB +0.006%
ydbd stripped size 1 388 759 272 Bytes 1 388 812 168 Bytes +51.7 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited
Loading

⚪ 2025-03-04 11:37:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 52f49fe has started.
⚪ 2025-03-04 11:38:16 UTC Artifacts will be uploaded here
⚪ 2025-03-04 11:42:02 UTC ya make is running...
🟡 2025-03-04 12:39:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19169 17807 0 5 1220 137

⚪ 2025-03-04 12:42:15 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-04 12:58:01 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
218 (only retried tests) 89 0 0 0 129

🟢 2025-03-04 12:58:11 UTC Build successful.
🟡 2025-03-04 12:58:34 UTC ydbd size 2.1 GiB changed* by +143.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 18f45b9 merge: 52f49fe diff diff %
ydbd size 2 289 055 368 Bytes 2 289 202 360 Bytes +143.5 KiB +0.006%
ydbd stripped size 479 733 888 Bytes 479 753 408 Bytes +19.1 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov requested a review from CyberROFL March 4, 2025 11:38
@ydb-platform ydb-platform deleted a comment from nshestakov Mar 4, 2025
@ydb-platform ydb-platform deleted a comment from nshestakov Mar 4, 2025
@nshestakov nshestakov enabled auto-merge (squash) March 4, 2025 11:41
@nshestakov nshestakov merged commit 29d6dd3 into ydb-platform:main Mar 4, 2025
12 checks passed
@nshestakov nshestakov deleted the TR-refactoring branch March 4, 2025 13:19
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 4, 2025
Closed
This was referenced Mar 10, 2025
Merged
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@nshestakov @CyberROFL @blinkov
Move TTargetTransfer to target_transfer.h (#15269)
b03656c 
Co-authored-by: Ilnaz Nizametdinov <i.nizametdinov@gmail.com>
nshestakov added a commit to nshestakov/ydb that referenced this pull request May 5, 2025
@nshestakov @CyberROFL
Move TTargetTransfer to target_transfer.h (ydb-platform#15269)
7dbeb8a 
Co-authored-by: Ilnaz Nizametdinov <i.nizametdinov@gmail.com>
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyberROFL CyberROFL CyberROFL approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nshestakov @CyberROFL