Skip to content

Conversation

@FloatingCrowbar
Copy link
Collaborator

Changelog entry

Fix SeqNo conflict for concurrent transactions using same SourceId

Changelog category

  • Bugfix

Description for reviewers

Fix possible conflict of several concurrent transactions using same SourceId and conflicting SeqNo ranges

@FloatingCrowbar FloatingCrowbar requested a review from a team as a code owner March 4, 2025 09:16
@github-actions github-actions bot added the bugfix label Mar 4, 2025
@github-actions
Copy link

github-actions bot commented Mar 4, 2025

🔴 2025-03-04 09:18:10 UTC The validation of the Pull Request description has failed. Please update the description.

Bugfix requires a linked issue in the changelog entry

@github-actions
Copy link

github-actions bot commented Mar 4, 2025

2025-03-04 09:19:06 UTC Pre-commit check linux-x86_64-release-asan for c903a7b has started.
2025-03-04 09:19:42 UTC Artifacts will be uploaded here
2025-03-04 09:23:27 UTC ya make is running...
2025-03-04 09:38:40 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 4, 2025

2025-03-04 09:19:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for c903a7b has started.
2025-03-04 09:20:11 UTC Artifacts will be uploaded here
2025-03-04 09:23:35 UTC ya make is running...
2025-03-04 09:39:06 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 4, 2025

2025-03-04 09:40:04 UTC Pre-commit check linux-x86_64-release-asan for b9388b9 has started.
2025-03-04 09:40:34 UTC Artifacts will be uploaded here
2025-03-04 09:43:59 UTC ya make is running...
🟡 2025-03-04 10:50:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11693 11521 0 119 16 37

2025-03-04 10:51:34 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-04 11:11:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
233 (only retried tests) 191 0 9 1 32

2025-03-04 11:11:39 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-04 11:24:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74 (only retried tests) 42 0 1 0 31

🟢 2025-03-04 11:24:36 UTC Build successful.
🟢 2025-03-04 11:25:09 UTC ydbd size 3.7 GiB changed* by +40.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 16444c9 merge: b9388b9 diff diff %
ydbd size 3 989 529 416 Bytes 3 989 570 752 Bytes +40.4 KiB +0.001%
ydbd stripped size 1 388 748 488 Bytes 1 388 757 896 Bytes +9.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 4, 2025

2025-03-04 09:40:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for b9388b9 has started.

@FloatingCrowbar FloatingCrowbar force-pushed the tx-fix branch 2 times, most recently from ddcc607 to d7364ce Compare March 6, 2025 14:08
@github-actions
Copy link

github-actions bot commented Mar 6, 2025

2025-03-06 14:12:23 UTC Pre-commit check linux-x86_64-release-asan for 942536b has started.
2025-03-06 14:12:27 UTC Artifacts will be uploaded here
2025-03-06 14:15:20 UTC ya make is running...
🟡 2025-03-06 15:23:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11750 11570 0 109 37 34

2025-03-06 15:24:33 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-06 15:40:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
253 (only retried tests) 215 0 4 1 33

2025-03-06 15:40:58 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-06 15:54:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68 (only retried tests) 37 0 1 0 30

🟢 2025-03-06 15:54:21 UTC Build successful.
🟢 2025-03-06 15:54:54 UTC ydbd size 3.7 GiB changed* by +19.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9187047 merge: 942536b diff diff %
ydbd size 3 995 105 248 Bytes 3 995 124 864 Bytes +19.2 KiB +0.000%
ydbd stripped size 1 389 063 240 Bytes 1 389 065 928 Bytes +2.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 6, 2025

2025-03-06 14:12:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for 942536b has started.
2025-03-06 14:13:29 UTC Artifacts will be uploaded here
2025-03-06 14:16:48 UTC ya make is running...
🟡 2025-03-06 15:04:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19214 17874 0 3 1217 120

2025-03-06 15:06:15 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-06 15:19:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
172 (only retried tests) 63 0 1 0 108

2025-03-06 15:19:27 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-06 15:32:49 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
152 (only retried tests) 47 0 1 0 104

🟢 2025-03-06 15:32:59 UTC Build successful.
🟢 2025-03-06 15:33:22 UTC ydbd size 2.1 GiB changed* by +19.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6fe3b58 merge: 942536b diff diff %
ydbd size 2 293 953 600 Bytes 2 293 973 832 Bytes +19.8 KiB +0.001%
ydbd stripped size 480 565 504 Bytes 480 570 880 Bytes +5.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 6, 2025

2025-03-06 21:39:31 UTC Pre-commit check linux-x86_64-release-asan for 862ef65 has started.
2025-03-06 21:39:45 UTC Artifacts will be uploaded here
2025-03-06 21:42:35 UTC ya make is running...
🟡 2025-03-06 22:54:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11756 11612 0 90 18 36

2025-03-06 22:55:03 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-06 23:09:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
203 (only retried tests) 163 0 6 2 32

2025-03-06 23:09:31 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-06 23:28:11 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
69 (only retried tests) 37 0 0 2 30

🟢 2025-03-06 23:28:18 UTC Build successful.
🟢 2025-03-06 23:28:47 UTC ydbd size 3.7 GiB changed* by +20.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 98be31c merge: 862ef65 diff diff %
ydbd size 3 994 125 872 Bytes 3 994 146 560 Bytes +20.2 KiB +0.001%
ydbd stripped size 1 388 741 992 Bytes 1 388 745 384 Bytes +3.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 6, 2025

2025-03-06 21:40:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for 862ef65 has started.
2025-03-06 21:40:08 UTC Artifacts will be uploaded here
2025-03-06 21:42:49 UTC ya make is running...
🟢 2025-03-06 22:29:10 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19220 17889 0 0 1217 114

🟢 2025-03-06 22:30:40 UTC Build successful.
🟢 2025-03-06 22:30:57 UTC ydbd size 2.1 GiB changed* by +7.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 98be31c merge: 862ef65 diff diff %
ydbd size 2 293 348 056 Bytes 2 293 355 944 Bytes +7.7 KiB +0.000%
ydbd stripped size 480 451 520 Bytes 480 452 928 Bytes +1.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 7, 2025

2025-03-07 12:01:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for ad21717 has started.
2025-03-07 12:02:03 UTC Artifacts will be uploaded here
2025-03-07 12:05:22 UTC ya make is running...
🟡 2025-03-07 12:56:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19222 17848 0 8 1246 120

2025-03-07 12:58:34 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-07 13:11:01 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
207 (only retried tests) 99 0 0 0 108

🟢 2025-03-07 13:11:11 UTC Build successful.
🟢 2025-03-07 13:11:38 UTC ydbd size 2.1 GiB changed* by +6.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 301cd78 merge: ad21717 diff diff %
ydbd size 2 293 646 360 Bytes 2 293 653 128 Bytes +6.6 KiB +0.000%
ydbd stripped size 480 484 640 Bytes 480 485 664 Bytes +1.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 7, 2025

2025-03-07 12:03:00 UTC Pre-commit check linux-x86_64-release-asan for ad21717 has started.
2025-03-07 12:05:15 UTC Artifacts will be uploaded here
2025-03-07 12:08:08 UTC ya make is running...
🟡 2025-03-07 13:17:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11758 11575 0 114 35 34

2025-03-07 13:19:02 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-07 13:37:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
261 (only retried tests) 218 0 8 5 30

2025-03-07 13:37:54 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-07 13:50:22 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
69 (only retried tests) 39 0 0 1 29

🟢 2025-03-07 13:50:35 UTC Build successful.
🟢 2025-03-07 13:51:09 UTC ydbd size 3.7 GiB changed* by +16.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 301cd78 merge: ad21717 diff diff %
ydbd size 3 994 599 656 Bytes 3 994 616 504 Bytes +16.5 KiB +0.000%
ydbd stripped size 1 388 829 736 Bytes 1 388 832 360 Bytes +2.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Alek5andr-Kotov
Alek5andr-Kotov previously approved these changes Mar 7, 2025
alexnick88
alexnick88 previously approved these changes Mar 10, 2025
@alexnick88 alexnick88 self-requested a review March 10, 2025 07:16
@github-actions
Copy link

github-actions bot commented Mar 20, 2025

2025-03-20 13:05:08 UTC Pre-commit check linux-x86_64-release-asan for a42cc3b has started.
2025-03-20 13:05:13 UTC Artifacts will be uploaded here
2025-03-20 13:08:09 UTC ya make is running...
2025-03-20 13:37:02 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 20, 2025

2025-03-20 13:06:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for a42cc3b has started.
2025-03-20 13:06:51 UTC Artifacts will be uploaded here
2025-03-20 13:10:12 UTC ya make is running...
2025-03-20 13:37:01 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 20, 2025

2025-03-20 13:56:44 UTC Pre-commit check linux-x86_64-release-asan for 8af7a4c has started.
2025-03-20 13:57:41 UTC Artifacts will be uploaded here
2025-03-20 14:01:08 UTC ya make is running...
🟡 2025-03-20 15:14:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12124 12017 0 62 8 37

2025-03-20 15:15:27 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-20 15:28:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
154 (only retried tests) 113 0 2 5 34

2025-03-20 15:28:21 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-20 15:41:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
69 (only retried tests) 32 0 1 3 33

🟢 2025-03-20 15:41:28 UTC Build successful.
🟢 2025-03-20 15:41:58 UTC ydbd size 3.8 GiB changed* by +16.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 00995cf merge: 8af7a4c diff diff %
ydbd size 4 071 958 816 Bytes 4 071 976 120 Bytes +16.9 KiB +0.000%
ydbd stripped size 1 408 718 408 Bytes 1 408 721 256 Bytes +2.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 20, 2025

2025-03-20 15:59:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8af7a4c has started.
2025-03-20 15:59:56 UTC Artifacts will be uploaded here
2025-03-20 16:02:41 UTC ya make is running...
🟡 2025-03-20 16:51:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19627 18251 0 4 1258 114

2025-03-20 16:53:32 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-20 17:06:22 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
191 (only retried tests) 82 0 0 2 107

🟢 2025-03-20 17:06:32 UTC Build successful.
🟢 2025-03-20 17:06:54 UTC ydbd size 2.2 GiB changed* by +6.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 00995cf merge: 8af7a4c diff diff %
ydbd size 2 313 317 144 Bytes 2 313 324 224 Bytes +6.9 KiB +0.000%
ydbd stripped size 484 266 592 Bytes 484 267 744 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 26, 2025

2025-03-26 21:44:48 UTC Pre-commit check linux-x86_64-release-asan for 25395f2 has started.
2025-03-26 21:45:03 UTC Artifacts will be uploaded here
2025-03-26 21:47:48 UTC ya make is running...
🟡 2025-03-26 23:00:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12184 12110 0 31 9 34

2025-03-26 23:02:00 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-26 23:14:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
115 (only retried tests) 76 0 5 3 31

2025-03-26 23:14:18 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-26 23:26:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
63 (only retried tests) 28 0 4 2 29

🟢 2025-03-26 23:26:14 UTC Build successful.
🟢 2025-03-26 23:26:44 UTC ydbd size 3.8 GiB changed* by +17.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8a9a129 merge: 25395f2 diff diff %
ydbd size 4 111 912 472 Bytes 4 111 930 040 Bytes +17.2 KiB +0.000%
ydbd stripped size 1 420 949 096 Bytes 1 420 952 008 Bytes +2.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 26, 2025

2025-03-26 21:44:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 25395f2 has started.
2025-03-26 21:45:04 UTC Artifacts will be uploaded here
2025-03-26 21:47:56 UTC ya make is running...
🟡 2025-03-26 22:49:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19717 18355 0 3 1247 112

2025-03-26 22:50:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-26 23:02:28 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
167 (only retried tests) 63 0 0 0 104

🟢 2025-03-26 23:02:35 UTC Build successful.
🟢 2025-03-26 23:02:55 UTC ydbd size 2.2 GiB changed* by +6.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8a9a129 merge: 25395f2 diff diff %
ydbd size 2 343 286 784 Bytes 2 343 293 768 Bytes +6.8 KiB +0.000%
ydbd stripped size 490 037 088 Bytes 490 038 176 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@FloatingCrowbar FloatingCrowbar merged commit 4c8dfa6 into ydb-platform:main Mar 27, 2025
12 checks passed
FloatingCrowbar added a commit to FloatingCrowbar/ydb that referenced this pull request Apr 7, 2025
FloatingCrowbar added a commit to FloatingCrowbar/ydb that referenced this pull request Apr 7, 2025
FloatingCrowbar added a commit to FloatingCrowbar/ydb that referenced this pull request Apr 7, 2025
FloatingCrowbar added a commit to FloatingCrowbar/ydb that referenced this pull request Apr 7, 2025
@liruoko liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix changelog/f25-3 PR участвует в списке изменений

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants