Skip to content

Conversation

@adameat
Copy link
Member

@adameat adameat commented Mar 5, 2025

Changelog entry

fix for unstable version grouping, closes #14827

Changelog category

  • Bugfix

Description for reviewers

add subdomain key to all non-datrequired fiels for non-database requests
it forces offload merge to correctly distribute requests across database nodes
add ability to specify offload merge batch size and dump merge batches in output for debugging

@adameat adameat requested a review from a team as a code owner March 5, 2025 05:18
@github-actions github-actions bot added the bugfix label Mar 5, 2025
@github-actions
Copy link

github-actions bot commented Mar 5, 2025

🟢 2025-03-05 05:28:23 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Mar 5, 2025

2025-03-05 05:20:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for ec40281 has started.
2025-03-05 05:21:10 UTC Artifacts will be uploaded here
2025-03-05 05:24:05 UTC ya make is running...
🟡 2025-03-05 06:49:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27830 25231 0 14 2465 120

2025-03-05 06:52:11 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-05 07:05:02 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
183 (only retried tests) 76 0 0 0 107

🟢 2025-03-05 07:05:12 UTC Build successful.
🟢 2025-03-05 07:05:34 UTC ydbd size 2.1 GiB changed* by +44.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b0f9318 merge: ec40281 diff diff %
ydbd size 2 290 087 392 Bytes 2 290 132 680 Bytes +44.2 KiB +0.002%
ydbd stripped size 479 952 320 Bytes 479 960 608 Bytes +8.1 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 5, 2025

2025-03-05 05:22:01 UTC Pre-commit check linux-x86_64-release-asan for ec40281 has started.
2025-03-05 05:22:17 UTC Artifacts will be uploaded here
2025-03-05 05:25:09 UTC ya make is running...
🟡 2025-03-05 06:59:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13466 13329 0 84 15 38

2025-03-05 07:01:01 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-05 07:15:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
185 (only retried tests) 150 0 2 1 32

2025-03-05 07:16:07 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-05 07:28:39 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
62 (only retried tests) 31 0 0 0 31

🟢 2025-03-05 07:59:10 UTC Build successful.
🟢 2025-03-05 07:59:37 UTC ydbd size 3.7 GiB changed* by +71.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b0f9318 merge: ec40281 diff diff %
ydbd size 3 990 870 208 Bytes 3 990 943 168 Bytes +71.2 KiB +0.002%
ydbd stripped size 1 388 995 016 Bytes 1 389 024 744 Bytes +29.0 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat changed the title add subdomain key to all non-datrequired fiels for non-database requests add subdomain key to all required fiels for non-database requests Mar 5, 2025
@adameat adameat changed the title add subdomain key to all required fiels for non-database requests add subdomain key to required fiels for non-database requests Mar 5, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels Mar 5, 2025
@adameat adameat enabled auto-merge (squash) March 5, 2025 09:23
@adameat adameat merged commit 5d6cf52 into ydb-platform:main Mar 5, 2025
17 of 18 checks passed
@adameat adameat deleted the fix-unstable-versions branch March 6, 2025 08:59
@liruoko liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix changelog/f25-3 PR участвует в списке изменений

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unstable version numbers in /viewer/nodes handler

3 participants