Skip to content

Conversation

@ijon
Copy link
Collaborator

@ijon ijon commented Mar 6, 2025

Merge from main:

Fix database selection logic in query service for user/group administration (AlterLogin) operations (in regards to domain_login_only mode).

ijon added 2 commits March 6, 2025 13:09
…b-platform#15380)

Fix database selection in kqp_scheme_executor for AlterLogin operations when domain_login_only=false.
…db-platform#15385)

Unify database selection logic for AlterLogin scheme operations into the single helper method. Remove the possibility to make bugs caused by code repetition on more than one code paths.
@ijon ijon requested a review from a team as a code owner March 6, 2025 11:55
@github-actions
Copy link

github-actions bot commented Mar 6, 2025

2025-03-06 12:00:46 UTC Pre-commit check linux-x86_64-release-asan for a45a235 has started.
2025-03-06 12:01:01 UTC Artifacts will be uploaded here
2025-03-06 12:04:06 UTC ya make is running...
🟡 2025-03-06 13:22:22 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12203 12073 0 77 14 39

2025-03-06 13:23:29 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-06 13:45:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
182 (only retried tests) 140 0 1 6 35

2025-03-06 13:45:32 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-06 14:05:45 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68 (only retried tests) 32 0 0 2 34

🟢 2025-03-06 14:05:58 UTC Build successful.
🟢 2025-03-06 14:06:31 UTC ydbd size 3.6 GiB changed* by -10.8 KiB, which is <= 0 Bytes vs stable-25-1: OK

ydbd size dash stable-25-1: 9e31b30 merge: a45a235 diff diff %
ydbd size 3 899 875 536 Bytes 3 899 864 480 Bytes -10.8 KiB -0.000%
ydbd stripped size 1 364 983 920 Bytes 1 364 981 904 Bytes -2.0 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 6, 2025

2025-03-06 12:00:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for a45a235 has started.
2025-03-06 12:01:01 UTC Artifacts will be uploaded here
2025-03-06 12:04:10 UTC ya make is running...
🟡 2025-03-06 13:17:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26410 23801 0 6 2466 137

2025-03-06 13:20:13 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-06 13:41:59 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
220 (only retried tests) 90 0 0 0 130

🟢 2025-03-06 13:42:09 UTC Build successful.
🟢 2025-03-06 13:42:28 UTC ydbd size 2.1 GiB changed* by -360 Bytes, which is <= 0 Bytes vs stable-25-1: OK

ydbd size dash stable-25-1: 9e31b30 merge: a45a235 diff diff %
ydbd size 2 241 935 856 Bytes 2 241 935 496 Bytes -360 Bytes -0.000%
ydbd stripped size 474 840 632 Bytes 474 843 064 Bytes +2.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ijon ijon merged commit f14b341 into ydb-platform:stable-25-1 Mar 6, 2025
12 checks passed
@ijon ijon deleted the merge/25-1/kqp-fix-and-unify-database-selection-for-alter-logins branch March 6, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants