Skip to content

Conversation

@vporyadke
Copy link
Collaborator

Changelog entry

fix a bug where a tablet would remain inactive after failing during promotion from follower to leader #14961

Changelog category

  • Not for Changelog

Description for reviewers

I think I'm supposed to file this as not for changelog if I'm backporting to 2 stable branches at the same time?

@vporyadke vporyadke requested a review from a team as a code owner March 6, 2025 22:01
@github-actions
Copy link

github-actions bot commented Mar 6, 2025

2025-03-06 22:04:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for b3af63c has started.
2025-03-06 22:05:01 UTC Artifacts will be uploaded here
2025-03-06 22:07:59 UTC ya make is running...
🟡 2025-03-06 23:12:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19136 17761 0 5 1230 140

2025-03-06 23:13:52 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-06 23:35:17 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
229 (only retried tests) 91 0 0 6 132

🟢 2025-03-06 23:35:24 UTC Build successful.
🟢 2025-03-06 23:35:42 UTC ydbd size 2.1 GiB changed* by +1.7 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: f14b341 merge: b3af63c diff diff %
ydbd size 2 242 092 360 Bytes 2 242 094 104 Bytes +1.7 KiB +0.000%
ydbd stripped size 474 854 840 Bytes 474 855 288 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 6, 2025

2025-03-06 22:05:21 UTC Pre-commit check linux-x86_64-release-asan for b3af63c has started.
2025-03-06 22:05:35 UTC Artifacts will be uploaded here
2025-03-06 22:08:32 UTC ya make is running...
🟡 2025-03-06 23:19:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11807 11693 0 69 5 40

2025-03-06 23:20:38 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-06 23:41:27 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
165 (only retried tests) 129 0 0 0 36

🟢 2025-03-06 23:41:36 UTC Build successful.
🟢 2025-03-06 23:42:01 UTC ydbd size 3.6 GiB changed* by +3.2 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: f14b341 merge: b3af63c diff diff %
ydbd size 3 900 131 856 Bytes 3 900 135 104 Bytes +3.2 KiB +0.000%
ydbd stripped size 1 365 034 640 Bytes 1 365 035 984 Bytes +1.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vporyadke vporyadke requested a review from CyberROFL March 7, 2025 09:54
@CyberROFL CyberROFL changed the title handle follower dying while being promoted to leader (#15134) 25-1: handle follower dying while being promoted to leader (#15134) Mar 7, 2025
@CyberROFL CyberROFL changed the title 25-1: handle follower dying while being promoted to leader (#15134) 25-1: handle follower dying while being promoted to leader Mar 7, 2025
@vporyadke vporyadke merged commit 207f337 into ydb-platform:stable-25-1 Mar 14, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants