Skip to content

Conversation

@naspirato
Copy link
Collaborator

@naspirato naspirato commented Mar 9, 2025

Changelog entry

To fix perfomance regression in stable-25-1
#15185 (comment)

Result in stable-25-1-1

cluster_monitoring branch timestamp git_commit_timestamp git_sha tpmC newOrderLatency90 efficiency
monium stable-25-1 06.03.2025 21:24:52 06.03.2025 14:59:34 3381008 🔴 203494 🔴 508 98.9

Result in revert

cluster_monitoring repository git_branch run_type run_start_datetime git_sha git_commit_timestamp duration sec warehouses tpmC efficiency newOrder90p
monium ydb-platform/ydb origin/main 25_1_1_and_main_revert_14843 10.03.2025 01:49:44 c2a927f 09.03.2025 12:59:34 7200 16000 🟢 205038 99.65 🟢 100

Revert "Make DEFAULT_EVENTS_PER_MAILBOX unreachable (#14843)

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@github-actions
Copy link

github-actions bot commented Mar 9, 2025

2025-03-09 13:04:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for de45cc2 has started.
2025-03-09 13:04:44 UTC Artifacts will be uploaded here
2025-03-09 13:08:08 UTC ya make is running...
🟡 2025-03-09 15:00:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28400 25777 0 8 2474 141

2025-03-09 15:03:00 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-09 15:24:01 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
240 (only retried tests) 106 0 0 3 131

🟢 2025-03-09 15:24:08 UTC Build successful.
🟢 2025-03-09 15:24:29 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs stable-25-1-1: OK

ydbd size dash stable-25-1-1: 9a14792 merge: de45cc2 diff diff %
ydbd size 2 242 092 472 Bytes 2 242 092 472 Bytes 0 Bytes 0.000%
ydbd stripped size 474 852 344 Bytes 474 852 344 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 9, 2025

2025-03-09 13:04:31 UTC Pre-commit check linux-x86_64-release-asan for de45cc2 has started.
2025-03-09 13:04:46 UTC Artifacts will be uploaded here
2025-03-09 13:07:58 UTC ya make is running...
🟡 2025-03-09 14:54:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14079 13988 0 27 24 40

2025-03-09 14:55:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-09 15:15:56 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
136 (only retried tests) 96 0 0 4 36

🟢 2025-03-09 15:16:03 UTC Build successful.
🟢 2025-03-09 15:16:30 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs stable-25-1-1: OK

ydbd size dash stable-25-1-1: 9a14792 merge: de45cc2 diff diff %
ydbd size 3 900 142 336 Bytes 3 900 142 240 Bytes -96 Bytes -0.000%
ydbd stripped size 1 365 036 336 Bytes 1 365 036 272 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@naspirato naspirato marked this pull request as ready for review March 10, 2025 09:23
@naspirato naspirato requested a review from a team as a code owner March 10, 2025 09:23
@naspirato naspirato enabled auto-merge (squash) March 10, 2025 09:23
@naspirato naspirato changed the title Revert "Make DEFAULT_EVENTS_PER_MAILBOX unreachable (#14843)" Revert "Make DEFAULT_EVENTS_PER_MAILBOX unreachable (#14843)" to stable 25-1-1 Mar 10, 2025
@naspirato naspirato merged commit 7231c7c into stable-25-1-1 Mar 10, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants