Skip to content

Conversation

@kruall
Copy link
Collaborator

@kruall kruall commented Mar 12, 2025

Changelog entry

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

change in bench with regular activation queue
https://gist.github.com/kruall/04e41a6feacc1ab338601a7567cb77e8
change in bench with ring activation queue
https://gist.github.com/kruall/74fe398e19ce4f12b8bcdf051d29ee9c

@kruall kruall added the area/actorsystem Actor System related issues label Mar 12, 2025
@kruall kruall requested a review from alexvru March 12, 2025 06:10
@kruall kruall self-assigned this Mar 12, 2025
@github-actions
Copy link

github-actions bot commented Mar 12, 2025

🟢 2025-03-12 06:30:10 UTC The validation of the Pull Request description is successful.

@kruall kruall changed the title Improve perfomance of ring queue in actorsystem Improve perfomance of actorsystem Mar 12, 2025
@github-actions
Copy link

github-actions bot commented Mar 12, 2025

2025-03-12 06:14:25 UTC Pre-commit check linux-x86_64-release-asan for 831f084 has started.
2025-03-12 06:14:39 UTC Artifacts will be uploaded here
2025-03-12 06:17:35 UTC ya make is running...
2025-03-12 07:18:16 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 12, 2025

2025-03-12 06:14:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 831f084 has started.
2025-03-12 06:14:39 UTC Artifacts will be uploaded here
2025-03-12 06:17:33 UTC ya make is running...
2025-03-12 07:18:14 UTC Check cancelled

alexvru
alexvru previously approved these changes Mar 12, 2025
@kruall
Copy link
Collaborator Author

kruall commented Mar 12, 2025

Добавил еще код который ускоряет ring queue
Сравнение с мейном
https://gist.github.com/kruall/0342a6774f461d946ce0bde4b06c8d02
Сравнение с предыдущей версией
https://gist.github.com/kruall/3ca32cda97e281db6e16e6840da8b90e

Такие же изменения сделать для обычной очереди нельзя, так как долбиться в пустую очередь при ring queue гораздо дешевле чем UnorderedCache

@github-actions
Copy link

github-actions bot commented Mar 12, 2025

2025-03-12 07:21:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 78eca18 has started.
2025-03-12 07:22:05 UTC Artifacts will be uploaded here
2025-03-12 07:25:08 UTC ya make is running...
🔴 2025-03-12 08:56:46 UTC Too many tests failed, NOT going to retry
🔴 2025-03-12 09:14:24 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27039 11451 0 12602 2774 212

🟢 2025-03-12 09:17:22 UTC Build successful.
🟢 2025-03-12 09:18:00 UTC ydbd size 2.1 GiB changed* by +7.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9059c45 merge: 78eca18 diff diff %
ydbd size 2 296 308 824 Bytes 2 296 316 072 Bytes +7.1 KiB +0.000%
ydbd stripped size 480 743 104 Bytes 480 743 168 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 12, 2025

2025-03-12 07:22:05 UTC Pre-commit check linux-x86_64-release-asan for 78eca18 has started.
2025-03-12 07:22:20 UTC Artifacts will be uploaded here
2025-03-12 07:25:21 UTC ya make is running...
🔴 2025-03-12 08:43:29 UTC Too many tests failed, NOT going to retry
🟡 2025-03-12 08:48:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13826 9158 0 4510 103 55

🟢 2025-03-12 08:50:02 UTC Build successful.
🟢 2025-03-12 08:50:41 UTC ydbd size 3.7 GiB changed* by +17.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9059c45 merge: 78eca18 diff diff %
ydbd size 3 999 356 536 Bytes 3 999 374 360 Bytes +17.4 KiB +0.000%
ydbd stripped size 1 389 764 296 Bytes 1 389 772 520 Bytes +8.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

alexvru
alexvru previously approved these changes Mar 12, 2025
@kruall kruall enabled auto-merge (squash) March 12, 2025 07:45
@github-actions
Copy link

github-actions bot commented Mar 12, 2025

2025-03-12 10:09:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for 598ba09 has started.
2025-03-12 10:09:53 UTC Artifacts will be uploaded here
2025-03-12 10:12:52 UTC ya make is running...
🟡 2025-03-12 11:41:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28670 26082 0 5 2470 113

2025-03-12 11:44:15 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-12 11:54:23 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
166 (only retried tests) 63 0 0 0 103

🟢 2025-03-12 11:54:32 UTC Build successful.
🟢 2025-03-12 11:54:51 UTC ydbd size 2.1 GiB changed* by +8.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: add786e merge: 598ba09 diff diff %
ydbd size 2 297 773 344 Bytes 2 297 781 904 Bytes +8.4 KiB +0.000%
ydbd stripped size 480 910 144 Bytes 480 910 080 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 12, 2025

2025-03-12 10:09:47 UTC Pre-commit check linux-x86_64-release-asan for 598ba09 has started.
2025-03-12 10:10:02 UTC Artifacts will be uploaded here
2025-03-12 10:13:05 UTC ya make is running...
🟡 2025-03-12 11:48:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14189 14094 0 52 6 37

2025-03-12 11:50:12 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-12 12:02:11 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
135 (only retried tests) 100 0 0 2 33

🟢 2025-03-12 12:02:18 UTC Build successful.
🟢 2025-03-12 12:02:45 UTC ydbd size 3.7 GiB changed* by +19.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: add786e merge: 598ba09 diff diff %
ydbd size 4 001 765 184 Bytes 4 001 785 296 Bytes +19.6 KiB +0.001%
ydbd stripped size 1 390 233 704 Bytes 1 390 242 248 Bytes +8.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kruall kruall merged commit 70284e9 into ydb-platform:main Mar 12, 2025
12 checks passed
adameat pushed a commit to adameat/ydb that referenced this pull request Mar 20, 2025
blinkov pushed a commit that referenced this pull request Mar 21, 2025
Emgariko pushed a commit to Emgariko/ydb that referenced this pull request Mar 24, 2025
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
kruall added a commit to kruall/ydb that referenced this pull request Jun 4, 2025
kruall added a commit to kruall/ydb that referenced this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/actorsystem Actor System related issues not-for-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants