Skip to content

Fix gui and add config metrics #15703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mregrock merged 2 commits into from
Mar 13, 2025
Merged

Fix gui and add config metrics #15703

mregrock merged 2 commits into from
Mar 13, 2025

Conversation

@mregrock
Copy link
Collaborator

@mregrock mregrock commented Mar 13, 2025

Changelog entry

Fix gui and add config metrics

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@mregrock mregrock requested a review from a team as a code owner March 13, 2025 13:26
@github-actions
Copy link

github-actions bot commented Mar 13, 2025

🟢 2025-03-13 13:27:21 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Mar 13, 2025 •
edited
Loading

⚪ 2025-03-13 13:28:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for 065fefd has started.
⚪ 2025-03-13 13:28:33 UTC Artifacts will be uploaded here
⚪ 2025-03-13 13:31:35 UTC ya make is running...
⚫ 2025-03-13 13:41:15 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 13, 2025 •
edited
Loading

⚪ 2025-03-13 13:30:06 UTC Pre-commit check linux-x86_64-release-asan for 065fefd has started.
⚪ 2025-03-13 13:30:21 UTC Artifacts will be uploaded here
⚪ 2025-03-13 13:33:15 UTC ya make is running...
⚫ 2025-03-13 13:41:00 UTC Check cancelled

@mregrock mregrock force-pushed the fix_gui_and_add_metrics branch from 02a0de1 to 3b1b39f Compare March 13, 2025 13:40
Enjection
Enjection previously approved these changes Mar 13, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Mar 13, 2025 •
edited
Loading

⚪ 2025-03-13 13:47:48 UTC Pre-commit check linux-x86_64-release-asan for acfb159 has started.
⚪ 2025-03-13 13:48:20 UTC Artifacts will be uploaded here
⚪ 2025-03-13 13:51:53 UTC ya make is running...
🔴 2025-03-13 14:02:16 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Mar 13, 2025 •
edited
Loading

⚪ 2025-03-13 13:48:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for acfb159 has started.
⚪ 2025-03-13 13:49:09 UTC Artifacts will be uploaded here
⚪ 2025-03-13 13:51:56 UTC ya make is running...
🔴 2025-03-13 14:03:09 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Mar 13, 2025 •
edited
Loading

⚪ 2025-03-13 14:20:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for d7e5e37 has started.
⚪ 2025-03-13 14:20:51 UTC Artifacts will be uploaded here
⚪ 2025-03-13 14:24:28 UTC ya make is running...
🟡 2025-03-13 15:25:34 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27951 25358 0 2 2471 120

⚪ 2025-03-13 15:29:04 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-13 15:46:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
171 (only retried tests) 58 0 1 3 109

⚪ 2025-03-13 15:47:06 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-13 16:05:24 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
153 (only retried tests) 44 0 0 3 106

🟢 2025-03-13 16:05:35 UTC Build successful.
🟢 2025-03-13 16:05:58 UTC ydbd size 2.1 GiB changed* by +8.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e51a5c1 merge: d7e5e37 diff diff %
ydbd size 2 297 725 296 Bytes 2 297 733 688 Bytes +8.2 KiB +0.000%
ydbd stripped size 480 995 968 Bytes 480 997 760 Bytes +1.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 13, 2025 •
edited
Loading

⚪ 2025-03-13 14:21:41 UTC Pre-commit check linux-x86_64-release-asan for d7e5e37 has started.
⚪ 2025-03-13 14:21:56 UTC Artifacts will be uploaded here
⚪ 2025-03-13 14:24:46 UTC ya make is running...
🟡 2025-03-13 15:28:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13556 13396 0 96 25 39

⚪ 2025-03-13 15:30:22 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-13 15:53:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
233 (only retried tests) 192 0 1 4 36

⚪ 2025-03-13 15:53:27 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-13 16:06:55 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70 (only retried tests) 33 0 0 3 34

🟢 2025-03-13 16:07:02 UTC Build successful.
🟢 2025-03-13 16:07:38 UTC ydbd size 3.8 GiB changed* by +14.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e51a5c1 merge: d7e5e37 diff diff %
ydbd size 4 045 738 096 Bytes 4 045 752 728 Bytes +14.3 KiB +0.000%
ydbd stripped size 1 399 808 648 Bytes 1 399 812 680 Bytes +3.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@mregrock mregrock enabled auto-merge (squash) March 13, 2025 18:07
@mregrock mregrock merged commit 6185a38 into ydb-platform:main Mar 13, 2025
12 checks passed
adameat pushed a commit to adameat/ydb that referenced this pull request Mar 20, 2025
@mregrock @adameat
Fix gui and add config metrics (ydb-platform#15703)
f45d452
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@mregrock @blinkov
Fix gui and add config metrics (#15703)
2934dcd
Emgariko pushed a commit to Emgariko/ydb that referenced this pull request Mar 24, 2025
@mregrock @Emgariko
Fix gui and add config metrics (ydb-platform#15703)
a4d9c04
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
@mregrock
Fix gui and add config metrics (ydb-platform#15703)
0aaa49e
mregrock added a commit to mregrock/ydb that referenced this pull request Apr 23, 2025
@mregrock
Fix gui and add config metrics (ydb-platform#15703)
547d469
mregrock added a commit to mregrock/ydb that referenced this pull request Apr 23, 2025
@mregrock
Fix gui and add config metrics (ydb-platform#15703)
c824e18
This was referenced Apr 23, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Enjection Enjection Enjection approved these changes

@stanislav-shchetinin stanislav-shchetinin Awaiting requested review from stanislav-shchetinin stanislav-shchetinin is a code owner automatically assigned from ydb-platform/core

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mregrock @Enjection