Skip to content

[25-1]Make DateTime UDF overloads backward compatible. #15776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lll-phill-lll merged 1 commit into from
Mar 17, 2025
Merged

[25-1]Make DateTime UDF overloads backward compatible. #15776

lll-phill-lll merged 1 commit into from
Mar 17, 2025

Conversation

@lll-phill-lll
Copy link
Member

@lll-phill-lll lll-phill-lll commented Mar 14, 2025 •
edited
Loading

Changelog entry

YQL-19700: Make DateTime UDF overloads backward compatible

cherry-pick of 519ccaf

pr: https://a.yandex-team.ru/review/8205153/files/1
...

Changelog category

  • Bugfix

Description for reviewers

...

@lll-phill-lll lll-phill-lll requested a review from a team as a code owner March 14, 2025 16:55
@github-actions
Copy link

github-actions bot commented Mar 14, 2025 •
edited
Loading

⚪ 2025-03-14 16:56:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for af8c989 has started.
⚪ 2025-03-14 16:57:30 UTC Artifacts will be uploaded here
⚪ 2025-03-14 17:00:40 UTC ya make is running...
🟡 2025-03-14 17:58:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19221 16606 0 9 2477 129

⚪ 2025-03-14 18:00:32 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-14 18:22:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
223 (only retried tests) 93 0 2 4 124

⚪ 2025-03-14 18:22:15 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-14 18:42:46 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
186 (only retried tests) 61 0 1 0 124

🟢 2025-03-14 18:42:56 UTC Build successful.
🟢 2025-03-14 18:43:15 UTC ydbd size 2.1 GiB changed* by +688 Bytes, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 152834e merge: af8c989 diff diff %
ydbd size 2 242 534 256 Bytes 2 242 534 944 Bytes +688 Bytes +0.000%
ydbd stripped size 474 958 936 Bytes 474 958 936 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 14, 2025 •
edited
Loading

⚪ 2025-03-14 16:59:30 UTC Pre-commit check linux-x86_64-release-asan for af8c989 has started.
⚪ 2025-03-14 16:59:46 UTC Artifacts will be uploaded here
⚪ 2025-03-14 17:02:19 UTC ya make is running...
🟡 2025-03-14 17:52:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5881 5844 0 5 5 27

⚪ 2025-03-14 17:52:44 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-14 18:12:47 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59 (only retried tests) 31 0 0 2 26

🟢 2025-03-14 18:12:54 UTC Build successful.
🟢 2025-03-14 18:13:17 UTC ydbd size 3.6 GiB changed* by -10.6 KiB, which is <= 0 Bytes vs stable-25-1: OK

ydbd size dash stable-25-1: 152834e merge: af8c989 diff diff %
ydbd size 3 900 955 280 Bytes 3 900 944 448 Bytes -10.6 KiB -0.000%
ydbd stripped size 1 365 305 200 Bytes 1 365 296 880 Bytes -8.1 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@lll-phill-lll lll-phill-lll linked an issue Mar 14, 2025 that may be closed by this pull request
stable-24-4 + stable-25-1: Error: Module: DateTime2, function: ShiftMonths, error: User type is missing, code: 1 #15499
Closed
@lll-phill-lll lll-phill-lll added the rebase-and-check Rebase PR with the current base branch and check label Mar 14, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Mar 14, 2025
@github-actions
Copy link

github-actions bot commented Mar 14, 2025 •
edited
Loading

⚪ 2025-03-14 18:54:12 UTC Pre-commit check linux-x86_64-release-asan for af8c989 has started.
⚪ 2025-03-14 18:54:44 UTC Artifacts will be uploaded here
⚪ 2025-03-14 18:58:04 UTC ya make is running...
🟡 2025-03-14 19:48:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5881 5825 0 17 12 27

⚪ 2025-03-14 19:48:42 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-14 20:08:53 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
83 (only retried tests) 52 0 0 6 25

🟢 2025-03-14 20:09:00 UTC Build successful.
🟢 2025-03-14 20:09:25 UTC ydbd size 3.6 GiB changed* by -10.6 KiB, which is <= 0 Bytes vs stable-25-1: OK

ydbd size dash stable-25-1: 152834e merge: af8c989 diff diff %
ydbd size 3 900 955 280 Bytes 3 900 944 448 Bytes -10.6 KiB -0.000%
ydbd stripped size 1 365 305 200 Bytes 1 365 296 880 Bytes -8.1 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 14, 2025 •
edited
Loading

⚪ 2025-03-14 18:54:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for af8c989 has started.
⚪ 2025-03-14 18:54:36 UTC Artifacts will be uploaded here
⚪ 2025-03-14 18:57:16 UTC ya make is running...
🟡 2025-03-14 19:53:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19221 16628 0 4 2465 124

⚪ 2025-03-14 19:54:41 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-14 20:14:58 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
192 (only retried tests) 64 0 0 5 123

🟢 2025-03-14 20:15:04 UTC Build successful.
🟢 2025-03-14 20:15:22 UTC ydbd size 2.1 GiB changed* by +688 Bytes, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 152834e merge: af8c989 diff diff %
ydbd size 2 242 534 256 Bytes 2 242 534 944 Bytes +688 Bytes +0.000%
ydbd stripped size 474 958 936 Bytes 474 958 936 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@lll-phill-lll lll-phill-lll changed the title Make DateTime UDF overloads backward compatible. cherry-pick: 519ccaf… Make DateTime UDF overloads backward compatible. Mar 17, 2025
@lll-phill-lll lll-phill-lll merged commit 5c53ee8 into ydb-platform:stable-25-1 Mar 17, 2025
17 of 18 checks passed
@lll-phill-lll lll-phill-lll changed the title Make DateTime UDF overloads backward compatible. [25-1]Make DateTime UDF overloads backward compatible. Mar 17, 2025
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igormunkin igormunkin igormunkin approved these changes

@maximyurchuk maximyurchuk maximyurchuk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

stable-24-4 + stable-25-1: Error: Module: DateTime2, function: ShiftMonths, error: User type is missing, code: 1

3 participants

@lll-phill-lll @igormunkin @maximyurchuk