Skip to content

Conversation

@kungasc
Copy link
Contributor

@kungasc kungasc commented Mar 17, 2025

Changelog entry

Fixes invalid data shards histograms when enable_local_dbbtree_index is enabled (#15235)

Changelog category

  • Bugfix

Description for reviewers

Due to wrong cast int compare result to i8, we got a wrong events order

Also adds additional key logs, fixes typo with GetDataSize, adds error log in a case with bad histogram

#15720

@kungasc kungasc changed the base branch from main to stable-25-1 March 17, 2025 10:56
@github-actions
Copy link

🟢 2025-03-17 10:57:42 UTC The validation of the Pull Request description is successful.

@kungasc kungasc self-assigned this Mar 17, 2025
@kungasc kungasc added the rebase-and-check Rebase PR with the current base branch and check label Mar 17, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Mar 17, 2025
@github-actions
Copy link

github-actions bot commented Mar 17, 2025

2025-03-17 11:09:48 UTC Pre-commit check linux-x86_64-release-asan for bbbb342 has started.
2025-03-17 11:10:02 UTC Artifacts will be uploaded here
2025-03-17 11:13:04 UTC ya make is running...
🟡 2025-03-17 12:50:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13594 13418 0 114 24 38

2025-03-17 12:52:06 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-17 13:13:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
222 (only retried tests) 180 0 1 7 34

2025-03-17 13:14:03 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-17 13:34:29 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71 (only retried tests) 35 0 0 2 34

🟢 2025-03-17 13:34:46 UTC Build successful.
🟢 2025-03-17 13:35:16 UTC ydbd size 3.6 GiB changed* by +36.4 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 5c53ee8 merge: bbbb342 diff diff %
ydbd size 3 901 757 536 Bytes 3 901 794 824 Bytes +36.4 KiB +0.001%
ydbd stripped size 1 365 470 544 Bytes 1 365 486 160 Bytes +15.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 17, 2025

2025-03-17 11:15:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for bbbb342 has started.
2025-03-17 11:15:39 UTC Artifacts will be uploaded here
2025-03-17 11:18:48 UTC ya make is running...
🟡 2025-03-17 12:54:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27812 25205 0 5 2465 137

2025-03-17 12:57:13 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-17 13:22:18 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
219 (only retried tests) 85 0 0 2 132

🟢 2025-03-17 13:22:27 UTC Build successful.
🟢 2025-03-17 13:22:47 UTC ydbd size 2.1 GiB changed* by +17.0 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 5c53ee8 merge: bbbb342 diff diff %
ydbd size 2 243 014 368 Bytes 2 243 031 776 Bytes +17.0 KiB +0.001%
ydbd stripped size 475 014 648 Bytes 475 017 720 Bytes +3.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kungasc kungasc marked this pull request as ready for review March 17, 2025 14:47
@kungasc kungasc requested a review from a team as a code owner March 17, 2025 14:47
@kungasc kungasc merged commit 464a31d into ydb-platform:stable-25-1 Mar 17, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants