-
Notifications
You must be signed in to change notification settings - Fork 740
TLI system views #16103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLI system views #16103
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
5dd5ef4 to
6a30847
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
be3fa61 to
21d704a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
21d704a to
9378262
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
9378262 to
803a965
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extends system view protobuf definitions to support new cumulative lock metrics and adds new system views for partition top metrics by TLI.
- Added new lock fields (LocksAcquired, LocksWholeShard, LocksBroken) to TPartitionStats and TTopPartitionsInfo.
- Updated the EStatsType enum to replace the previous top partitions metrics with new CPU and TLI based metrics.
- Modified TEvSendTopPartitions to split partition metrics into separate fields for CPU and TLI views.
Files not reviewed (19)
- ydb/core/sys_view/common/schema.cpp: Language not supported
- ydb/core/sys_view/common/schema.h: Language not supported
- ydb/core/sys_view/partition_stats/partition_stats.cpp: Language not supported
- ydb/core/sys_view/partition_stats/top_partitions.cpp: Language not supported
- ydb/core/sys_view/partition_stats/top_partitions.h: Language not supported
- ydb/core/sys_view/processor/processor_impl.cpp: Language not supported
- ydb/core/sys_view/processor/processor_impl.h: Language not supported
- ydb/core/sys_view/processor/schema.h: Language not supported
- ydb/core/sys_view/processor/tx_init.cpp: Language not supported
- ydb/core/sys_view/processor/tx_top_partitions.cpp: Language not supported
- ydb/core/sys_view/scan.cpp: Language not supported
- ydb/core/sys_view/ut_kqp.cpp: Language not supported
- ydb/core/tx/schemeshard/schemeshard__init.cpp: Language not supported
- ydb/core/tx/schemeshard/schemeshard__table_stats.cpp: Language not supported
- ydb/core/tx/schemeshard/schemeshard_impl.cpp: Language not supported
- ydb/core/tx/schemeshard/schemeshard_info_types.cpp: Language not supported
- ydb/core/tx/schemeshard/schemeshard_info_types.h: Language not supported
- ydb/core/tx/schemeshard/schemeshard_path_describer.cpp: Language not supported
- ydb/core/tx/schemeshard/schemeshard_schema.h: Language not supported
Comments suppressed due to low confidence (1)
ydb/core/protos/sys_view.proto:52
- The field name 'LocksWholeShard' differs in capitalization from the PR description ('LocksWholeshard'). Consider aligning the naming for consistency.
optional uint64 LocksWholeShard = 24;
Changelog entry
partition_statssystem viewAdd new cumulative fields to the existing
partition_statssystem view:LocksAcquired- the number of locks installed "per key range";LocksWholeshard- the number of installed locks "for the entire batch";LocksBroken- the number of broken locks.top_partitions_by_tli_one_*system viewAdd new
top_partitions_by_tli_one_hourandtop_partitions_by_tli_one_minutesystem views.The views give out the top 10 partitions with a large number of broken locks.
Changelog category
Description for reviewers
...