Skip to content

Conversation

@azevaykin
Copy link
Collaborator

Changelog entry

partition_stats system view

Add new cumulative fields to the existing partition_stats system view:

  • LocksAcquired - the number of locks installed "per key range";
  • LocksWholeshard - the number of installed locks "for the entire batch";
  • LocksBroken - the number of broken locks.

top_partitions_by_tli_one_* system view

Add new top_partitions_by_tli_one_hour and top_partitions_by_tli_one_minute system views.

The views give out the top 10 partitions with a large number of broken locks.

Changelog category

  • New feature

Description for reviewers

...

@azevaykin azevaykin requested a review from a team as a code owner March 23, 2025 19:25
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@azevaykin azevaykin linked an issue Mar 24, 2025 that may be closed by this pull request
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions
Copy link

github-actions bot commented Mar 26, 2025

2025-03-26 15:35:02 UTC Pre-commit check linux-x86_64-release-asan for 7da44f6 has started.
2025-03-26 15:35:05 UTC Artifacts will be uploaded here
2025-03-26 15:38:17 UTC ya make is running...
🟡 2025-03-26 17:35:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14172 14048 0 67 19 38

2025-03-26 17:37:13 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-26 17:52:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
192 (only retried tests) 150 0 5 6 31

2025-03-26 17:52:41 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-26 18:06:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
66 (only retried tests) 29 0 4 3 30

🟢 2025-03-26 18:06:32 UTC Build successful.
🟡 2025-03-26 18:07:02 UTC ydbd size 3.8 GiB changed* by +878.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7c5cddc merge: 7da44f6 diff diff %
ydbd size 4 110 811 088 Bytes 4 111 710 616 Bytes +878.4 KiB +0.022%
ydbd stripped size 1 420 488 872 Bytes 1 420 824 776 Bytes +328.0 KiB +0.024%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 26, 2025

2025-03-26 15:36:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7da44f6 has started.
2025-03-26 15:37:07 UTC Artifacts will be uploaded here
2025-03-26 15:40:11 UTC ya make is running...
🟡 2025-03-26 17:25:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28717 26061 0 3 2542 111

2025-03-26 17:27:55 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-26 17:40:10 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
160 (only retried tests) 59 0 0 0 101

🟢 2025-03-26 17:40:19 UTC Build successful.
🟡 2025-03-26 17:40:41 UTC ydbd size 2.2 GiB changed* by +539.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7c5cddc merge: 7da44f6 diff diff %
ydbd size 2 342 862 368 Bytes 2 343 415 144 Bytes +539.8 KiB +0.024%
ydbd stripped size 489 908 992 Bytes 490 023 744 Bytes +112.1 KiB +0.023%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@blinkov blinkov requested a review from Copilot March 27, 2025 06:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends system view protobuf definitions to support new cumulative lock metrics and adds new system views for partition top metrics by TLI.

  • Added new lock fields (LocksAcquired, LocksWholeShard, LocksBroken) to TPartitionStats and TTopPartitionsInfo.
  • Updated the EStatsType enum to replace the previous top partitions metrics with new CPU and TLI based metrics.
  • Modified TEvSendTopPartitions to split partition metrics into separate fields for CPU and TLI views.
Files not reviewed (19)
  • ydb/core/sys_view/common/schema.cpp: Language not supported
  • ydb/core/sys_view/common/schema.h: Language not supported
  • ydb/core/sys_view/partition_stats/partition_stats.cpp: Language not supported
  • ydb/core/sys_view/partition_stats/top_partitions.cpp: Language not supported
  • ydb/core/sys_view/partition_stats/top_partitions.h: Language not supported
  • ydb/core/sys_view/processor/processor_impl.cpp: Language not supported
  • ydb/core/sys_view/processor/processor_impl.h: Language not supported
  • ydb/core/sys_view/processor/schema.h: Language not supported
  • ydb/core/sys_view/processor/tx_init.cpp: Language not supported
  • ydb/core/sys_view/processor/tx_top_partitions.cpp: Language not supported
  • ydb/core/sys_view/scan.cpp: Language not supported
  • ydb/core/sys_view/ut_kqp.cpp: Language not supported
  • ydb/core/tx/schemeshard/schemeshard__init.cpp: Language not supported
  • ydb/core/tx/schemeshard/schemeshard__table_stats.cpp: Language not supported
  • ydb/core/tx/schemeshard/schemeshard_impl.cpp: Language not supported
  • ydb/core/tx/schemeshard/schemeshard_info_types.cpp: Language not supported
  • ydb/core/tx/schemeshard/schemeshard_info_types.h: Language not supported
  • ydb/core/tx/schemeshard/schemeshard_path_describer.cpp: Language not supported
  • ydb/core/tx/schemeshard/schemeshard_schema.h: Language not supported
Comments suppressed due to low confidence (1)

ydb/core/protos/sys_view.proto:52

  • The field name 'LocksWholeShard' differs in capitalization from the PR description ('LocksWholeshard'). Consider aligning the naming for consistency.
optional uint64 LocksWholeShard = 24;

@azevaykin azevaykin merged commit 8ce0048 into ydb-platform:main Mar 27, 2025
12 checks passed
@azevaykin azevaykin deleted the TopPartitionsTLI branch March 27, 2025 17:02
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
azevaykin added a commit to azevaykin/ydb that referenced this pull request May 28, 2025
azevaykin added a commit that referenced this pull request May 28, 2025
@liruoko liruoko added the release-scope-25-3 Для PR-ов. Означает "этот PR вошел в состав одной из версий 25-3-nnn" label Oct 13, 2025
@liruoko liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/f25-3 PR участвует в списке изменений new-feature release-scope-25-3 Для PR-ов. Означает "этот PR вошел в состав одной из версий 25-3-nnn"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Top partitions by TLI

5 participants