Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetColumnSerializationStats and ResourceSubscriber task name #1618

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Fix GetColumnSerializationStats and ResourceSubscriber task name #1618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ydb/core/tx/columnshard/normalizer/abstract/abstract.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ namespace NKikimr::NOlap {
public:
TNormalizationController(std::shared_ptr<IStoragesManager> storagesManager, const std::shared_ptr<NOlap::NResourceBroker::NSubscribe::TSubscriberCounters>& counters)
: StoragesManager(storagesManager)
, TaskSubscription("CS:NORMALIZER", counters) {}
, TaskSubscription("CS::NORMALIZER", counters) {}

const NOlap::NResourceBroker::NSubscribe::TTaskContext& GetTaskSubscription() const {
return TaskSubscription;
Expand Down
6 changes: 5 additions & 1 deletion ydb/core/tx/columnshard/splitter/batch_slice.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,11 @@ class TDefaultSchemaDetails: public ISchemaDetailInfo {
}

virtual std::optional<TColumnSerializationStat> GetColumnSerializationStats(const ui32 columnId) const override {
return Stats->GetColumnInfo(columnId);
auto stats = Stats->GetColumnInfo(columnId);
if (stats && stats->GetRecordsCount() != 0) {
return stats;
}
return std::nullopt;
}
virtual std::optional<TBatchSerializationStat> GetBatchSerializationStats(const std::shared_ptr<arrow::RecordBatch>& rb) const override {
return Stats->GetStatsForRecordBatch(rb);
Expand Down
Loading