Skip to content

YMQ: Use "name" label name instead of "sensor" for queue.total_count time series (25-1) #16263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qyryq merged 1 commit into from
Mar 26, 2025
Merged

YMQ: Use "name" label name instead of "sensor" for queue.total_count time series (25-1) #16263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ydb/core/ymq/base/counters.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ void TFolderCounters::InitCounters() {
InsertCounters();
if (UserCounters.YmqCounters) {
total_count.Init(
FolderCounters.YmqCounters, ELifetime::Expiring, EValueType::Absolute, DEFAULT_COUNTER_NAME,
FolderCounters.YmqCounters, ELifetime::Expiring, EValueType::Absolute, DEFAULT_YMQ_COUNTER_NAME,
"queue.total_count",
ELaziness::OnStart
);
Expand Down Expand Up @@ -985,7 +985,7 @@ void TCloudAuthCounters::InitCounters(TIntrusivePtr<::NMonitoring::TDynamicCount
for (size_t credentialType = 0; credentialType < NCloudAuth::ECredentialType::CredentialTypesCount; ++credentialType) {
const auto credentialTypeStr = ToString(static_cast<NCloudAuth::ECredentialType>(credentialType));
const auto actionAndCredentialCounters = actionCounters->GetSubgroup("credential_type", credentialTypeStr);

if (actionType == NCloudAuth::EActionType::Authorize) {
INIT_COUNTER_WITH_NAME(actionAndCredentialCounters, AuthorizeSuccess[credentialType], "Ok", ELifetime::Persistent, EValueType::Derivative, Lazy(*Cfg));
INIT_COUNTER_WITH_NAME(actionAndCredentialCounters, AuthorizeError[credentialType], "PermissionDenied", ELifetime::Persistent, EValueType::Derivative, Lazy(*Cfg));
Expand Down Expand Up @@ -1017,11 +1017,11 @@ void TMonitoringCounters::InitCounters() {
INIT_COUNTER(MonitoringCounters, CleanupRemovedQueuesDone, ELifetime::Persistent, EValueType::Derivative, Lazy(Config));
INIT_COUNTER(MonitoringCounters, CleanupRemovedQueuesRows, ELifetime::Persistent, EValueType::Derivative, Lazy(Config));
INIT_COUNTER(MonitoringCounters, CleanupRemovedQueuesErrors, ELifetime::Persistent, EValueType::Derivative, Lazy(Config));


INIT_COUNTER(MonitoringCounters, LocalLeaderStartInflight, ELifetime::Persistent, EValueType::Derivative, Lazy(Config));
INIT_COUNTER(MonitoringCounters, LocalLeaderStartQueue, ELifetime::Persistent, EValueType::Derivative, Lazy(Config));

INIT_HISTOGRAM_COUNTER(MonitoringCounters, LocalLeaderStartAwaitMs, ELifetime::Expiring, DurationBucketsMs, ELaziness::OnDemand);
}

Expand Down
2 changes: 1 addition & 1 deletion ydb/tests/functional/sqs/cloud/test_yandex_cloud_mode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ def check_counter(labels, expected):
)

def check_total_count(expected):
return check_counter({"sensor": "queue.total_count"}, expected)
return check_counter({"name": "queue.total_count"}, expected)

def check_messages_sent(q_name, expected):
return check_counter({"name": "queue.messages.sent_count_per_second", "queue": q_name}, expected)
Expand Down
Loading