Skip to content

Added the ability to pause and resume transfers #16339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nshestakov merged 9 commits into from
Mar 28, 2025
Merged

Added the ability to pause and resume transfers #16339

nshestakov merged 9 commits into from
Mar 28, 2025

Conversation

@nshestakov
Copy link
Collaborator

@nshestakov nshestakov commented Mar 27, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@nshestakov nshestakov requested review from a team as code owners March 27, 2025 12:45
@github-actions
Copy link

github-actions bot commented Mar 27, 2025

🟢 2025-03-27 12:47:08 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Mar 27, 2025 •
edited
Loading

⚪ 2025-03-27 12:47:12 UTC Pre-commit check linux-x86_64-release-asan for 4e1566d has started.
⚪ 2025-03-27 12:47:27 UTC Artifacts will be uploaded here
⚪ 2025-03-27 12:50:42 UTC ya make is running...
🟡 2025-03-27 14:46:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14678 14540 0 82 19 37

⚪ 2025-03-27 14:47:53 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-27 15:01:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
197 (only retried tests) 148 0 10 4 35

⚪ 2025-03-27 15:01:34 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-27 15:15:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
80 (only retried tests) 38 0 6 4 32

🟢 2025-03-27 15:16:09 UTC Build successful.
🟢 2025-03-27 15:16:46 UTC ydbd size 3.8 GiB changed* by +3.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ea4ffc9 merge: 4e1566d diff diff %
ydbd size 4 112 327 376 Bytes 4 112 331 032 Bytes +3.6 KiB +0.000%
ydbd stripped size 1 421 089 128 Bytes 1 421 094 632 Bytes +5.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov requested a review from CyberROFL March 27, 2025 12:48
@github-actions
Copy link

github-actions bot commented Mar 27, 2025 •
edited
Loading

⚪ 2025-03-27 12:52:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4e1566d has started.
⚪ 2025-03-27 12:52:45 UTC Artifacts will be uploaded here
⚪ 2025-03-27 12:56:24 UTC ya make is running...
🟡 2025-03-27 14:38:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29240 26576 0 8 2544 112

⚪ 2025-03-27 14:41:38 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-27 14:56:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
172 (only retried tests) 67 0 2 0 103

⚪ 2025-03-27 14:56:52 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-27 15:15:41 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
146 (only retried tests) 44 0 2 0 100

🟢 2025-03-27 15:15:52 UTC Build successful.
🟢 2025-03-27 15:16:16 UTC ydbd size 2.2 GiB changed* by +9.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ea4ffc9 merge: 4e1566d diff diff %
ydbd size 2 343 530 696 Bytes 2 343 540 144 Bytes +9.2 KiB +0.000%
ydbd stripped size 490 087 648 Bytes 490 089 408 Bytes +1.7 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

CyberROFL
CyberROFL previously approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@CyberROFL CyberROFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я же правильно понял, что на паузу можно будет поставить не только трансфер, но и репликацию?

@nshestakov
Copy link
Collaborator Author

nshestakov commented Mar 27, 2025

Да, мне показалось, что это и для репликации полезно и делать только для трансфера бессмыслено

@nshestakov nshestakov requested review from Gazizonoki, gridnevvvit and pnv1 and removed request for pnv1 March 27, 2025 15:15
Gazizonoki
Gazizonoki previously approved these changes Mar 27, 2025
View reviewed changes
Copy link
Collaborator

@Gazizonoki Gazizonoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ SDK - ok

gridnevvvit
gridnevvvit previously approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@gridnevvvit gridnevvvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а юнит тесты будут? а то я не нашел

@nshestakov nshestakov dismissed stale reviews from gridnevvvit, Gazizonoki, and CyberROFL via 537898a March 27, 2025 19:09
@github-actions
Copy link

github-actions bot commented Mar 27, 2025 •
edited
Loading

⚪ 2025-03-27 19:10:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for abb256e has started.
⚪ 2025-03-27 19:10:34 UTC Artifacts will be uploaded here
⚪ 2025-03-27 19:13:36 UTC ya make is running...
🟡 2025-03-27 20:52:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29221 26555 0 2 2547 117

⚪ 2025-03-27 20:54:48 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-27 21:11:51 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
171 (only retried tests) 68 0 0 0 103

🟢 2025-03-27 21:11:58 UTC Build successful.
🟢 2025-03-27 21:12:17 UTC ydbd size 2.2 GiB changed* by +13.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0afd80e merge: abb256e diff diff %
ydbd size 2 344 163 376 Bytes 2 344 176 984 Bytes +13.3 KiB +0.001%
ydbd stripped size 490 209 536 Bytes 490 215 456 Bytes +5.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 27, 2025 •
edited
Loading

⚪ 2025-03-27 19:11:20 UTC Pre-commit check linux-x86_64-release-asan for abb256e has started.
⚪ 2025-03-27 19:11:36 UTC Artifacts will be uploaded here
⚪ 2025-03-27 19:14:50 UTC ya make is running...
🟡 2025-03-27 21:12:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14660 14590 0 25 9 36

⚪ 2025-03-27 21:13:41 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-27 21:28:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
109 (only retried tests) 71 0 4 2 32

⚪ 2025-03-27 21:28:43 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-27 21:41:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
64 (only retried tests) 29 0 4 1 30

🟢 2025-03-27 21:41:10 UTC Build successful.
🟢 2025-03-27 21:41:37 UTC ydbd size 3.8 GiB changed* by +7.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0afd80e merge: abb256e diff diff %
ydbd size 4 113 365 464 Bytes 4 113 373 232 Bytes +7.6 KiB +0.000%
ydbd stripped size 1 421 467 144 Bytes 1 421 476 744 Bytes +9.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov requested review from CyberROFL, Gazizonoki and gridnevvvit and removed request for stanislav-shchetinin March 28, 2025 05:02
@nshestakov
Copy link
Collaborator Author

nshestakov commented Mar 28, 2025

а юнит тесты будут? а то я не нашел

Тесты я еще допишу.

@nshestakov nshestakov enabled auto-merge (squash) March 28, 2025 05:10
@nshestakov nshestakov merged commit 55c6da0 into ydb-platform:main Mar 28, 2025
12 checks passed
@nshestakov nshestakov deleted the TR-paused branch March 28, 2025 10:52
nshestakov added a commit to nshestakov/ydb that referenced this pull request May 5, 2025
@nshestakov
Added the ability to pause and resume transfers (ydb-platform#16339)
e71c291
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyberROFL CyberROFL CyberROFL approved these changes

@gridnevvvit gridnevvvit gridnevvvit approved these changes

@Gazizonoki Gazizonoki Gazizonoki approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nshestakov @CyberROFL @gridnevvvit @Gazizonoki