Skip to content

fix reading outdated schemas in simple reader #16357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ivanmorozov333 merged 2 commits into from
Mar 29, 2025
Merged

fix reading outdated schemas in simple reader #16357

ivanmorozov333 merged 2 commits into from
Mar 29, 2025

Conversation

@swalrus1
Copy link
Collaborator

@swalrus1 swalrus1 commented Mar 27, 2025 •
edited
Loading

Fix 16358

@github-actions
Copy link

github-actions bot commented Mar 27, 2025 •
edited
Loading

🟢 2025-03-28 14:14:48 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Mar 27, 2025 •
edited
Loading

⚪ 2025-03-27 15:54:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for 193633a has started.
⚪ 2025-03-27 15:54:52 UTC Artifacts will be uploaded here
⚪ 2025-03-27 15:57:02 UTC ya make is running...
🟡 2025-03-27 16:06:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
342 339 0 1 0 2

⚪ 2025-03-27 16:06:19 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-27 16:07:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6 (only retried tests) 3 0 1 0 2

⚪ 2025-03-27 16:07:41 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-27 16:08:49 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6 (only retried tests) 3 0 1 0 2

🟢 2025-03-27 16:08:58 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Mar 27, 2025 •
edited
Loading

⚪ 2025-03-27 15:56:43 UTC Pre-commit check linux-x86_64-release-asan for 193633a has started.
⚪ 2025-03-27 15:56:59 UTC Artifacts will be uploaded here
⚪ 2025-03-27 15:59:22 UTC ya make is running...
🟢 2025-03-27 16:03:25 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-03-27 16:03:30 UTC Build successful.

@swalrus1 swalrus1 linked an issue Mar 27, 2025 that may be closed by this pull request
VERIFY on reading portions with outdated column set in Simple reader #16358
Closed
@github-actions github-actions bot removed the bugfix label Mar 28, 2025
@swalrus1 swalrus1 marked this pull request as ready for review March 28, 2025 14:14
@swalrus1 swalrus1 requested review from a team as code owners March 28, 2025 14:14
@github-actions
Copy link

github-actions bot commented Mar 28, 2025 •
edited
Loading

⚪ 2025-03-28 14:15:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for 50240f7 has started.
⚪ 2025-03-28 14:16:40 UTC Artifacts will be uploaded here
⚪ 2025-03-28 14:19:47 UTC ya make is running...
🟡 2025-03-28 15:17:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19750 18382 0 5 1246 117

⚪ 2025-03-28 15:19:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-28 15:34:27 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
165 (only retried tests) 64 0 0 0 101

🟢 2025-03-28 15:34:36 UTC Build successful.
🟢 2025-03-28 15:34:54 UTC ydbd size 2.2 GiB changed* by +3.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3eed4cc merge: 50240f7 diff diff %
ydbd size 2 347 444 256 Bytes 2 347 447 704 Bytes +3.4 KiB +0.000%
ydbd stripped size 490 843 264 Bytes 490 843 456 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 28, 2025 •
edited
Loading

⚪ 2025-03-28 14:16:45 UTC Pre-commit check linux-x86_64-release-asan for 50240f7 has started.
⚪ 2025-03-28 14:16:59 UTC Artifacts will be uploaded here
⚪ 2025-03-28 14:19:52 UTC ya make is running...
🟡 2025-03-28 15:37:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12306 12166 0 88 18 34

⚪ 2025-03-28 15:38:20 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-28 15:56:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
206 (only retried tests) 132 0 39 5 30

⚪ 2025-03-28 15:56:28 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-28 16:10:45 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
100 (only retried tests) 35 0 33 4 28

🟢 2025-03-28 16:10:54 UTC Build successful.
🟢 2025-03-28 16:11:28 UTC ydbd size 3.8 GiB changed* by +5.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3eed4cc merge: 50240f7 diff diff %
ydbd size 4 119 585 304 Bytes 4 119 591 064 Bytes +5.6 KiB +0.000%
ydbd stripped size 1 423 878 696 Bytes 1 423 879 144 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@swalrus1 swalrus1 enabled auto-merge (squash) March 28, 2025 14:22
@swalrus1 swalrus1 disabled auto-merge March 28, 2025 14:32
@ivanmorozov333 ivanmorozov333 merged commit 92f9aaa into ydb-platform:main Mar 29, 2025
14 checks passed
@swalrus1 swalrus1 deleted the simple-reader-old-schemas branch March 31, 2025 11:33
dorooleg pushed a commit to dorooleg/ydb that referenced this pull request Apr 19, 2025
@swalrus1 @dorooleg
fix reading outdated schemas in simple reader (ydb-platform#16357)
b683b99
dorooleg pushed a commit to dorooleg/ydb that referenced this pull request Apr 20, 2025
@swalrus1 @dorooleg
fix reading outdated schemas in simple reader (ydb-platform#16357)
875b109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gridnevvvit gridnevvvit gridnevvvit approved these changes

@ivanmorozov333 ivanmorozov333 ivanmorozov333 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

VERIFY on reading portions with outdated column set in Simple reader

3 participants

@swalrus1 @gridnevvvit @ivanmorozov333