Dirty hack for config in some ydbd flavour #16424

maximyurchuk · 2025-03-28T16:56:27Z

Add hardcoded feature flags for cert version

github-actions · 2025-03-28T16:58:22Z

🟢 2025-03-31 11:23:44 UTC The validation of the Pull Request description is successful.

github-actions · 2025-03-28T16:59:58Z

⚪ 2025-03-28 16:59:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for db645c2 has started.
⚪ 2025-03-28 17:00:14 UTC Artifacts will be uploaded here
⚪ 2025-03-28 17:02:40 UTC ya make is running...
⚫ 2025-03-28 17:07:35 UTC Check cancelled

github-actions · 2025-03-28T17:00:26Z

⚪ 2025-03-28 17:00:26 UTC Pre-commit check linux-x86_64-release-asan for db645c2 has started.
⚪ 2025-03-28 17:00:42 UTC Artifacts will be uploaded here
⚪ 2025-03-28 17:03:08 UTC ya make is running...
⚫ 2025-03-28 17:07:33 UTC Check cancelled

Copilot

Pull Request Overview

This PR introduces a temporary workaround by hardcoding feature flags for a specific ydbd flavour based on certificate usage.

Added conditional block to apply feature flags when "cert" is found in the binary path
Updated the configuration for feature flags in the test harness

ydb/tests/library/harness/kikimr_config.py

github-actions · 2025-03-28T17:10:21Z

⚪ 2025-03-28 17:10:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for fcf29a3 has started.
⚪ 2025-03-28 17:10:43 UTC Artifacts will be uploaded here
⚪ 2025-03-28 17:13:28 UTC ya make is running...
🟡 2025-03-28 17:52:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
4856	4734	0	2	41	79

⚪ 2025-03-28 17:52:34 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-28 18:01:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
100 (only retried tests)	25	0	1	0	74

⚪ 2025-03-28 18:02:01 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-28 18:09:42 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
86 (only retried tests)	13	0	1	0	72

🟢 2025-03-28 18:09:53 UTC Build successful.
🟡 2025-03-28 18:10:08 UTC ydbd size 2.2 GiB changed* by +523.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `ff6febe`	merge: `fcf29a3`	diff	diff %
ydbd size	2 347 769 400 Bytes	2 348 305 224 Bytes	+523.3 KiB	+0.023%
ydbd stripped size	490 919 296 Bytes	490 962 912 Bytes	+42.6 KiB	+0.009%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-03-28T17:11:24Z

⚪ 2025-03-28 17:11:23 UTC Pre-commit check linux-x86_64-release-asan for fcf29a3 has started.
⚪ 2025-03-28 17:11:39 UTC Artifacts will be uploaded here
⚪ 2025-03-28 17:13:57 UTC ya make is running...
🟡 2025-03-28 17:52:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
1867	1833	0	12	12	10

⚪ 2025-03-28 17:52:46 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-28 18:04:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
40 (only retried tests)	22	0	5	3	10

⚪ 2025-03-28 18:04:25 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-28 18:15:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
24 (only retried tests)	8	0	6	1	9

🟢 2025-03-28 18:16:06 UTC Build successful.
🟡 2025-03-28 18:16:26 UTC ydbd size 3.8 GiB changed* by +849.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `ff6febe`	merge: `fcf29a3`	diff	diff %
ydbd size	4 120 171 264 Bytes	4 121 041 304 Bytes	+849.6 KiB	+0.021%
ydbd stripped size	1 424 061 800 Bytes	1 424 222 504 Bytes	+156.9 KiB	+0.011%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-03-28T18:21:48Z

⚪ 2025-03-28 18:21:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for fe122b2 has started.
⚪ 2025-03-28 18:22:02 UTC Artifacts will be uploaded here
⚪ 2025-03-28 18:24:19 UTC ya make is running...
🟡 2025-03-28 18:59:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
4856	4732	0	4	38	82

⚪ 2025-03-28 19:00:22 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-28 19:16:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
105 (only retried tests)	30	0	1	0	74

⚪ 2025-03-28 19:16:56 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-28 19:25:02 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
85 (only retried tests)	12	0	1	0	72

🟢 2025-03-28 19:25:11 UTC Build successful.
🟢 2025-03-28 19:25:25 UTC ydbd size 2.2 GiB changed* by +320 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `9f8a506`	merge: `fe122b2`	diff	diff %
ydbd size	2 348 305 224 Bytes	2 348 305 544 Bytes	+320 Bytes	+0.000%
ydbd stripped size	490 962 912 Bytes	490 962 976 Bytes	+64 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-03-28T18:22:03Z

⚪ 2025-03-28 18:22:03 UTC Pre-commit check linux-x86_64-release-asan for fe122b2 has started.
⚪ 2025-03-28 18:22:17 UTC Artifacts will be uploaded here
⚪ 2025-03-28 18:24:35 UTC ya make is running...
🟡 2025-03-28 18:59:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
1867	1832	0	10	14	11

⚪ 2025-03-28 19:00:07 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-28 19:17:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
40 (only retried tests)	17	0	5	9	9

⚪ 2025-03-28 19:17:15 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-28 19:30:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
27 (only retried tests)	12	0	5	1	9

🟢 2025-03-28 19:31:02 UTC Build successful.
🟢 2025-03-28 19:31:19 UTC ydbd size 3.8 GiB changed* by +272 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `9f8a506`	merge: `fe122b2`	diff	diff %
ydbd size	4 121 041 400 Bytes	4 121 041 672 Bytes	+272 Bytes	+0.000%
ydbd stripped size	1 424 222 568 Bytes	1 424 222 632 Bytes	+64 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-03-31T10:55:28Z

⚪ 2025-03-31 10:55:28 UTC Pre-commit check linux-x86_64-release-asan for 3d5b34d has started.
⚪ 2025-03-31 10:55:42 UTC Artifacts will be uploaded here
⚪ 2025-03-31 10:58:05 UTC ya make is running...
🟡 2025-03-31 11:55:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
1867	1831	0	12	12	12

⚪ 2025-03-31 11:55:27 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-31 12:07:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
43 (only retried tests)	25	0	4	3	11

⚪ 2025-03-31 12:07:20 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-31 12:18:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
24 (only retried tests)	9	0	4	1	10

🟢 2025-03-31 12:18:43 UTC Build successful.
🟢 2025-03-31 12:19:03 UTC ydbd size 3.8 GiB changed* by +304 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `582fbd6`	merge: `3d5b34d`	diff	diff %
ydbd size	4 122 038 168 Bytes	4 122 038 472 Bytes	+304 Bytes	+0.000%
ydbd stripped size	1 424 471 816 Bytes	1 424 471 752 Bytes	-64 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-03-31T10:55:30Z

⚪ 2025-03-31 10:55:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3d5b34d has started.
⚪ 2025-03-31 10:55:45 UTC Artifacts will be uploaded here
⚪ 2025-03-31 10:58:09 UTC ya make is running...
🟡 2025-03-31 11:52:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
4856	4733	0	2	39	82

⚪ 2025-03-31 11:52:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-31 12:04:28 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
102 (only retried tests)	25	0	0	0	77

🟢 2025-03-31 12:04:35 UTC Build successful.
🟢 2025-03-31 12:04:47 UTC ydbd size 2.2 GiB changed* by +3.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `c47a3af`	merge: `3d5b34d`	diff	diff %
ydbd size	2 349 153 536 Bytes	2 349 156 592 Bytes	+3.0 KiB	+0.000%
ydbd stripped size	491 106 656 Bytes	491 107 136 Bytes	+480 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

Dirty hack for config in some ydbd flavour

834c527

maximyurchuk requested a review from Copilot March 28, 2025 17:06

Copilot AI reviewed Mar 28, 2025

View reviewed changes

ydb/tests/library/harness/kikimr_config.py Outdated Show resolved Hide resolved

maximyurchuk force-pushed the cert_workaround branch from 9289a07 to 834c527 Compare March 28, 2025 17:08

fix

7267f92

gridnevvvit previously approved these changes Mar 28, 2025

View reviewed changes

maximyurchuk added the rebase-and-check Rebase PR with the current base branch and check label Mar 28, 2025

github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Mar 28, 2025

Fix

9f84a82

maximyurchuk dismissed gridnevvvit’s stale review via 9f84a82 March 31, 2025 10:52

gridnevvvit approved these changes Mar 31, 2025

View reviewed changes

maximyurchuk merged commit 4c8118a into ydb-platform:main Mar 31, 2025
16 checks passed

maximyurchuk added a commit to maximyurchuk/ydb that referenced this pull request Apr 2, 2025

Dirty hack for config in some ydbd flavour (ydb-platform#16424)

3f0757c

maximyurchuk mentioned this pull request Apr 2, 2025

stable-25-1: ability to test different ydb flavours #16681

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Dirty hack for config in some ydbd flavour #16424

Dirty hack for config in some ydbd flavour #16424

Uh oh!

maximyurchuk commented Mar 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 28, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

github-actions bot commented Mar 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 31, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 31, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Dirty hack for config in some ydbd flavour #16424

Dirty hack for config in some ydbd flavour #16424

Uh oh!

Conversation

maximyurchuk commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

github-actions bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

maximyurchuk commented Mar 28, 2025 •

edited

Loading

github-actions bot commented Mar 28, 2025 •

edited

Loading

github-actions bot commented Mar 28, 2025 •

edited

Loading

github-actions bot commented Mar 28, 2025 •

edited

Loading

github-actions bot commented Mar 28, 2025 •

edited

Loading

github-actions bot commented Mar 28, 2025 •

edited

Loading

github-actions bot commented Mar 28, 2025 •

edited

Loading

github-actions bot commented Mar 28, 2025 •

edited

Loading

github-actions bot commented Mar 31, 2025 •

edited

Loading

github-actions bot commented Mar 31, 2025 •

edited

Loading