Skip to content

fix returning clause in upsert/insert on missing input columns (#16060) #16633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gridnevvvit merged 2 commits into from
Apr 2, 2025
Merged

fix returning clause in upsert/insert on missing input columns (#16060) #16633

gridnevvvit merged 2 commits into from
Apr 2, 2025

Conversation

@gridnevvvit
Copy link
Member

@gridnevvvit gridnevvvit commented Apr 1, 2025 •
edited
Loading

Changelog entry

based on 679f7fd
fixes #15551

Changelog category

  • Bugfix

Description for reviewers

...

@gridnevvvit gridnevvvit requested a review from a team as a code owner April 1, 2025 18:07
@github-actions
Copy link

github-actions bot commented Apr 1, 2025 •
edited
Loading

🟢 2025-04-01 18:25:46 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Apr 1, 2025 •
edited
Loading

⚪ 2025-04-01 18:10:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for 351c97e has started.
⚪ 2025-04-01 18:11:03 UTC Artifacts will be uploaded here
⚪ 2025-04-01 18:14:03 UTC ya make is running...
🟡 2025-04-01 19:15:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18780 17432 0 1 1215 132

⚪ 2025-04-01 19:17:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-01 19:38:11 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
198 (only retried tests) 70 0 0 0 128

🟢 2025-04-01 19:38:23 UTC Build successful.
🟢 2025-04-01 19:38:42 UTC ydbd size 2.1 GiB changed* by +42.1 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: fc17805 merge: 351c97e diff diff %
ydbd size 2 243 679 488 Bytes 2 243 722 600 Bytes +42.1 KiB +0.002%
ydbd stripped size 475 120 760 Bytes 475 135 608 Bytes +14.5 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 1, 2025 •
edited
Loading

⚪ 2025-04-01 18:10:59 UTC Pre-commit check linux-x86_64-release-asan for 351c97e has started.
⚪ 2025-04-01 18:11:54 UTC Artifacts will be uploaded here
⚪ 2025-04-01 18:14:52 UTC ya make is running...
🟡 2025-04-01 19:26:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11748 11507 0 193 10 38

⚪ 2025-04-01 19:27:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-01 19:48:15 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
291 (only retried tests) 252 0 0 6 33

🟢 2025-04-01 19:48:23 UTC Build successful.
🟢 2025-04-01 19:48:49 UTC ydbd size 3.6 GiB changed* by +58.1 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: fc17805 merge: 351c97e diff diff %
ydbd size 3 903 060 872 Bytes 3 903 120 360 Bytes +58.1 KiB +0.002%
ydbd stripped size 1 365 851 888 Bytes 1 365 860 784 Bytes +8.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@gridnevvvit gridnevvvit enabled auto-merge (squash) April 2, 2025 13:09
maximyurchuk
maximyurchuk previously approved these changes Apr 2, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Apr 2, 2025 •
edited
Loading

⚪ 2025-04-02 17:44:44 UTC Pre-commit check linux-x86_64-release-asan for 1e44532 has started.
⚪ 2025-04-02 17:45:01 UTC Artifacts will be uploaded here
⚪ 2025-04-02 17:47:48 UTC ya make is running...
🟡 2025-04-02 18:59:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11910 11845 0 22 8 35

⚪ 2025-04-02 19:00:25 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-02 19:20:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
97 (only retried tests) 56 0 3 5 33

⚪ 2025-04-02 19:20:39 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-04-02 19:40:19 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68 (only retried tests) 30 0 0 5 33

🟢 2025-04-02 19:40:25 UTC Build successful.
🟢 2025-04-02 19:40:51 UTC ydbd size 3.6 GiB changed* by +72.0 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: a56b602 merge: 1e44532 diff diff %
ydbd size 3 903 899 024 Bytes 3 903 972 768 Bytes +72.0 KiB +0.002%
ydbd stripped size 1 365 989 584 Bytes 1 366 010 512 Bytes +20.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 2, 2025 •
edited
Loading

⚪ 2025-04-02 17:44:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1e44532 has started.
⚪ 2025-04-02 17:45:04 UTC Artifacts will be uploaded here
⚪ 2025-04-02 17:47:58 UTC ya make is running...
🟡 2025-04-02 18:49:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18951 17589 0 2 1231 129

⚪ 2025-04-02 18:51:09 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-02 19:11:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
209 (only retried tests) 82 0 0 1 126

🟢 2025-04-02 19:11:49 UTC Build successful.
🟢 2025-04-02 19:12:07 UTC ydbd size 2.1 GiB changed* by +34.5 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: a56b602 merge: 1e44532 diff diff %
ydbd size 2 244 227 480 Bytes 2 244 262 856 Bytes +34.5 KiB +0.002%
ydbd stripped size 475 186 776 Bytes 475 193 752 Bytes +6.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@gridnevvvit gridnevvvit merged commit 5d617db into ydb-platform:stable-25-1 Apr 2, 2025
12 checks passed
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maximyurchuk maximyurchuk maximyurchuk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gridnevvvit @maximyurchuk