Skip to content

Conversation

@andrewstalin
Copy link
Contributor

@andrewstalin andrewstalin commented Apr 3, 2025

Changelog entry

When a parsing error occurs, exit is called. This behavior is not always acceptable. For example, in the case of fuzzing testing, the process is completed. Added "throw-on-parse-error" option that allows to throw an exception instead of exiting the process.

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

PR in main #16575

@andrewstalin andrewstalin requested a review from a team as a code owner April 3, 2025 08:44
@github-actions
Copy link

github-actions bot commented Apr 3, 2025

🟢 2025-04-03 09:02:53 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Apr 3, 2025

2025-04-03 08:47:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4e5c8a5 has started.
2025-04-03 08:52:15 UTC Artifacts will be uploaded here
2025-04-03 08:55:07 UTC ya make is running...
🟡 2025-04-03 10:01:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26379 23768 0 6 2472 133

2025-04-03 10:04:01 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-03 10:24:48 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
220 (only retried tests) 92 0 0 0 128

🟢 2025-04-03 10:24:55 UTC Build successful.
🟢 2025-04-03 10:25:15 UTC ydbd size 2.1 GiB changed* by +1.5 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 9b00e4f merge: 4e5c8a5 diff diff %
ydbd size 2 244 262 856 Bytes 2 244 264 368 Bytes +1.5 KiB +0.000%
ydbd stripped size 475 193 752 Bytes 475 194 008 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@azevaykin azevaykin changed the title TOptionsParseResult: throwing an exception in case of options parsing errors 25-1: TOptionsParseResult: throwing an exception in case of options parsing errors Apr 3, 2025
@andrewstalin andrewstalin requested a review from pnv1 April 3, 2025 09:04
@github-actions
Copy link

github-actions bot commented Apr 3, 2025

2025-04-03 09:47:23 UTC Pre-commit check linux-x86_64-release-asan for 4e5c8a5 has started.
2025-04-03 09:48:02 UTC Artifacts will be uploaded here
2025-04-03 09:50:57 UTC ya make is running...
🟡 2025-04-03 11:03:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12240 12152 0 43 6 39

2025-04-03 11:04:16 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-03 11:24:46 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
127 (only retried tests) 93 0 0 0 34

🟢 2025-04-03 11:24:56 UTC Build successful.
🟢 2025-04-03 11:25:22 UTC ydbd size 3.6 GiB changed* by +2.3 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 9b00e4f merge: 4e5c8a5 diff diff %
ydbd size 3 903 972 864 Bytes 3 903 975 176 Bytes +2.3 KiB +0.000%
ydbd stripped size 1 366 010 576 Bytes 1 366 011 344 Bytes +768 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@andrewstalin andrewstalin enabled auto-merge (squash) April 3, 2025 11:08
@andrewstalin andrewstalin merged commit dfed0b4 into ydb-platform:stable-25-1 Apr 3, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants