Skip to content

Support progress stats with basic stats mode #16773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shnikd merged 2 commits into from
Apr 4, 2025
Merged

Support progress stats with basic stats mode #16773

shnikd merged 2 commits into from
Apr 4, 2025

Conversation

@shnikd
Copy link
Contributor

@shnikd shnikd commented Apr 4, 2025 •
edited
Loading

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Support progress stats with basic stats mode

@shnikd shnikd requested review from a team as code owners April 4, 2025 10:31
@github-actions
Copy link

github-actions bot commented Apr 4, 2025 •
edited
Loading

🟢 2025-04-04 10:34:23 UTC The validation of the Pull Request description is successful.

@shnikd shnikd changed the title Support progress stats Support progress stats with basic stats mode Apr 4, 2025
@shnikd shnikd force-pushed the progress-stats-basic branch from 00759de to 615ffb7 Compare April 4, 2025 10:34
@github-actions
Copy link

github-actions bot commented Apr 4, 2025 •
edited
Loading

⚪ 2025-04-04 10:36:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 67f559a has started.
⚪ 2025-04-04 10:36:25 UTC Artifacts will be uploaded here
⚪ 2025-04-04 10:39:13 UTC ya make is running...
🔴 2025-04-04 10:42:20 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Apr 4, 2025 •
edited
Loading

⚪ 2025-04-04 10:36:10 UTC Pre-commit check linux-x86_64-release-asan for 67f559a has started.
⚪ 2025-04-04 10:36:25 UTC Artifacts will be uploaded here
⚪ 2025-04-04 10:39:17 UTC ya make is running...
🔴 2025-04-04 10:42:40 UTC Build failed, see the logs. Also see fail summary

@shnikd shnikd force-pushed the progress-stats-basic branch from 615ffb7 to 2c3c5e7 Compare April 4, 2025 12:00
@shnikd shnikd requested a review from a team as a code owner April 4, 2025 12:00
@github-actions
Copy link

github-actions bot commented Apr 4, 2025 •
edited
Loading

⚪ 2025-04-04 12:03:01 UTC Pre-commit check linux-x86_64-release-asan for f9ffa4f has started.
⚪ 2025-04-04 12:03:16 UTC Artifacts will be uploaded here
⚫ 2025-04-04 12:05:59 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 4, 2025 •
edited
Loading

⚪ 2025-04-04 12:03:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for f9ffa4f has started.
⚪ 2025-04-04 12:03:25 UTC Artifacts will be uploaded here
⚫ 2025-04-04 12:06:00 UTC Check cancelled

@shnikd shnikd force-pushed the progress-stats-basic branch from 2c3c5e7 to 51744a2 Compare April 4, 2025 12:05
@github-actions
Copy link

github-actions bot commented Apr 4, 2025 •
edited
Loading

⚪ 2025-04-04 12:07:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for eb3eead has started.
⚪ 2025-04-04 12:08:10 UTC Artifacts will be uploaded here
⚪ 2025-04-04 12:10:56 UTC ya make is running...
🟡 2025-04-04 13:34:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26902 24235 0 3 2553 111

⚪ 2025-04-04 13:36:41 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-04 13:45:30 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
163 (only retried tests) 62 0 0 0 101

🟢 2025-04-04 13:45:43 UTC Build successful.
🟡 2025-04-04 13:46:02 UTC ydbd size 2.2 GiB changed* by +463.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: c378eea merge: eb3eead diff diff %
ydbd size 2 351 269 256 Bytes 2 351 744 288 Bytes +463.9 KiB +0.020%
ydbd stripped size 491 735 744 Bytes 491 809 472 Bytes +72.0 KiB +0.015%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 4, 2025 •
edited
Loading

⚪ 2025-04-04 12:07:59 UTC Pre-commit check linux-x86_64-release-asan for eb3eead has started.
⚪ 2025-04-04 12:08:13 UTC Artifacts will be uploaded here
⚪ 2025-04-04 12:11:06 UTC ya make is running...
🟡 2025-04-04 13:38:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12451 12290 0 91 32 38

⚪ 2025-04-04 13:40:04 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-04 13:53:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
217 (only retried tests) 128 0 39 18 32

⚪ 2025-04-04 13:53:18 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-04 14:05:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
118 (only retried tests) 53 0 33 1 31

🟢 2025-04-04 14:05:32 UTC Build successful.
🟡 2025-04-04 14:06:02 UTC ydbd size 3.8 GiB changed* by +800.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ef19d60 merge: eb3eead diff diff %
ydbd size 4 125 423 568 Bytes 4 126 243 480 Bytes +800.7 KiB +0.020%
ydbd stripped size 1 425 352 232 Bytes 1 425 588 168 Bytes +230.4 KiB +0.017%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

gridnevvvit
gridnevvvit reviewed Apr 4, 2025
View reviewed changes
ydb/core/grpc_services/query/rpc_execute_query.cpp
if (NeedReportStats(*Request_->GetProtoRequest())) {
if (record.HasQueryStats()) {
FillQueryStats(*response.mutable_exec_stats(), record.GetQueryStats());
response.mutable_exec_stats()->set_query_plan(NKqp::SerializeAnalyzePlan(record.GetQueryStats()));
Copy link
Member

@gridnevvvit gridnevvvit Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не понимаю зачем была изменена эта строка?

Copy link
Contributor Author

@shnikd shnikd Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

потому что этот код уже вызывается здесь https://github.com/ydb-platform/ydb/blob/main/ydb/core/kqp/session_actor/kqp_session_actor.cpp#L1576 и здесь https://github.com/ydb-platform/ydb/blob/main/ydb/core/kqp/session_actor/kqp_session_actor.cpp#L1868

@shnikd shnikd requested a review from gridnevvvit April 4, 2025 12:21
vitstn
vitstn previously approved these changes Apr 4, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Apr 4, 2025 •
edited
Loading

⚪ 2025-04-04 16:30:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6a6420d has started.
⚪ 2025-04-04 16:31:15 UTC Artifacts will be uploaded here
⚪ 2025-04-04 16:34:29 UTC ya make is running...
🟡 2025-04-04 18:13:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28880 26206 0 2 2558 114

⚪ 2025-04-04 18:18:32 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-04 18:28:31 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
167 (only retried tests) 66 0 0 0 101

🟢 2025-04-04 18:28:44 UTC Build successful.
🟢 2025-04-04 18:29:11 UTC ydbd size 2.2 GiB changed* by +9.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2a34cb8 merge: 6a6420d diff diff %
ydbd size 2 351 393 048 Bytes 2 351 403 072 Bytes +9.8 KiB +0.000%
ydbd stripped size 491 750 272 Bytes 491 752 576 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 4, 2025 •
edited
Loading

⚪ 2025-04-04 16:32:10 UTC Pre-commit check linux-x86_64-release-asan for 6a6420d has started.
⚪ 2025-04-04 16:32:24 UTC Artifacts will be uploaded here
⚪ 2025-04-04 16:35:32 UTC ya make is running...
🟡 2025-04-04 18:28:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14387 14247 0 77 26 37

⚪ 2025-04-04 18:30:30 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-04 18:44:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
195 (only retried tests) 117 0 35 9 34

⚪ 2025-04-04 18:44:25 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-04 18:56:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
108 (only retried tests) 43 0 33 2 30

🟢 2025-04-04 18:56:36 UTC Build successful.
🟢 2025-04-04 18:57:07 UTC ydbd size 3.8 GiB changed* by +17.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2a34cb8 merge: 6a6420d diff diff %
ydbd size 4 125 708 080 Bytes 4 125 726 000 Bytes +17.5 KiB +0.000%
ydbd stripped size 1 425 429 288 Bytes 1 425 439 208 Bytes +9.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@shnikd shnikd enabled auto-merge (squash) April 4, 2025 17:08
@shnikd shnikd merged commit e06c432 into ydb-platform:main Apr 4, 2025
14 checks passed
shnikd added a commit to shnikd/ydb that referenced this pull request Apr 7, 2025
@shnikd
Support progress stats with basic stats mode (ydb-platform#16773)
db14310
@shnikd shnikd linked an issue Apr 7, 2025 that may be closed by this pull request
Support progress stats #16862
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vitstn vitstn vitstn approved these changes

@gridnevvvit gridnevvvit gridnevvvit approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support progress stats

3 participants

@shnikd @vitstn @gridnevvvit