Skip to content

Add per-drive locks info to the maintenance documentation #16835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ElenaAfina merged 2 commits into from
Apr 14, 2025
Merged

Add per-drive locks info to the maintenance documentation #16835

ElenaAfina merged 2 commits into from
Apr 14, 2025

Conversation

@SammyVimes
Copy link
Collaborator

@SammyVimes SammyVimes commented Apr 7, 2025

Changelog category

  • Documentation (changelog entry is not required)

@SammyVimes SammyVimes requested a review from a team as a code owner April 7, 2025 09:17
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 7, 2025
@github-actions
Copy link

github-actions bot commented Apr 7, 2025

🟢 2025-04-07 09:18:34 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Apr 7, 2025

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions
Copy link

github-actions bot commented Apr 7, 2025 •
edited
Loading

⚪ 2025-04-07 09:25:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1edecdf has started.
⚪ 2025-04-07 09:26:15 UTC Artifacts will be uploaded here
⚪ 2025-04-07 09:28:59 UTC ya make is running...
🟢 2025-04-07 09:29:04 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-04-07 09:29:10 UTC Build successful.

@SammyVimes SammyVimes mentioned this pull request Apr 7, 2025
Merged
@github-actions
Copy link

github-actions bot commented Apr 7, 2025 •
edited
Loading

⚪ 2025-04-07 09:36:53 UTC Pre-commit check linux-x86_64-release-asan for 1edecdf has started.
⚪ 2025-04-07 09:37:20 UTC Artifacts will be uploaded here
⚪ 2025-04-07 09:40:15 UTC ya make is running...
🟢 2025-04-07 09:40:20 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-04-07 09:40:26 UTC Build successful.

ElenaAfina
ElenaAfina suggested changes Apr 7, 2025
View reviewed changes
@SammyVimes @ElenaAfina
Apply suggestions from code review
b389b9c 
Co-authored-by: ElenaAfina <144937430+ElenaAfina@users.noreply.github.com>
@SammyVimes SammyVimes requested a review from ElenaAfina April 7, 2025 12:17
@github-actions
Copy link

github-actions bot commented Apr 7, 2025

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions
Copy link

github-actions bot commented Apr 7, 2025 •
edited
Loading

⚪ 2025-04-07 12:24:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5c078ca has started.
⚪ 2025-04-07 12:24:42 UTC Artifacts will be uploaded here
⚪ 2025-04-07 12:27:17 UTC ya make is running...
🟢 2025-04-07 12:27:22 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-04-07 12:27:28 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Apr 7, 2025 •
edited
Loading

⚪ 2025-04-07 12:26:44 UTC Pre-commit check linux-x86_64-release-asan for 5c078ca has started.
⚪ 2025-04-07 12:27:19 UTC Artifacts will be uploaded here
⚪ 2025-04-07 12:30:07 UTC ya make is running...
🟢 2025-04-07 12:30:13 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-04-07 12:30:20 UTC Build successful.

@SammyVimes
Copy link
Collaborator Author

SammyVimes commented Apr 10, 2025

@ElenaAfina gentle ping :)

@ElenaAfina
Copy link
Contributor

ElenaAfina commented Apr 14, 2025

@ElenaAfina gentle ping :)

really sorry for delay, I've missed a letter ((

ElenaAfina
ElenaAfina previously approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@ElenaAfina ElenaAfina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ElenaAfina ElenaAfina dismissed their stale review April 14, 2025 07:51

for final reviewer

@ElenaAfina ElenaAfina enabled auto-merge (squash) April 14, 2025 07:57
@SammyVimes SammyVimes requested a review from ElenaAfina April 14, 2025 10:11
@SammyVimes
Copy link
Collaborator Author

SammyVimes commented Apr 14, 2025

@ElenaAfina привет! Тут нужен именно от тебя ещё аппрув, т.к. владение у ydb-platform/docs

@ElenaAfina ElenaAfina merged commit 215d1a5 into ydb-platform:main Apr 14, 2025
16 checks passed
@liruoko liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyberROFL CyberROFL CyberROFL approved these changes

@fomichev3000 fomichev3000 fomichev3000 approved these changes

@ElenaAfina ElenaAfina Awaiting requested review from ElenaAfina

Assignees

@ElenaAfina ElenaAfina

Labels

changelog/f25-3 PR участвует в списке изменений documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SammyVimes @ElenaAfina @CyberROFL @fomichev3000 @liruoko