Skip to content

Conversation

@nikvas0
Copy link
Collaborator

@nikvas0 nikvas0 commented Apr 7, 2025

Changelog entry

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Some short tasks could be considered long and cause heavy profile stats collection.

@nikvas0 nikvas0 requested a review from a team as a code owner April 7, 2025 09:32
@github-actions
Copy link

github-actions bot commented Apr 7, 2025

2025-04-07 09:32:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for aa79e29 has started.
2025-04-07 09:32:56 UTC Artifacts will be uploaded here
2025-04-07 09:35:40 UTC ya make is running...
🟡 2025-04-07 10:32:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19398 18034 0 5 1251 108

2025-04-07 10:34:00 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-07 10:44:24 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
163 (only retried tests) 63 0 0 0 100

🟢 2025-04-07 10:44:35 UTC Build successful.
🟡 2025-04-07 10:44:55 UTC ydbd size 2.2 GiB changed* by +847.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 95387e2 merge: aa79e29 diff diff %
ydbd size 2 354 469 984 Bytes 2 355 337 960 Bytes +847.6 KiB +0.037%
ydbd stripped size 492 040 672 Bytes 492 496 288 Bytes +444.9 KiB +0.093%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 7, 2025

🟢 2025-04-07 09:33:39 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Apr 7, 2025

2025-04-07 09:40:44 UTC Pre-commit check linux-x86_64-release-asan for aa79e29 has started.
2025-04-07 09:40:48 UTC Artifacts will be uploaded here
2025-04-07 09:43:37 UTC ya make is running...
🟡 2025-04-07 10:57:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12133 12004 0 63 31 35

2025-04-07 10:59:02 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-07 11:11:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
177 (only retried tests) 104 0 34 7 32

2025-04-07 11:11:56 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-07 11:24:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
101 (only retried tests) 36 0 33 1 31

🟢 2025-04-07 11:24:29 UTC Build successful.
🟡 2025-04-07 11:25:02 UTC ydbd size 3.8 GiB changed* by +1.0 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 95387e2 merge: aa79e29 diff diff %
ydbd size 4 131 699 168 Bytes 4 132 795 664 Bytes +1.0 MiB +0.027%
ydbd stripped size 1 427 182 056 Bytes 1 427 781 768 Bytes +585.7 KiB +0.042%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

// enough to result in an enormous duration - triggering the "long tasks" mode.

auto taskDuration = TDuration::MilliSeconds(task.GetFinishTimeMs() - task.GetStartTimeMs());
auto taskDuration = TDuration::MilliSeconds(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like here

if (startTimeMs && finishTimeMs > startTimeMs) {

@nikvas0 nikvas0 enabled auto-merge (squash) April 7, 2025 10:07
@nikvas0 nikvas0 merged commit 5b2a106 into ydb-platform:main Apr 7, 2025
17 checks passed
nikvas0 added a commit to nikvas0/ydb that referenced this pull request Apr 8, 2025
dorooleg pushed a commit to dorooleg/ydb that referenced this pull request Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants