Skip to content

Conversation

@StekPerepolnen
Copy link
Collaborator

@StekPerepolnen StekPerepolnen commented Apr 8, 2025

Changelog entry

set a default value for layoutCorrect

Changelog category

  • Bugfix

Description for reviewers

The scenario for HealthCheck was missed where BSC may not set layoutCorrect in the response in older YDB versions. In this case, layoutCorrect will be read as false by default and healthcheck could report bad layout issues.
...

@StekPerepolnen StekPerepolnen requested a review from a team as a code owner April 8, 2025 15:21
@StekPerepolnen StekPerepolnen requested review from CyberROFL and removed request for CyberROFL April 8, 2025 15:21
@StekPerepolnen StekPerepolnen changed the title healthcheck layout fix healthcheck LayoutCorrect no info fix Apr 8, 2025
@StekPerepolnen StekPerepolnen requested a review from vporyadke April 8, 2025 15:22
@github-actions github-actions bot added the bugfix label Apr 8, 2025
@github-actions
Copy link

github-actions bot commented Apr 8, 2025

🔴 2025-04-08 15:38:54 UTC The validation of the Pull Request description has failed. Please update the description.

Bugfix requires a linked issue in the changelog entry

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

2025-04-08 15:24:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2cdc886 has started.
2025-04-08 15:25:11 UTC Artifacts will be uploaded here
2025-04-08 15:26:51 UTC Check cancelled

@StekPerepolnen StekPerepolnen force-pushed the healthcheck-layout-fix branch from 2f29dee to 773ccab Compare April 8, 2025 15:26
@github-actions
Copy link

github-actions bot commented Apr 8, 2025

2025-04-08 15:26:35 UTC Pre-commit check linux-x86_64-release-asan for 2cdc886 has started.
2025-04-08 15:26:38 UTC Check cancelled

@StekPerepolnen StekPerepolnen force-pushed the healthcheck-layout-fix branch from 773ccab to 3806df9 Compare April 8, 2025 15:32
@StekPerepolnen StekPerepolnen changed the title healthcheck LayoutCorrect no info fix healthcheck LayoutCorrect default true fix Apr 8, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels Apr 8, 2025
@StekPerepolnen StekPerepolnen changed the title healthcheck LayoutCorrect default true fix Set BSC LayoutCorrect default true Apr 8, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels Apr 8, 2025
@StekPerepolnen StekPerepolnen force-pushed the healthcheck-layout-fix branch from 3806df9 to fcd92d3 Compare April 8, 2025 16:10
@StekPerepolnen StekPerepolnen requested a review from serbel324 April 8, 2025 16:13
@github-actions
Copy link

github-actions bot commented Apr 8, 2025

2025-04-08 16:43:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for db7ba23 has started.
2025-04-08 16:43:49 UTC Artifacts will be uploaded here
2025-04-08 16:47:32 UTC ya make is running...
🟡 2025-04-08 18:27:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28780 26110 0 4 2554 112

2025-04-08 18:29:27 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-08 18:40:22 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
162 (only retried tests) 58 0 0 0 104

🟢 2025-04-08 18:40:29 UTC Build successful.
🟢 2025-04-08 18:40:48 UTC ydbd size 2.2 GiB changed* by +4.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3321dfa merge: db7ba23 diff diff %
ydbd size 2 356 376 904 Bytes 2 356 381 912 Bytes +4.9 KiB +0.000%
ydbd stripped size 492 622 208 Bytes 492 623 680 Bytes +1.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

2025-04-08 16:57:33 UTC Pre-commit check linux-x86_64-release-asan for db7ba23 has started.
2025-04-08 16:58:02 UTC Artifacts will be uploaded here
2025-04-08 17:01:47 UTC ya make is running...
🟡 2025-04-08 18:57:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14281 14081 0 133 30 37

2025-04-08 18:58:48 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-08 19:12:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
265 (only retried tests) 179 0 39 13 34

2025-04-08 19:12:13 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-08 19:24:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
119 (only retried tests) 46 0 36 3 34

🟢 2025-04-08 19:24:51 UTC Build successful.
🟢 2025-04-08 19:25:28 UTC ydbd size 3.9 GiB changed* by -208 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: a22835a merge: db7ba23 diff diff %
ydbd size 4 134 405 136 Bytes 4 134 404 928 Bytes -208 Bytes -0.000%
ydbd stripped size 1 428 154 088 Bytes 1 428 154 024 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@StekPerepolnen StekPerepolnen merged commit e1ad79a into main Apr 10, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix changelog/f25-3 PR участвует в списке изменений

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants