Add operation details in audit logging of operation 'MODIFY USER' #16989

flown4qqqq · 2025-04-09T12:06:13Z

Changelog entry

In schemeshard, we have audit_log_component, which outputs audit logs. There was not details of operation MODIFY(ALTER) USER. So, we need to know what this operation do. There are some ways:

Change the password (or hash);
Block user;
Unblock user.

This PR adds details into audit_log.

Changelog category

Improvement

github-actions · 2025-04-09T12:07:25Z

🟢 2025-04-09 12:17:57 UTC The validation of the Pull Request description is successful.

github-actions · 2025-04-09T12:09:35Z

⚪ 2025-04-09 12:09:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 835f439 has started.
⚪ 2025-04-09 12:09:49 UTC Artifacts will be uploaded here
⚪ 2025-04-09 12:12:44 UTC ya make is running...
🔴 2025-04-09 12:23:53 UTC Build failed, see the logs. Also see fail summary

github-actions · 2025-04-09T12:10:23Z

⚪ 2025-04-09 12:10:22 UTC Pre-commit check linux-x86_64-release-asan for 835f439 has started.
⚪ 2025-04-09 12:10:38 UTC Artifacts will be uploaded here
⚪ 2025-04-09 12:13:26 UTC ya make is running...
🔴 2025-04-09 12:22:27 UTC Build failed, see the logs. Also see fail summary

github-actions · 2025-04-09T12:26:59Z

⚪ 2025-04-09 12:26:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for f457517 has started.
⚪ 2025-04-09 12:27:14 UTC Artifacts will be uploaded here
⚪ 2025-04-09 12:29:57 UTC ya make is running...
⚫ 2025-04-09 12:39:31 UTC Check cancelled

github-actions · 2025-04-09T12:29:02Z

⚪ 2025-04-09 12:29:01 UTC Pre-commit check linux-x86_64-release-asan for f457517 has started.
⚪ 2025-04-09 12:29:16 UTC Artifacts will be uploaded here
⚪ 2025-04-09 12:32:02 UTC ya make is running...

github-actions · 2025-04-09T12:46:35Z

⚪ 2025-04-09 12:46:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 549e633 has started.
⚪ 2025-04-09 12:46:50 UTC Artifacts will be uploaded here
⚪ 2025-04-09 12:49:36 UTC ya make is running...
🟡 2025-04-09 13:49:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
19865	18502	0	3	1245	115

⚪ 2025-04-09 13:51:43 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-09 14:03:09 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
165 (only retried tests)	61	0	0	0	104

🟢 2025-04-09 14:03:16 UTC Build successful.
🟢 2025-04-09 14:03:39 UTC ydbd size 2.2 GiB changed* by +11.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `651a677`	merge: `549e633`	diff	diff %
ydbd size	2 357 506 656 Bytes	2 357 518 800 Bytes	+11.9 KiB	+0.001%
ydbd stripped size	492 796 384 Bytes	492 797 280 Bytes	+896 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-04-09T12:46:45Z

⚪ 2025-04-09 12:46:44 UTC Pre-commit check linux-x86_64-release-asan for 549e633 has started.
⚪ 2025-04-09 12:46:59 UTC Artifacts will be uploaded here
⚪ 2025-04-09 12:49:46 UTC ya make is running...
🟡 2025-04-09 14:13:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
12277	11913	0	283	40	41

⚪ 2025-04-09 14:14:12 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-09 14:30:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
431 (only retried tests)	326	0	50	20	35

⚪ 2025-04-09 14:30:52 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-09 14:46:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
145 (only retried tests)	63	0	38	9	35

🟢 2025-04-09 14:47:06 UTC Build successful.
🟢 2025-04-09 14:47:43 UTC ydbd size 3.9 GiB changed* by +20.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `651a677`	merge: `549e633`	diff	diff %
ydbd size	4 136 337 160 Bytes	4 136 357 632 Bytes	+20.0 KiB	+0.000%
ydbd stripped size	1 428 684 488 Bytes	1 428 690 760 Bytes	+6.1 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-04-09T15:34:35Z

⚪ 2025-04-09 15:34:35 UTC Pre-commit check linux-x86_64-release-asan for 75dfc95 has started.
⚪ 2025-04-09 15:34:50 UTC Artifacts will be uploaded here
⚪ 2025-04-09 15:37:38 UTC ya make is running...
🟡 2025-04-09 16:54:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
12279	12128	0	80	34	37

⚪ 2025-04-09 16:55:08 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-09 17:11:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
202 (only retried tests)	115	0	37	16	34

⚪ 2025-04-09 17:11:41 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-09 17:23:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
121 (only retried tests)	51	0	35	2	33

🟢 2025-04-09 17:24:06 UTC Build successful.
🟡 2025-04-09 17:24:39 UTC ydbd size 3.9 GiB changed* by +241.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `a55bf5d`	merge: `75dfc95`	diff	diff %
ydbd size	4 136 371 848 Bytes	4 136 619 552 Bytes	+241.9 KiB	+0.006%
ydbd stripped size	1 428 697 288 Bytes	1 428 741 832 Bytes	+43.5 KiB	+0.003%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-04-09T15:35:28Z

⚪ 2025-04-09 15:35:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for 75dfc95 has started.
⚪ 2025-04-09 15:35:42 UTC Artifacts will be uploaded here
⚪ 2025-04-09 15:38:27 UTC ya make is running...
🟡 2025-04-09 16:37:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
19870	18503	0	1	1250	116

⚪ 2025-04-09 16:38:46 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-09 16:49:40 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
167 (only retried tests)	62	0	0	0	105

🟢 2025-04-09 16:49:47 UTC Build successful.
🟢 2025-04-09 16:50:06 UTC ydbd size 2.2 GiB changed* by +17.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `6853d24`	merge: `75dfc95`	diff	diff %
ydbd size	2 357 628 864 Bytes	2 357 646 280 Bytes	+17.0 KiB	+0.001%
ydbd stripped size	492 806 944 Bytes	492 813 088 Bytes	+6.0 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

ijon · 2025-04-10T08:53:46Z

ydb/core/tx/schemeshard/schemeshard_audit_log.cpp

+        AUDIT_PART("login_group", logEntry.LoginGroup)
+        AUDIT_PART("login_member", logEntry.LoginMember)
+
+        AUDIT_PART("login_modify_user_change", RenderList(logEntry.LoginModifyUserChange), logEntry.LoginModifyUserChange)


Я бы сократил до login_user_change (LoginModifyUserChange -- тоже).

github-actions · 2025-04-10T10:52:49Z

⚪ 2025-04-10 10:52:47 UTC Pre-commit check linux-x86_64-release-asan for 40494d8 has started.
⚪ 2025-04-10 10:52:57 UTC Artifacts will be uploaded here
⚪ 2025-04-10 10:55:49 UTC ya make is running...
🟡 2025-04-10 12:16:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
12282	12132	0	80	32	38

⚪ 2025-04-10 12:17:20 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-10 12:33:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
207 (only retried tests)	116	0	38	19	34

⚪ 2025-04-10 12:33:17 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-10 12:45:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
126 (only retried tests)	50	0	34	8	34

🟢 2025-04-10 12:45:49 UTC Build successful.
🟢 2025-04-10 12:46:20 UTC ydbd size 3.9 GiB changed* by +29.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `cbbff2d`	merge: `40494d8`	diff	diff %
ydbd size	4 137 021 664 Bytes	4 137 052 088 Bytes	+29.7 KiB	+0.001%
ydbd stripped size	1 428 885 768 Bytes	1 428 895 432 Bytes	+9.4 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-04-10T11:15:47Z

⚪ 2025-04-10 11:15:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for 40494d8 has started.
⚪ 2025-04-10 11:16:52 UTC Artifacts will be uploaded here
⚪ 2025-04-10 11:20:15 UTC ya make is running...
🟡 2025-04-10 12:20:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
19873	18508	0	3	1244	118

⚪ 2025-04-10 12:22:06 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-10 12:35:30 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
166 (only retried tests)	61	0	0	0	105

🟢 2025-04-10 12:35:37 UTC Build successful.
🟢 2025-04-10 12:35:59 UTC ydbd size 2.2 GiB changed* by +17.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `cbbff2d`	merge: `40494d8`	diff	diff %
ydbd size	2 357 823 936 Bytes	2 357 841 616 Bytes	+17.3 KiB	+0.001%
ydbd stripped size	492 814 880 Bytes	492 817 760 Bytes	+2.8 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

…6989)

CyberROFL · 2025-04-13T10:49:56Z

ydb/core/tx/schemeshard/schemeshard_audit_log.cpp

+        AUDIT_PART("cloud_id", cloud_id, !cloud_id.empty())
+        AUDIT_PART("folder_id", folder_id, !folder_id.empty())
+        AUDIT_PART("resource_id", database_id, !database_id.empty())


Бессмысленный дифф. Достаточно было добавить Y_SEMICOLON_GUARD в AUDIT_PART.

Смысл был, видимо, в том, чтобы везде либо стоят ;, либо не стоят

flown4qqqq requested a review from a team as a code owner April 9, 2025 12:06

github-actions bot added the improvement label Apr 9, 2025

flown4qqqq requested a review from ijon April 9, 2025 12:08

github-actions bot added improvement and removed improvement labels Apr 9, 2025

flown4qqqq force-pushed the audit-log-modify-user branch from 837997f to 819ed60 Compare April 9, 2025 12:25

init commit

d7efeee

flown4qqqq force-pushed the audit-log-modify-user branch from 819ed60 to d7efeee Compare April 9, 2025 12:38

Change field

d15ef5c

flown4qqqq self-assigned this Apr 9, 2025

ijon previously approved these changes Apr 10, 2025

View reviewed changes

improved variables name

d8df21c

flown4qqqq dismissed ijon’s stale review via d8df21c April 10, 2025 10:48

ijon approved these changes Apr 10, 2025

View reviewed changes

flown4qqqq merged commit 8482e6c into ydb-platform:main Apr 10, 2025
13 checks passed

flown4qqqq added a commit that referenced this pull request Apr 11, 2025

Add operation details in audit logging of operation 'MODIFY USER' (#1…

9dfe69c

…6989)

flown4qqqq mentioned this pull request Apr 11, 2025

25-1: Cherry pick audit logs #17114

Merged

CyberROFL reviewed Apr 13, 2025

View reviewed changes

liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025

Add operation details in audit logging of operation 'MODIFY USER' #16989

Add operation details in audit logging of operation 'MODIFY USER' #16989

Uh oh!

Conversation

flown4qqqq commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog entry

Changelog category

Uh oh!

github-actions bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ijon Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

CyberROFL Apr 13, 2025

Choose a reason for hiding this comment

Uh oh!

flown4qqqq Apr 13, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

flown4qqqq commented Apr 9, 2025 •

edited

Loading

github-actions bot commented Apr 9, 2025 •

edited

Loading

github-actions bot commented Apr 9, 2025 •

edited

Loading

github-actions bot commented Apr 9, 2025 •

edited

Loading

github-actions bot commented Apr 9, 2025 •

edited

Loading

github-actions bot commented Apr 9, 2025 •

edited

Loading

github-actions bot commented Apr 9, 2025 •

edited

Loading

github-actions bot commented Apr 9, 2025 •

edited

Loading

github-actions bot commented Apr 9, 2025 •

edited

Loading

github-actions bot commented Apr 9, 2025 •

edited

Loading

github-actions bot commented Apr 10, 2025 •

edited

Loading

github-actions bot commented Apr 10, 2025 •

edited

Loading