Skip to content

Remove aliveness check for quoter #17026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Enjection merged 1 commit into from
Apr 12, 2025
Merged

Remove aliveness check for quoter #17026

Enjection merged 1 commit into from
Apr 12, 2025

Conversation

@Enjection
Copy link
Member

@Enjection Enjection commented Apr 10, 2025

Changelog entry

...

Changelog category

  • New feature
  • Experimental feature
  • Improvement
  • Performance improvement
  • User Interface
  • Bugfix
  • Backward incompatible change
  • Documentation (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@Enjection Enjection requested a review from a team as a code owner April 10, 2025 02:42
@Enjection Enjection requested a review from pixcc April 10, 2025 02:42
@Enjection Enjection removed the request for review from pixcc April 10, 2025 02:42
@github-actions
Copy link

github-actions bot commented Apr 10, 2025

🟢 2025-04-10 02:43:22 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Apr 10, 2025 •
edited
Loading

⚪ 2025-04-10 02:45:54 UTC Pre-commit check linux-x86_64-release-asan for bcf8c1b has started.
⚪ 2025-04-10 02:46:08 UTC Artifacts will be uploaded here
⚪ 2025-04-10 02:48:50 UTC ya make is running...
🟡 2025-04-10 04:03:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12141 11951 0 121 31 38

⚪ 2025-04-10 04:04:35 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-10 04:17:44 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
259 (only retried tests) 181 0 39 5 34

⚪ 2025-04-10 04:17:54 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-10 04:30:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 (only retried tests) 42 0 36 1 34

🟢 2025-04-10 04:30:11 UTC Build successful.
🟢 2025-04-10 04:30:42 UTC ydbd size 3.9 GiB changed* by -80 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 6853d24 merge: bcf8c1b diff diff %
ydbd size 4 136 601 624 Bytes 4 136 601 544 Bytes -80 Bytes -0.000%
ydbd stripped size 1 428 737 224 Bytes 1 428 737 160 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 10, 2025 •
edited
Loading

⚪ 2025-04-10 02:45:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for bcf8c1b has started.
⚪ 2025-04-10 02:46:09 UTC Artifacts will be uploaded here
⚪ 2025-04-10 02:48:54 UTC ya make is running...
🟡 2025-04-10 03:49:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19518 18145 0 11 1247 115

⚪ 2025-04-10 03:51:08 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-10 04:01:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
183 (only retried tests) 77 0 3 0 103

⚪ 2025-04-10 04:01:54 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-04-10 04:11:49 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
147 (only retried tests) 42 0 2 0 103

🟢 2025-04-10 04:11:58 UTC Build successful.
🟢 2025-04-10 04:12:19 UTC ydbd size 2.2 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 6853d24 merge: bcf8c1b diff diff %
ydbd size 2 357 628 864 Bytes 2 357 628 864 Bytes 0 Bytes 0.000%
ydbd stripped size 492 806 944 Bytes 492 806 944 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@naspirato naspirato added the rebase-and-check Rebase PR with the current base branch and check label Apr 11, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Apr 11, 2025
@github-actions
Copy link

github-actions bot commented Apr 11, 2025 •
edited
Loading

⚪ 2025-04-11 12:18:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for f16c787 has started.
⚪ 2025-04-11 12:18:46 UTC Artifacts will be uploaded here
⚪ 2025-04-11 12:21:31 UTC ya make is running...
🟡 2025-04-11 13:32:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19528 18146 0 5 1263 114

⚪ 2025-04-11 13:34:04 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-11 13:47:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
182 (only retried tests) 78 0 1 0 103

⚪ 2025-04-11 13:47:51 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-04-11 13:59:46 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
144 (only retried tests) 41 0 1 0 102

🟢 2025-04-11 13:59:56 UTC Build successful.
🟡 2025-04-11 14:00:17 UTC ydbd size 2.2 GiB changed* by +929.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e7cfbdc merge: f16c787 diff diff %
ydbd size 2 358 194 384 Bytes 2 359 146 200 Bytes +929.5 KiB +0.040%
ydbd stripped size 492 877 312 Bytes 493 020 896 Bytes +140.2 KiB +0.029%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 11, 2025 •
edited
Loading

⚪ 2025-04-11 12:18:32 UTC Pre-commit check linux-x86_64-release-asan for f16c787 has started.
⚪ 2025-04-11 12:18:47 UTC Artifacts will be uploaded here
⚪ 2025-04-11 12:21:33 UTC ya make is running...
🟡 2025-04-11 14:00:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12142 11943 0 133 31 35

⚪ 2025-04-11 14:01:45 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-11 14:14:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
262 (only retried tests) 180 0 44 5 33

⚪ 2025-04-11 14:14:59 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-11 14:29:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
125 (only retried tests) 43 0 44 4 34

🟢 2025-04-11 14:29:12 UTC Build successful.
🟡 2025-04-11 14:29:42 UTC ydbd size 3.9 GiB changed* by +2.0 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e7cfbdc merge: f16c787 diff diff %
ydbd size 4 137 610 888 Bytes 4 139 656 304 Bytes +2.0 MiB +0.049%
ydbd stripped size 1 429 038 408 Bytes 1 429 617 128 Bytes +565.2 KiB +0.040%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Enjection Enjection added the rebase-and-check Rebase PR with the current base branch and check label Apr 11, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Apr 11, 2025
@github-actions
Copy link

github-actions bot commented Apr 11, 2025 •
edited
Loading

⚪ 2025-04-11 21:26:36 UTC Pre-commit check linux-x86_64-release-asan for d73a049 has started.
⚪ 2025-04-11 21:26:51 UTC Artifacts will be uploaded here
⚪ 2025-04-11 21:29:32 UTC ya make is running...
🟡 2025-04-11 22:45:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12144 11964 0 113 33 34

⚪ 2025-04-11 22:46:30 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-11 23:01:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
245 (only retried tests) 152 0 48 13 32

⚪ 2025-04-11 23:01:51 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-11 23:14:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
136 (only retried tests) 55 0 44 8 29

🟢 2025-04-11 23:14:56 UTC Build successful.
🟢 2025-04-11 23:15:25 UTC ydbd size 3.9 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 36fdf83 merge: d73a049 diff diff %
ydbd size 4 140 616 792 Bytes 4 140 616 696 Bytes -96 Bytes -0.000%
ydbd stripped size 1 429 785 000 Bytes 1 429 784 936 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 11, 2025 •
edited
Loading

⚪ 2025-04-11 21:28:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for d73a049 has started.
⚪ 2025-04-11 21:29:14 UTC Artifacts will be uploaded here
⚪ 2025-04-11 21:32:02 UTC ya make is running...
🟡 2025-04-11 22:41:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19566 18174 0 5 1269 118

⚪ 2025-04-11 22:42:52 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-11 22:54:47 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
195 (only retried tests) 88 0 0 0 107

🟢 2025-04-11 22:54:54 UTC Build successful.
🟢 2025-04-11 22:55:13 UTC ydbd size 2.2 GiB changed* by -16 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 36fdf83 merge: d73a049 diff diff %
ydbd size 2 359 758 128 Bytes 2 359 758 112 Bytes -16 Bytes -0.000%
ydbd stripped size 493 079 584 Bytes 493 079 584 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Enjection Enjection merged commit 054496a into ydb-platform:main Apr 12, 2025
26 of 28 checks passed
@naspirato naspirato mentioned this pull request Apr 14, 2025
Closed
@Enjection Enjection mentioned this pull request May 19, 2025
Closed
Enjection added a commit to Enjection/ydb that referenced this pull request May 19, 2025
@Enjection
Remove aliveness check for quoter (ydb-platform#17026)
f27f943
@Enjection Enjection mentioned this pull request May 19, 2025
Merged
Enjection added a commit to Enjection/ydb that referenced this pull request May 19, 2025
@Enjection
Remove aliveness check for quoter (ydb-platform#17026)
9981c50
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 15, 2025
Closed
@liruoko liruoko added the release-scope-25-3 Для PR-ов. Означает "этот PR вошел в состав одной из версий 25-3-nnn" label Oct 13, 2025
@liruoko liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vporyadke vporyadke vporyadke approved these changes

Assignees

No one assigned

Labels

changelog/f25-3 PR участвует в списке изменений new-feature release-scope-25-3 Для PR-ов. Означает "этот PR вошел в состав одной из версий 25-3-nnn"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Enjection @vporyadke @liruoko @naspirato