Skip to content

Conversation

@nshestakov
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@nshestakov nshestakov requested a review from a team as a code owner April 10, 2025 11:44
@github-actions
Copy link

🟢 2025-04-10 11:45:06 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Apr 10, 2025

2025-04-10 12:07:27 UTC Pre-commit check linux-x86_64-release-asan for e6caf07 has started.
2025-04-10 12:08:06 UTC Artifacts will be uploaded here
2025-04-10 12:11:24 UTC ya make is running...
🟡 2025-04-10 13:27:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12654 12517 0 64 34 39

2025-04-10 13:28:17 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-10 13:43:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
190 (only retried tests) 109 0 38 10 33

2025-04-10 13:44:07 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-10 13:56:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
115 (only retried tests) 42 0 35 5 33

🟢 2025-04-10 13:56:28 UTC Build successful.
🟢 2025-04-10 13:56:59 UTC ydbd size 3.9 GiB changed* by +14.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: cbbff2d merge: e6caf07 diff diff %
ydbd size 4 137 021 664 Bytes 4 137 036 720 Bytes +14.7 KiB +0.000%
ydbd stripped size 1 428 885 768 Bytes 1 428 888 904 Bytes +3.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

target.SetSrcPath(AdjustPath(src, params.GetDatabase()));
target.SetDstPath(AdjustPath(dst, GetDatabase()));
target.SetTransformLambda(lambda);
if (settings.Settings.Batching && settings.Settings.Batching->BatchSizeBytes) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Стоит учесть, что такие проверки с переходом на std::optional будут проверять наличие значения, а не != 0

@github-actions
Copy link

github-actions bot commented Apr 10, 2025

2025-04-10 13:57:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for a9c6a1e has started.
2025-04-10 14:00:48 UTC Artifacts will be uploaded here
2025-04-10 14:04:28 UTC ya make is running...
🟡 2025-04-10 15:15:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27225 24548 0 1 2556 120

2025-04-10 15:17:40 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-10 15:28:58 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
171 (only retried tests) 67 0 0 0 104

🟢 2025-04-10 15:29:07 UTC Build successful.
🟡 2025-04-10 15:29:25 UTC ydbd size 2.2 GiB changed* by +252.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 644a176 merge: a9c6a1e diff diff %
ydbd size 2 357 832 672 Bytes 2 358 091 648 Bytes +252.9 KiB +0.011%
ydbd stripped size 492 816 416 Bytes 492 864 736 Bytes +47.2 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 10, 2025

2025-04-10 13:57:57 UTC Pre-commit check linux-x86_64-release-asan for a9c6a1e has started.
2025-04-10 14:01:34 UTC Artifacts will be uploaded here
2025-04-10 14:05:04 UTC ya make is running...
🟡 2025-04-10 15:38:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12656 12441 0 142 34 39

2025-04-10 15:39:56 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-10 15:55:44 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
277 (only retried tests) 170 0 51 22 34

2025-04-10 15:55:54 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-10 16:11:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
149 (only retried tests) 60 0 45 10 34

🟢 2025-04-10 16:11:49 UTC Build successful.
🟡 2025-04-10 16:12:20 UTC ydbd size 3.9 GiB changed* by +396.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f5719d8 merge: a9c6a1e diff diff %
ydbd size 4 137 035 696 Bytes 4 137 442 008 Bytes +396.8 KiB +0.010%
ydbd stripped size 1 428 888 072 Bytes 1 428 995 016 Bytes +104.4 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov enabled auto-merge (squash) April 10, 2025 15:31
@nshestakov nshestakov merged commit 30df4bd into ydb-platform:main Apr 10, 2025
14 checks passed
@nshestakov nshestakov deleted the TR_fix-uninitialized-batching branch August 27, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants