Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid new required fields in config #1710

Merged
merged 5 commits into from
Feb 8, 2024
Merged

Forbid new required fields in config #1710

merged 5 commits into from
Feb 8, 2024

Conversation

Enjection
Copy link
Member

Changelog entry

Forbid new required fields in config

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@Enjection Enjection requested a review from CyberROFL February 8, 2024 11:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚪ 2024-02-08 11:24:26 UTC Pre-commit check for 3eadf50 has started.
⚪ 2024-02-08 11:24:28 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-08 11:29:51 UTC Build successful.
⚪ 2024-02-08 11:30:01 UTC Tests are running...
🔴 2024-02-08 12:01:50 UTC Test run completed, no test results found for commit 500fbf0. Please check build logs.
⚫ 2024-02-08 12:01:53 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚪ 2024-02-08 11:25:28 UTC Pre-commit check for 3eadf50 has started.
⚪ 2024-02-08 11:25:31 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-08 11:27:05 UTC Build successful.
⚪ 2024-02-08 11:27:17 UTC Tests are running...
🔴 2024-02-08 12:01:49 UTC Test run completed, no test results found for commit 500fbf0. Please check build logs.
⚫ 2024-02-08 12:01:52 UTC Check cancelled

CyberROFL
CyberROFL requested changes Feb 8, 2024
View reviewed changes
ydb/core/config/ya.make Outdated Show resolved Hide resolved
ydb/core/config/utils/config_traverse.h Outdated Show resolved Hide resolved
ydb/core/config/utils/config_traverse.cpp Outdated Show resolved Hide resolved
ydb/core/config/ut/main.cpp Outdated Show resolved Hide resolved
Enjection and others added 2 commits February 8, 2024 15:01
@Enjection @CyberROFL
Update ydb/core/config/utils/config_traverse.cpp
f74f992 
Co-authored-by: Ilnaz Nizametdinov <i.nizametdinov@gmail.com>
@Enjection @CyberROFL
Update ydb/core/config/ya.make
d4a2726 
Co-authored-by: Ilnaz Nizametdinov <i.nizametdinov@gmail.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚪ 2024-02-08 12:03:03 UTC Pre-commit check for 81253cc has started.
⚪ 2024-02-08 12:03:05 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-08 12:05:05 UTC Build successful.
⚪ 2024-02-08 12:05:14 UTC Tests are running...
🔴 2024-02-08 12:09:55 UTC Test run completed, no test results found for commit d4a2726. Please check build logs.
⚫ 2024-02-08 12:09:58 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚪ 2024-02-08 12:05:09 UTC Pre-commit check for 81253cc has started.
⚪ 2024-02-08 12:05:12 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-08 12:06:52 UTC Build successful.
⚪ 2024-02-08 12:09:19 UTC Tests are running...
🔴 2024-02-08 12:09:53 UTC Test run completed, no test results found for commit d4a2726. Please check build logs.
⚫ 2024-02-08 12:09:55 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚪ 2024-02-08 12:10:36 UTC Pre-commit check for 8109914 has started.
⚪ 2024-02-08 12:10:37 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-08 12:12:51 UTC Build successful.
⚪ 2024-02-08 12:13:00 UTC Tests are running...
🔴 2024-02-08 12:29:37 UTC Test run completed, no test results found for commit b8aa5f9. Please check build logs.
⚫ 2024-02-08 12:29:40 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚪ 2024-02-08 12:11:11 UTC Pre-commit check for 8109914 has started.
⚪ 2024-02-08 12:11:12 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-08 12:12:40 UTC Build successful.
⚪ 2024-02-08 12:12:49 UTC Tests are running...
🔴 2024-02-08 12:29:37 UTC Test run completed, no test results found for commit b8aa5f9. Please check build logs.
⚫ 2024-02-08 12:29:40 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚪ 2024-02-08 12:30:17 UTC Pre-commit check for f10ed9e has started.
⚪ 2024-02-08 12:30:18 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-08 12:32:09 UTC Build successful.
⚪ 2024-02-08 12:32:22 UTC Tests are running...
🔴 2024-02-08 13:59:19 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14597 14464 0 26 71 36

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚪ 2024-02-08 12:33:01 UTC Pre-commit check for f10ed9e has started.
⚪ 2024-02-08 12:33:04 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-08 12:34:28 UTC Build successful.
⚪ 2024-02-08 12:34:40 UTC Tests are running...
🔴 2024-02-08 13:49:41 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67268 56420 0 3 10822 23

@Enjection Enjection merged commit 4ec8fd4 into ydb-platform:main Feb 8, 2024
2 of 4 checks passed
@Enjection Enjection deleted the feature/KIKIMR-21023/forbid-new-required-in-config branch February 8, 2024 14:38
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberROFL CyberROFL CyberROFL approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Enjection @CyberROFL