Skip to content

Conversation

@molotkov-and
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Add removing record about waiting cleanup shards from local db. Add check feature flag EnableDataErasure in add and remove partition

@molotkov-and molotkov-and requested a review from a team as a code owner April 11, 2025 12:29
@molotkov-and molotkov-and self-assigned this Apr 11, 2025
@github-actions
Copy link

🟢 2025-04-11 12:30:16 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Apr 11, 2025

2025-04-11 12:32:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0ebe004 has started.
2025-04-11 12:32:51 UTC Artifacts will be uploaded here
2025-04-11 12:35:40 UTC ya make is running...
🟡 2025-04-11 13:32:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19291 17945 0 2 1213 131

2025-04-11 13:34:28 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-11 13:55:12 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
196 (only retried tests) 65 0 0 0 131

🟢 2025-04-11 13:55:19 UTC Build successful.
🟢 2025-04-11 13:55:38 UTC ydbd size 2.1 GiB changed* by +560 Bytes, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: b3e1db3 merge: 0ebe004 diff diff %
ydbd size 2 244 528 872 Bytes 2 244 529 432 Bytes +560 Bytes +0.000%
ydbd stripped size 475 242 360 Bytes 475 242 296 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 11, 2025

2025-04-11 12:32:47 UTC Pre-commit check linux-x86_64-release-asan for 0ebe004 has started.
2025-04-11 12:33:02 UTC Artifacts will be uploaded here
2025-04-11 12:36:00 UTC ya make is running...
🟡 2025-04-11 13:50:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12030 11931 0 52 12 35

2025-04-11 13:51:36 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-11 14:12:09 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
143 (only retried tests) 109 0 0 1 33

🟢 2025-04-11 14:12:16 UTC Build successful.
🟢 2025-04-11 14:12:41 UTC ydbd size 3.6 GiB changed* by -1.1 KiB, which is <= 0 Bytes vs stable-25-1: OK

ydbd size dash stable-25-1: b3e1db3 merge: 0ebe004 diff diff %
ydbd size 3 904 422 472 Bytes 3 904 421 352 Bytes -1.1 KiB -0.000%
ydbd stripped size 1 366 139 280 Bytes 1 366 138 192 Bytes -1.1 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@molotkov-and molotkov-and merged commit 54775d3 into ydb-platform:stable-25-1 Apr 14, 2025
13 checks passed
@molotkov-and molotkov-and deleted the data-erasure-remove-waiting-shards-25-1 branch April 14, 2025 10:58
molotkov-and added a commit to molotkov-and/ydb that referenced this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants