Skip to content

Explain for CTAS #17128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikvas0 merged 10 commits into from
Apr 14, 2025
Merged

Explain for CTAS #17128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0de18bd
fix
nikvas0 Mar 16, 2025
3c39b7d
fix
nikvas0 Mar 31, 2025
ab7d48a
fix
nikvas0 Mar 31, 2025
9961c95
fix
nikvas0 Apr 8, 2025
8f5084e
fix
nikvas0 Apr 9, 2025
5379f27
fill-settings
nikvas0 Apr 11, 2025
f108832
fix
nikvas0 Apr 11, 2025
ba29908
explain-test
nikvas0 Apr 11, 2025
0122dbf
fix
nikvas0 Apr 11, 2025
9b13b49
fix
nikvas0 Apr 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ydb/core/kqp/executer_actor/kqp_data_executer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1626,7 +1626,7 @@ class TKqpDataExecuter : public TKqpExecuterBase<TKqpDataExecuter, EExecType::Da
shardTasks.emplace(shardId, task.Id);

FillSecureParamsFromStage(task.Meta.SecureParams, stage);
BuildSinks(stage, task);
BuildSinks(stage, stageInfo, task);

return task;
};
Expand Down
27 changes: 16 additions & 11 deletions ydb/core/kqp/executer_actor/kqp_executer_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,7 +914,7 @@ class TKqpExecuterBase : public TActor<TDerived> {
task.Meta.Type = TTaskMeta::TTaskType::Compute;

FillSecureParamsFromStage(task.Meta.SecureParams, stage);
BuildSinks(stage, task);
BuildSinks(stage, stageInfo, task);

LOG_D("Stage " << stageInfo.Id << " create sysview scan task: " << task.Id);
}
Expand All @@ -938,15 +938,20 @@ class TKqpExecuterBase : public TActor<TDerived> {
output.SinkSettings = extSink.GetSettings();
}

void BuildInternalSinks(const NKqpProto::TKqpSink& sink, TKqpTasksGraph::TTaskType& task) {
void BuildInternalSinks(const NKqpProto::TKqpSink& sink, const TStageInfo& stageInfo, TKqpTasksGraph::TTaskType& task) {
const auto& intSink = sink.GetInternalSink();
auto& output = task.Outputs[sink.GetOutputIndex()];
output.Type = TTaskOutputType::Sink;
output.SinkType = intSink.GetType();

if (intSink.GetSettings().Is<NKikimrKqp::TKqpTableSinkSettings>()) {
NKikimrKqp::TKqpTableSinkSettings settings;
YQL_ENSURE(intSink.GetSettings().UnpackTo(&settings), "Failed to unpack settings");
if (!stageInfo.Meta.ResolvedSinkSettings) {
YQL_ENSURE(intSink.GetSettings().UnpackTo(&settings), "Failed to unpack settings");
} else {
settings = *stageInfo.Meta.ResolvedSinkSettings;
}

auto& lockTxId = TasksGraph.GetMeta().LockTxId;
if (lockTxId) {
settings.SetLockTxId(*lockTxId);
Expand Down Expand Up @@ -974,14 +979,14 @@ class TKqpExecuterBase : public TActor<TDerived> {
}
}

void BuildSinks(const NKqpProto::TKqpPhyStage& stage, TKqpTasksGraph::TTaskType& task) {
void BuildSinks(const NKqpProto::TKqpPhyStage& stage, const TStageInfo& stageInfo, TKqpTasksGraph::TTaskType& task) {
if (stage.SinksSize() > 0) {
YQL_ENSURE(stage.SinksSize() == 1, "multiple sinks are not supported");
const auto& sink = stage.GetSinks(0);
YQL_ENSURE(sink.GetOutputIndex() < task.Outputs.size());

if (sink.HasInternalSink()) {
BuildInternalSinks(sink, task);
BuildInternalSinks(sink, stageInfo, task);
} else if (sink.HasExternalSink()) {
BuildExternalSinks(sink, task);
} else {
Expand Down Expand Up @@ -1062,7 +1067,7 @@ class TKqpExecuterBase : public TActor<TDerived> {

// finish building
for (auto taskId : tasksIds) {
BuildSinks(stage, TasksGraph.GetTask(taskId));
BuildSinks(stage, stageInfo, TasksGraph.GetTask(taskId));
}
}

Expand Down Expand Up @@ -1313,7 +1318,7 @@ class TKqpExecuterBase : public TActor<TDerived> {

auto buildSinks = [&]() {
for (const ui64 taskId : createdTasksIds) {
BuildSinks(stage, TasksGraph.GetTask(taskId));
BuildSinks(stage, stageInfo, TasksGraph.GetTask(taskId));
}
};

Expand Down Expand Up @@ -1434,7 +1439,7 @@ class TKqpExecuterBase : public TActor<TDerived> {
task.Meta.Type = TTaskMeta::TTaskType::Compute;
task.Meta.ExecuterId = SelfId();
FillSecureParamsFromStage(task.Meta.SecureParams, stage);
BuildSinks(stage, task);
BuildSinks(stage, stageInfo, task);
LOG_D("Stage " << stageInfo.Id << " create compute task: " << task.Id);
}
}
Expand Down Expand Up @@ -1713,7 +1718,7 @@ class TKqpExecuterBase : public TActor<TDerived> {
auto& task = TasksGraph.GetTask(taskIdx);
task.Meta.SetEnableShardsSequentialScan(readSettings.IsSorted());
PrepareScanMetaForUsage(task.Meta, keyTypes);
BuildSinks(stage, task);
BuildSinks(stage, stageInfo, task);
}
}

Expand Down Expand Up @@ -1767,7 +1772,7 @@ class TKqpExecuterBase : public TActor<TDerived> {
task.Meta.Type = TTaskMeta::TTaskType::Scan;
task.SetMetaId(t);
FillSecureParamsFromStage(task.Meta.SecureParams, stage);
BuildSinks(stage, task);
BuildSinks(stage, stageInfo, task);

for (const auto& readInfo: *task.Meta.Reads) {
Y_ENSURE(hashByShardId.contains(readInfo.ShardId));
Expand Down Expand Up @@ -1809,7 +1814,7 @@ class TKqpExecuterBase : public TActor<TDerived> {
task.Meta.Type = TTaskMeta::TTaskType::Scan;
task.SetMetaId(metaGlueingId);
FillSecureParamsFromStage(task.Meta.SecureParams, stage);
BuildSinks(stage, task);
BuildSinks(stage, stageInfo, task);
}
}
}
Expand Down
Loading
Loading