Skip to content

Fix tablet-topic transactions with sink #17258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nikvas0 merged 2 commits into from
Apr 17, 2025
Merged

Fix tablet-topic transactions with sink #17258

nikvas0 merged 2 commits into from
Apr 17, 2025

Conversation

@nikvas0
Copy link
Collaborator

@nikvas0 nikvas0 commented Apr 16, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Fix tablet-topic transactions with sink

@nikvas0 nikvas0 requested a review from a team as a code owner April 16, 2025 08:32
@github-actions
Copy link

github-actions bot commented Apr 16, 2025 •
edited
Loading

⚪ 2025-04-16 08:34:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3a5e132 has started.
⚪ 2025-04-16 08:35:40 UTC Artifacts will be uploaded here
⚪ 2025-04-16 08:38:52 UTC ya make is running...
🟡 2025-04-16 09:39:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20039 18649 0 9 1264 117

⚪ 2025-04-16 09:41:18 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-16 09:53:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
194 (only retried tests) 88 0 2 0 104

⚪ 2025-04-16 09:53:56 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-04-16 10:05:41 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
146 (only retried tests) 40 0 2 0 104

🟢 2025-04-16 10:05:48 UTC Build successful.
🟢 2025-04-16 10:06:13 UTC ydbd size 2.2 GiB changed* by -48 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 60d02e2 merge: 3a5e132 diff diff %
ydbd size 2 361 374 344 Bytes 2 361 374 296 Bytes -48 Bytes -0.000%
ydbd stripped size 493 412 768 Bytes 493 412 832 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 16, 2025

🟢 2025-04-16 08:39:02 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Apr 16, 2025 •
edited
Loading

⚪ 2025-04-16 08:40:12 UTC Pre-commit check linux-x86_64-release-asan for 3a5e132 has started.
⚪ 2025-04-16 08:40:28 UTC Artifacts will be uploaded here
⚪ 2025-04-16 08:43:21 UTC ya make is running...
🟡 2025-04-16 10:03:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12399 12231 0 98 31 39

⚪ 2025-04-16 10:04:35 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-16 10:18:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
230 (only retried tests) 137 0 42 16 35

⚪ 2025-04-16 10:18:37 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-16 10:31:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
128 (only retried tests) 57 0 35 3 33

🟢 2025-04-16 10:32:07 UTC Build successful.
🟢 2025-04-16 10:32:42 UTC ydbd size 3.9 GiB changed* by -336 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 60d02e2 merge: 3a5e132 diff diff %
ydbd size 4 143 753 184 Bytes 4 143 752 848 Bytes -336 Bytes -0.000%
ydbd stripped size 1 430 733 128 Bytes 1 430 733 064 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nikvas0 nikvas0 enabled auto-merge (squash) April 16, 2025 09:57
@nikvas0 nikvas0 mentioned this pull request Apr 16, 2025
Closed
@nikvas0 nikvas0 requested a review from a team as a code owner April 16, 2025 12:06
@github-actions
Copy link

github-actions bot commented Apr 16, 2025 •
edited
Loading

⚪ 2025-04-16 12:09:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for 31a2451 has started.
⚪ 2025-04-16 12:09:17 UTC Artifacts will be uploaded here
⚪ 2025-04-16 12:12:09 UTC ya make is running...
🟡 2025-04-16 13:17:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20044 18650 0 9 1266 119

⚪ 2025-04-16 13:19:04 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-16 13:31:16 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
194 (only retried tests) 89 0 0 0 105

🟢 2025-04-16 13:31:23 UTC Build successful.
🟢 2025-04-16 13:31:48 UTC ydbd size 2.2 GiB changed* by -16 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: b780fb0 merge: 31a2451 diff diff %
ydbd size 2 361 530 488 Bytes 2 361 530 472 Bytes -16 Bytes -0.000%
ydbd stripped size 493 535 264 Bytes 493 535 264 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 16, 2025 •
edited
Loading

⚪ 2025-04-16 12:11:29 UTC Pre-commit check linux-x86_64-release-asan for 31a2451 has started.
⚪ 2025-04-16 12:11:35 UTC Artifacts will be uploaded here
⚪ 2025-04-16 12:14:24 UTC ya make is running...
🟡 2025-04-16 13:37:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12404 12130 0 203 31 40

⚪ 2025-04-16 13:39:01 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-16 13:53:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
343 (only retried tests) 248 0 42 19 34

⚪ 2025-04-16 13:53:28 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-16 14:06:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
130 (only retried tests) 54 0 38 4 34

🟢 2025-04-16 14:06:07 UTC Build successful.
🟢 2025-04-16 14:06:45 UTC ydbd size 3.9 GiB changed* by -32 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: b780fb0 merge: 31a2451 diff diff %
ydbd size 4 143 812 648 Bytes 4 143 812 616 Bytes -32 Bytes -0.000%
ydbd stripped size 1 430 798 440 Bytes 1 430 798 440 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nikvas0 nikvas0 merged commit f6ff3ed into ydb-platform:main Apr 17, 2025
13 checks passed
nikvas0 added a commit to nikvas0/ydb that referenced this pull request May 7, 2025
@nikvas0
Fix tablet-topic transactions with sink (ydb-platform#17258)
5e229ef
@nikvas0 nikvas0 mentioned this pull request May 12, 2025
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gridnevvvit gridnevvvit gridnevvvit approved these changes

@Gazizonoki Gazizonoki Gazizonoki approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nikvas0 @gridnevvvit @Gazizonoki