Skip to content

Conversation

@azevaykin
Copy link
Collaborator

Changelog entry

Copy table should not check feature flags for columns types. If the types in original table are created then they should be allowed in destination table.

Changelog category

  • Bugfix

Description for reviewers

#17289
#17290

@azevaykin azevaykin requested a review from a team as a code owner April 17, 2025 06:46
@github-actions
Copy link

🟢 2025-04-17 06:48:00 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Apr 17, 2025

2025-04-17 06:50:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for e70017e has started.
2025-04-17 06:50:33 UTC Artifacts will be uploaded here
2025-04-17 06:53:32 UTC ya make is running...
🟡 2025-04-17 07:55:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19294 17936 0 3 1220 135

2025-04-17 07:56:42 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-17 08:17:25 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
209 (only retried tests) 74 0 0 7 128

🟢 2025-04-17 08:17:32 UTC Build successful.
🟢 2025-04-17 08:17:51 UTC ydbd size 2.1 GiB changed* by +496 Bytes, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: f885a05 merge: e70017e diff diff %
ydbd size 2 244 549 376 Bytes 2 244 549 872 Bytes +496 Bytes +0.000%
ydbd stripped size 475 246 456 Bytes 475 246 712 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 17, 2025

2025-04-17 06:50:22 UTC Pre-commit check linux-x86_64-release-asan for e70017e has started.
2025-04-17 06:50:37 UTC Artifacts will be uploaded here
2025-04-17 06:53:33 UTC ya make is running...
🟡 2025-04-17 08:11:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12033 11830 0 110 58 35

2025-04-17 08:12:45 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-17 08:33:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
249 (only retried tests) 159 0 6 51 33

2025-04-17 08:33:26 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-17 08:53:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
116 (only retried tests) 45 0 6 32 33

🟢 2025-04-17 08:53:37 UTC Build successful.
🟢 2025-04-17 08:54:06 UTC ydbd size 3.6 GiB changed* by -240 Bytes, which is <= 0 Bytes vs stable-25-1: OK

ydbd size dash stable-25-1: f885a05 merge: e70017e diff diff %
ydbd size 3 904 455 888 Bytes 3 904 455 648 Bytes -240 Bytes -0.000%
ydbd stripped size 1 366 152 912 Bytes 1 366 152 144 Bytes -768 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@azevaykin azevaykin linked an issue Apr 17, 2025 that may be closed by this pull request
@azevaykin azevaykin merged commit 1661faa into ydb-platform:stable-25-1 Apr 17, 2025
13 checks passed
@azevaykin azevaykin deleted the stable-25-1-CopyTable branch April 17, 2025 09:03
azevaykin added a commit to azevaykin/ydb that referenced this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copy table fails backward compability

2 participants